Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp5596180rwd; Mon, 12 Jun 2023 07:14:39 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7ksm8OzO1rv11lm7G3DQRaxJsz5oXgQsKCWU8R2BpETo9Jncl7HR696iV99Io7uW7i73Yr X-Received: by 2002:a17:907:9806:b0:94f:5847:8ac with SMTP id ji6-20020a170907980600b0094f584708acmr11169771ejc.51.1686579278640; Mon, 12 Jun 2023 07:14:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686579278; cv=none; d=google.com; s=arc-20160816; b=ODJh2VZnnzyxDf/h+mcEc1Dbhpfj1I3ih/SwiFjJL6DXKX6SAD5UoYJ2j4oeaNse11 /hEWoHbKMsCeFwOdKx0SQhjHwSsFemU9AVX5Cjxn8lsGd96s4YedI2pf4LZCD9GQgBPx 6mJNLLHe/dNG/wDz73jndpe3feSjbeyXmxTaKQ6tV5W+/7B+0ML6KhGZ2MsRJiM2pVrD D07HoodmpQTmthZFPt+ClLqLrBN6Tmgw9jcXwEekQGPGWgUbEWs1C9QsNmkplQaoendI Iqp7nZE7yj3Ow617Gy8X2jy3Xzty+UQfjZafEJ56ql+uPiYSyGi12SrFjG8Byaylqa/j iCCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject:dkim-signature; bh=57Vji+wrbpCFc065aUFw6WQHjb1rbDfgMZDk9rTGW1g=; b=VBG0l12bEzuB1qBSAB5OV9Cut0dJZfGTxBhrw+GusicLAUz2u9EDRCsiyZDxdJaoym NyU881TarEIgQ18PVBlw76ecuIGnVFd30Rnvquyh5LRpk7XGhLqqJv1EqfA8Y+r5swGp DWF+CupDjD1xBwY32jZn6wcM8/khEtB37A5UM4H8DS6zhVu/l8Wt87KjLD+Xz9cONxr2 kZbKb7HTrJSSkAE2dJPbE6h5JrhxJkNOyK3LWI/ZD1Ojl07vJFjo+Og6qsXv9XeuIMA/ augCbi+UF0xMSIQlNyktA77bv+OEIFsNePqKAzANZe+sapcIGmdhnZc1YX+haeA6vQko ysvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ul25cIl4; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j8-20020a170906254800b009659e77ef5dsi2545307ejb.481.2023.06.12.07.14.12; Mon, 12 Jun 2023 07:14:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ul25cIl4; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235611AbjFLON5 (ORCPT + 99 others); Mon, 12 Jun 2023 10:13:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237214AbjFLONz (ORCPT ); Mon, 12 Jun 2023 10:13:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D39A110E5 for ; Mon, 12 Jun 2023 07:13:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 716DE6270D for ; Mon, 12 Jun 2023 14:13:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B204DC433D2; Mon, 12 Jun 2023 14:13:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686579232; bh=qWMIzXwYBmGtfY8D74b1zZ4DZ089LMbGuHNchZCMjzM=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=ul25cIl4ULi34gSrf9mVUQouFlVH3okNRgimxtlIF6Y3crPiNrT8iYmFc6DA80IfS LgujarCh37hIY+Hx0oEiCnneK+cMO8wGrWTOxSMkSoYyYArtsXrsqbmV+EO2QUlHfX 86EXXz8f9SK9IgLMbXswvpfGoddu5X/x48q9QW5tKkDThctu3cH4gPyTf7RabiWUUp vj5us7S1EBKpNE6MQrdTks6DxU/G+FFOU8qwF0JNt9aoQZv/BRvpkz1kmWIIHZS1Jv 9pnOuzFiFnUNx77FXSb5esij9ZcIdtCc0HQmm+2WAlTp640MckjNaOvRac6L3kFqVA 0VoRnuUIj6tAw== Subject: [PATCH v1 4/7] svcrdma: trace cc_release calls From: Chuck Lever To: linux-nfs@vger.kernel.org Cc: Chuck Lever Date: Mon, 12 Jun 2023 10:13:51 -0400 Message-ID: <168657923186.5674.5040517820045674722.stgit@manet.1015granger.net> In-Reply-To: <168657912781.5674.12501431304770900992.stgit@manet.1015granger.net> References: <168657912781.5674.12501431304770900992.stgit@manet.1015granger.net> User-Agent: StGit/1.5 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Chuck Lever This event brackets the svcrdma_post_* trace points. If this trace event is enabled but does not appear as expected, that indicates a chunk_ctxt leak. Signed-off-by: Chuck Lever --- include/trace/events/rpcrdma.h | 8 ++++++++ net/sunrpc/xprtrdma/svc_rdma_rw.c | 2 ++ 2 files changed, 10 insertions(+) diff --git a/include/trace/events/rpcrdma.h b/include/trace/events/rpcrdma.h index 8f461e04e5f0..f8069ef2ee0f 100644 --- a/include/trace/events/rpcrdma.h +++ b/include/trace/events/rpcrdma.h @@ -2112,6 +2112,14 @@ DEFINE_POST_CHUNK_EVENT(read); DEFINE_POST_CHUNK_EVENT(write); DEFINE_POST_CHUNK_EVENT(reply); +DEFINE_EVENT(svcrdma_post_chunk_class, svcrdma_cc_release, + TP_PROTO( + const struct rpc_rdma_cid *cid, + int sqecount + ), + TP_ARGS(cid, sqecount) +); + TRACE_EVENT(svcrdma_wc_read, TP_PROTO( const struct ib_wc *wc, diff --git a/net/sunrpc/xprtrdma/svc_rdma_rw.c b/net/sunrpc/xprtrdma/svc_rdma_rw.c index 59ea87b5f458..9836406cc41e 100644 --- a/net/sunrpc/xprtrdma/svc_rdma_rw.c +++ b/net/sunrpc/xprtrdma/svc_rdma_rw.c @@ -191,6 +191,8 @@ static void svc_rdma_cc_release(struct svc_rdma_chunk_ctxt *cc, struct svc_rdma_rw_ctxt *ctxt; LLIST_HEAD(free); + trace_svcrdma_cc_release(&cc->cc_cid, cc->cc_sqecount); + first = last = NULL; while ((ctxt = svc_rdma_next_ctxt(&cc->cc_rwctxts)) != NULL) { list_del(&ctxt->rw_list);