Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <df8e11df-79b6-28a7-05d4-818dbcd5326b@linaro.org>
Date:   Mon, 12 Jun 2023 22:04:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH v3 3/3] NFSv4.2: Rework scratch handling for READ_PLUS
 (again)
To:     Anna Schumaker <anna@kernel.org>
Cc:     linux-nfs@vger.kernel.org, trond.myklebust@hammerspace.com
References: <20230609200013.849882-1-anna@kernel.org>
 <20230609200013.849882-3-anna@kernel.org>
 <c6e8ecea-d85c-dc12-34c0-6070f104d61b@linaro.org>
 <CAFX2Jf=dnTL2_Sv4-uw1uJm0_JCjOCOS2vbQ4kJjU9-3fYcXZg@mail.gmail.com>
Content-Language: en-US
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <CAFX2Jf=dnTL2_Sv4-uw1uJm0_JCjOCOS2vbQ4kJjU9-3fYcXZg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/06/2023 21:57, Anna Schumaker wrote:

>>> I fix this by moving scratch handling into the pageio read code. I
>>> provide a function to allocate scratch space for decoding read replies,
>>> and free the scratch buffer when the nfs_pgio_header is freed.
>>>
>>> Krzysztof Kozlowski hit a bug a while ago with similar symptoms,
>>> and I'm hopeful that this patch fixes his issue.
>>
>> Unfortunately it does not help. Same NULL ptr, next-20230609 with this
>> patchset:
> 
> That's unfortunate. I was really hoping between patch #2 and #3 that
> it would finally address the issue. I think you said your client is
> ARM v7, that's 32-bit right? I'll try to do some 32-bit testing to see

Yes, it's 32-bit ARM.

> if that uncovers anything on my end. In the meantime, I'll try to
> update the debugging printk() patch based on what I learned while
> working patch #3 last week. I'll try to get that to you in the next
> day or two.
> 


Best regards,
Krzysztof