Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Trond Myklebust <trondmy@hammerspace.com>
To:     "cymi20@fudan.edu.cn" <cymi20@fudan.edu.cn>
CC:     "anna@kernel.org" <anna@kernel.org>,
        "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nfsroot: Fix missing check for return value of strsep()
Thread-Topic: [PATCH] nfsroot: Fix missing check for return value of strsep()
Thread-Index: AQHZnszcoTCvxuIl00GBkTwUcpZWGa+KacIA
Date:   Wed, 14 Jun 2023 15:19:59 +0000
Message-ID: <83fd43a8acec2d07ee7bd49afc830988354784ed.camel@hammerspace.com>
References: <20230614143058.112300-1-cymi20@fudan.edu.cn>
In-Reply-To: <20230614143058.112300-1-cymi20@fudan.edu.cn>
Accept-Language: en-US, en-GB
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SEt5SHJBSXBvOTQrSDlPUGc0Q01QYTdablI2ODh4Z0dnU1ZEdnRjVFVsMzZh?=
 =?utf-8?B?SFpaMXE0RVFqNERUd1Q3bGJYcUREMEY4aDFlaFNpOVJWeW8xUi8yL2NsblJL?=
 =?utf-8?B?V2tCV2FZYWpMbHNYSU9jMUJkbWZBMVZhN2ZOODFCd3dlamU1Q3JPNGE2aFUz?=
 =?utf-8?B?L3pwNUc2dG1HdzYrU1I5eFVTUUhOM3VuVURZMnFnR21sNzZhRXdYUWJKcmhR?=
 =?utf-8?B?QmJLNVVCU3krSTlrTnZvRGhGU0dsc3RLaDZQUkdiQnZid2lNWi9sOXRhR0RF?=
 =?utf-8?B?SkwrczBRR3Rua05jVDlKZUF1UkpDa1dhQWNtSnB4bXB3MnhVRHJiQVVVelhk?=
 =?utf-8?B?M3YyZCtMRTQ0QTk4SFdUTlZaSkxOWVNrTDh3UjFSZVhKR01VdGVVNXo0WXE1?=
 =?utf-8?B?VFVXUnJQd1lMR3dNRTdqOVVYK3drM29mSytRRnJ6VzBKQnBUUUZ3amkxeGtv?=
 =?utf-8?B?UmNXbnBHZGw3U0xVRlhiOXFpN21FMUFlTXJOcmxESXM0V0FjUzBVc0U4R2dy?=
 =?utf-8?B?WUhLS2VzZ2VGVGdBVFRYNzNxK0xsd2hrTlVaM2I1Y05uTW1PYnlhWmozNnM4?=
 =?utf-8?B?dGU3dVo3N1o2MTQrTEIvdCtVUmQwQjFGQjcvekc4VU5nMWFqRFpaeUUrSUgy?=
 =?utf-8?B?TDdreEo1bGRoNG04cDRneUtYY1VKeXlEdHU4TUNvTkI3M09iU0pJV29kWDRZ?=
 =?utf-8?B?ZENtNnRpR0FjMmI5ZWRhY1lGVTFsK2V2WUVpYmdkMDFwRHU1K3haUmgvK0o0?=
 =?utf-8?B?SndQdkFrWWdjRnlaMHNWa0xmZkdZd1prSDNsRHNoY2txUzU1d3BHZ2JSM3hl?=
 =?utf-8?B?TklqSGZ4L0U2emdXcUJBNVVFbG04RXQ1a0NIRWQ2bDRWbE1jNEZjNStiWmVn?=
 =?utf-8?B?MDNKZ3FYa3JnWHRoVldWUDhSV2NzcVd4SUpuOXBYS0F5bk10M1hUVW5UaEU1?=
 =?utf-8?B?NHV0NzRIY05yNVRFdlBQRnE4RWNJa05iTTJXVEFEN1BuQVFRNk41Z3RIZEpY?=
 =?utf-8?B?YjRIYmlSYWo4bGZnOS85UGc2cFdDdGMvdERqRXVQSTZTb3dwUGFxbnBiK25k?=
 =?utf-8?B?ZkZPOVlWWDhNV1k3Ly9kQlVKaEF3RXBQeFlpbjRtaXNGS1hKc3pTLyszbEQy?=
 =?utf-8?B?WGFISVFjKzdHeSt6VGI4dU9ERDFtZ0g4UDdSVk1qb0ZlNVYyVWtnRGNWVmV0?=
 =?utf-8?B?Sm5JdHpvNUdNd09RWXFtYkJaWVJ4OUZTTDlMcnB1SVkwTVdkKzQ5N2tnMVdQ?=
 =?utf-8?B?WmFyYThHeXFUTjhtbHk3V0pKL3F2REt4VllFNElDRTRta25Ka3E5SXQzNXlq?=
 =?utf-8?B?b3hmY2JlVkk1K0o5cTZRRmd1Vm84QlFyalQvSUZZRWRldGU5ZTZZbExkMjhF?=
 =?utf-8?B?dVFFQVFSYmdqSHV6QVNnSmRDUW1QL1FXN1dhQlhWUGN3U0Z0UVFFaDhncU45?=
 =?utf-8?B?L1VRMG13QjcyWmEzU3lJRE5ucERTcVNUZDFLK1dRUE1WNUpTVjRKL3gyNHNl?=
 =?utf-8?B?b0ZnMXdYLzRoS09PM2oyQW5aVEtrcGF3T2o0YzkreXl1eVN3U2FSUEliWXhI?=
 =?utf-8?B?YTdleGpWQXIwaFJJUzlIZlZIeVVYYkQxemc4L1VHNXJqeTBhaGxPdEVpWFR6?=
 =?utf-8?B?R2Q4WjZORFkrZTd3aG5DUlhGd3dJSlVkUWRDaUJ2SGF5VjBhRVVqdWljMCtR?=
 =?utf-8?B?dmpXc0xXUnJHeFdGd3lvbUUxUWluRXFPSzRtVjFWT0tZdHltRFg5aGVBNlgy?=
 =?utf-8?B?NUVWKzJZdjFYVWRVRjllSWhIU3RkTldOOHRIUEJQNmljaFprcTZHZmh5dWZ5?=
 =?utf-8?B?OGhoZS81ZW4ybE9FMmU4MHBCazROR1FHZ2J0ZDMwRGJwVHBPTXlyb0IwYWt5?=
 =?utf-8?B?RHpwVlE1dUFBekV4cHdtUkZqd1hnK0cwcnpHTGVobkZ0T09PZ1VlRHI1V0pP?=
 =?utf-8?B?am1NTHU5VW11dW9qZ1l0WVdVT1Q0TDM4YnR2VDA3TUtnNW1Rb2JhYmJUcmlL?=
 =?utf-8?B?amRJTzNqb1h1WW03bUk5VDNOblRTSytKSCtlLzhhWThLYkJsb2JTZUw0YVAy?=
 =?utf-8?B?K1FoZVk4d3hzR1Rva1MwSWZ3ZXlvTUpHNWxxYVRubmN2TlgwWkEvS2hoNnlL?=
 =?utf-8?B?eGdUWHJkTWhQdE1DVTlOQ0p3emRmT1haVFpOQTd5WHlZVENlOUwwU0ZtamZB?=
 =?utf-8?B?L2c9PQ==?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <16F935F7A5CF264482C8B4D4E8B3FDC9@namprd13.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: hammerspace.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH0PR13MB5084.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ad24b36-488d-4557-137c-08db6cead16f
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jun 2023 15:19:59.4750
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0d4fed5c-3a70-46fe-9430-ece41741f59e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: aR8DT8eYhzWOIXVne7xJnRYVq7oUpL/GHAA05NIbtJNZ43asDztUcK8PCdpPQ2w4A78BVlJdDCfbLoPb8ne9SQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB3987
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

T24gV2VkLCAyMDIzLTA2LTE0IGF0IDA3OjMwIC0wNzAwLCBDaGVueXVhbiBNaSB3cm90ZToNCj4g
W1lvdSBkb24ndCBvZnRlbiBnZXQgZW1haWwgZnJvbSBjeW1pMjBAZnVkYW4uZWR1LmNuLiBMZWFy
biB3aHkgdGhpcw0KPiBpcyBpbXBvcnRhbnQgYXQgaHR0cHM6Ly9ha2EubXMvTGVhcm5BYm91dFNl
bmRlcklkZW50aWZpY2F0aW9uwqBdDQo+IA0KPiBUaGUgc3Ryc2VwKCkgZnVuY3Rpb24gaW4gcm9v
dF9uZnNfcGFyc2Vfb3B0aW9ucygpIG1heSByZXR1cm4gTlVMTA0KPiBpZiBhcmd1bWVudCAnaW5j
b21pbmcnIGlzIE5VTEwuIFNpbmNlICdpbmNvbWluZycgaGFzIE51bGwgY2hlY2sgaW4NCj4gdGhp
cyBmdW5jdGlvbiwgaXQgaXMgYWxzbyBuZWVkIHRvIGFkZCBOdWxsIGNoZWNrIGZvciByZXR1cm4g
dmFsdWUNCj4gwqBvZiBzdHJzZXAoKS4NCj4gDQo+IEZvdW5kIGJ5IG91ciBzdGF0aWMgYW5hbHlz
aXMgdG9vbC4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IENoZW55dWFuIE1pIDxjeW1pMjBAZnVkYW4u
ZWR1LmNuPg0KPiAtLS0NCj4gwqBmcy9uZnMvbmZzcm9vdC5jIHwgMiArLQ0KPiDCoDEgZmlsZSBj
aGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQ0KPiANCj4gZGlmZiAtLWdpdCBh
L2ZzL25mcy9uZnNyb290LmMgYi9mcy9uZnMvbmZzcm9vdC5jDQo+IGluZGV4IDYyMDMyOWI3ZTZh
ZS4uNTVjNTk0ZGVkZTlmIDEwMDY0NA0KPiAtLS0gYS9mcy9uZnMvbmZzcm9vdC5jDQo+ICsrKyBi
L2ZzL25mcy9uZnNyb290LmMNCj4gQEAgLTE5OCw3ICsxOTgsNyBAQCBzdGF0aWMgaW50IF9faW5p
dCByb290X25mc19wYXJzZV9vcHRpb25zKGNoYXINCj4gKmluY29taW5nLCBjaGFyICpleHBwYXRo
LA0KPiDCoMKgwqDCoMKgwqDCoMKgICogU2V0IHRoZSBORlMgcmVtb3RlIHBhdGgNCj4gwqDCoMKg
wqDCoMKgwqDCoCAqLw0KPiDCoMKgwqDCoMKgwqDCoCBwID0gc3Ryc2VwKCZpbmNvbWluZywgIiwi
KTsNCj4gLcKgwqDCoMKgwqDCoCBpZiAoKnAgIT0gJ1wwJyAmJiBzdHJjbXAocCwgImRlZmF1bHQi
KSAhPSAwKQ0KPiArwqDCoMKgwqDCoMKgIGlmIChwICE9IE5VTEwgJiYgKnAgIT0gJ1wwJyAmJiBz
dHJjbXAocCwgImRlZmF1bHQiKSAhPSAwKQ0KPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqAgaWYgKHJvb3RfbmZzX2NvcHkoZXhwcGF0aCwgcCwgZXhwcGF0aGxlbikpDQo+IMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIC0xOw0KPiANCg0K
SHVoPyByb290X25mc19wYXJzZV9vcHRpb25zKCkgaXMgY2FsbGVkIGZyb20gZXhhY3RseSB0d28g
Y2FsbHNpdGVzLCBhbmQNCmluIGJvdGggY2FzZXMgJ2luY29taW5nJyBpcyBndWFyYW50ZWVkIHRv
IGJlIG5vbi1OVUxMLg0KDQpOQUNLZWQNCi0tIA0KVHJvbmQgTXlrbGVidXN0DQpMaW51eCBORlMg
Y2xpZW50IG1haW50YWluZXIsIEhhbW1lcnNwYWNlDQp0cm9uZC5teWtsZWJ1c3RAaGFtbWVyc3Bh
Y2UuY29tDQoNCg0K