Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Benjamin Coddington <bcodding@redhat.com>
To:     Chenyuan Mi <cymi20@fudan.edu.cn>
Cc:     trond.myklebust@hammerspace.com, anna@kernel.org,
        linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfsroot: Fix missing check for return value of strsep()
Date:   Wed, 14 Jun 2023 11:23:19 -0400
Message-ID: <43531410-F066-4DE9-9FA7-990D2E5D878B@redhat.com>
In-Reply-To: <20230614143058.112300-1-cymi20@fudan.edu.cn>
References: <20230614143058.112300-1-cymi20@fudan.edu.cn>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On 14 Jun 2023, at 10:30, Chenyuan Mi wrote:

> The strsep() function in root_nfs_parse_options() may return NULL
> if argument 'incoming' is NULL. Since 'incoming' has Null check in
> this function, it is also need to add Null check for return value
>  of strsep().

Incoming is checked to be non-NULL *before* sending it to strsep() here.

> Found by our static analysis tool.

The tool must be noticing that it is checked for NULL *after* strsep(),
which wouldn't matter to strsep() at all.

Ben