Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1082771rwd; Thu, 15 Jun 2023 06:13:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ465V2Al2+aKDtprTl4FvFtynBmNfhjSCU74dP6LA8v3hbVJLLrG3dAK7oX+bmVCBVSVtVv X-Received: by 2002:a17:902:e809:b0:1b0:5e97:ee2c with SMTP id u9-20020a170902e80900b001b05e97ee2cmr17192565plg.11.1686834792335; Thu, 15 Jun 2023 06:13:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686834792; cv=none; d=google.com; s=arc-20160816; b=s6RnqxT7suRVyc+N3/RbVzTgsYC0a4FaqTmGaWssmD69vI739czkCZGG4E+Wf+wu82 maDARYvWbJ4TERp2umSVjoEAByVrWsVm4+KQoa+96FfMZGbn425bI/cjZdq0wmJ6yzpB yjWATnZUhsFWb2ddVHqeamVPTrpYRjRcz4p8lVFqW17QtZcd2f/KebhBkLx+wy/j+U1E BP6twsu+NGvmjwYZ9A8tE6tzNWfImto6PVtehdU7Co4hEnQOZNIlHEUBQzH0L8lQXqb1 g70AVqJ7sLwfyZXBznge4JCz/dr2ceYcFCE+YR4C3Vn3bSQOXDJIK7QBYDSc0fOJYMMJ Bbtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=LzzubgBVt/J0nhYq2hKWgLyD/ISUfZBJNfYWWUP1FQE=; b=bv3ST+puUftMBntgCLbEPbYTRhkbbo6mWMFWHIJ4BpKvr1JENAtEYr0/R9HeKAmq2X Mn4jCuKF9NWashBC2TfbXbnOkGDvk5Kv0eKefuwyD0/kqDSPWBdr4O1wEMIe103WkkD9 /oQ2pm0zsTlUGiqo/otHWlRQLTfZD1eehmxd2jNm1lzk3f0rIvtLGqmWQJn4pj+d8/le 3iiMkKTC1MoTAg4btWuJ6zviKhRLT8nA0v3siz13X9R/yUkdc/zi5gX5B7TBUPrtujya OazFh2aN51JDAu/xerEMvJa/TRb0+4K4OSlkPpdZCeNK8Q2ZkYC9ow3TVPrdozVDYZQL 7h4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=NVkPW3sS; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o9-20020a170902d4c900b001b3c9bf5360si8380938plg.251.2023.06.15.06.12.49; Thu, 15 Jun 2023 06:13:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=NVkPW3sS; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237810AbjFONB1 (ORCPT + 99 others); Thu, 15 Jun 2023 09:01:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343632AbjFONB0 (ORCPT ); Thu, 15 Jun 2023 09:01:26 -0400 Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CFD02704; Thu, 15 Jun 2023 06:01:22 -0700 (PDT) Received: by mail-qt1-x832.google.com with SMTP id d75a77b69052e-3f86a7f3a65so29435351cf.0; Thu, 15 Jun 2023 06:01:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686834082; x=1689426082; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LzzubgBVt/J0nhYq2hKWgLyD/ISUfZBJNfYWWUP1FQE=; b=NVkPW3sSJz8Ti0OLHUwsQMACcGifVQZarMa9af3J9v7HIiAdbCMuVVow5wmCtXlltO MW9V93ISS7DGuX0zeRDHvXLB+RrMDvnq1nIBIGKEA3CR8vDqwE4m9UFzGOMb25HnmLWF xHXjGUqFgfzH6OKyyNbsMduwcpodYZJse5Bon6Ypg6UB2rZLWlOkB6j+MLevlZFD/67K PmK0k6Lh1NCThLxwsg93FCoju/8JN3DPGWLjzfnvSCag9q1tMxzgDI2V98RTME/KI+rG K6WEUD1A9z4YdgkIqntvhwx7E9LCOp/tDgTROuBi/jZegsbsXBO0GO7clHuIrLsrNEHd NLCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686834082; x=1689426082; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LzzubgBVt/J0nhYq2hKWgLyD/ISUfZBJNfYWWUP1FQE=; b=k7iEuG9q0KqBBkRwkaB0a0EOQhlTuxN26/q4pS+CpTrFbuI0JLTybSLJvGOBdOaMDr uWhH+19UTigT/gOmYGvOYNB0fG5W1+llILLPjym4sFNwbkeTb+rWDn6f3ncE+wl+17BY eW05qzFZhcL2pqdO8HE2GtpURPGRWktDMCPGAh6PuSPByH+FCYO3y/Uu4g6ik3fFk+xB PCnzKcLixGIMSsypZcfCEoYtPLT+IrDeztXpQSC72hPjrhhaYJmlogdJ9sbaSwsJ0sYN 5vZWvDi/hFchdd2DMUd/y7aBNcNBWQqCrg1ewkLMtMki2Duy4PEZVWIHPN+j/go6Bbqc 4RSw== X-Gm-Message-State: AC+VfDzXOAI9iYWq4w83+WJyEhVeeTDDKI+Av4nUz7z/RDQ7xa51sAGg 9jcURn7go7PZyyq26dYXcBSZGt8/2D6ood5J/aY= X-Received: by 2002:a05:622a:54b:b0:3ed:86f6:6ecf with SMTP id m11-20020a05622a054b00b003ed86f66ecfmr6189795qtx.46.1686834081704; Thu, 15 Jun 2023 06:01:21 -0700 (PDT) MIME-Version: 1.0 References: <2C5E9725-F152-4D2E-882E-CF92A35481BF@hammerspace.com> <7ba38377-7992-7f0f-d905-cceb42510f39@linaro.org> <51430925-8046-7066-84ed-2ff0db835347@linaro.org> <2add1769-1458-b185-bc78-6d573f61b6fc@linaro.org> <32530c36-91d0-d351-0689-aed6a0975a4b@linaro.org> <2f285607-cbf9-6abc-f436-edb6e9a3938b@linaro.org> <4fe39d77-eb7c-a578-aefa-45b76e2247c2@linaro.org> <86d8e252-975f-5d48-4567-0911d5ef9a44@linaro.org> In-Reply-To: From: Anna Schumaker Date: Thu, 15 Jun 2023 09:01:05 -0400 Message-ID: Subject: Re: Regression: NULL pointer dereference after NFS_V4_2_READ_PLUS (commit 7fd461c47) To: Krzysztof Kozlowski Cc: Trond Myklebust , Anna Schumaker , linux-nfs , Linux Kernel Mailing List , "regressions@lists.linux.dev" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Thu, Jun 15, 2023 at 4:55=E2=80=AFAM Krzysztof Kozlowski wrote: > > On 15/06/2023 10:52, Krzysztof Kozlowski wrote: > > On 14/06/2023 22:55, Anna Schumaker wrote: > >>>>> Still null ptr (built on 420b2d4 with your patch): > >>>> > >>>> We're through the merge window and at rc1 now, so I can spend more > >>>> time scratching my head over your bug again. We've come up with a > >>>> patch (attached) that adds a bunch of printks to show us what the > >>>> kernel thinks is going on. Do you mind trying it out and letting us > >>>> know what gets printed out? You'll need to make sure > >>>> CONFIG_NFS_V4_2_READ_PLUS is enabled when compiling the kernel. > >>> > >>> The patch does not apply. I tried: v6.4-rc1, v6.4-rc5, next-20230609. > >> > >> Can you try the attached patch on top of my 3-patch series from the > >> other day, and let me know what gets printed out? It adds a bunch of > >> printk()s at strategic points to print out what is going on with the > >> xdr scratch buffer since it's suddenly a bad memory address after > >> working for a bit on your machine. > >> > > > > Here you have entire log - attached (113 kB, I hope goes past mailing > > lists/spam filters). > > As expected this bounced from the mailing lists, but I hope you got it. > If not, let me know. I did still receive it. Thanks! Anna > > Best regards, > Krzysztof >