Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <f591b13c-4600-e2a4-8efa-aac6ad828dd1@linaro.org>
 <2C5E9725-F152-4D2E-882E-CF92A35481BF@hammerspace.com> <7ba38377-7992-7f0f-d905-cceb42510f39@linaro.org>
 <51430925-8046-7066-84ed-2ff0db835347@linaro.org> <CAFX2Jf=5X3zyZEWQmD6Rg9jQAD7ccDbae5LQCwrAyPCVVoFumg@mail.gmail.com>
 <2add1769-1458-b185-bc78-6d573f61b6fc@linaro.org> <CAFX2JfnKy7juGQaDTzqosN9SF-zd+XrhSL9uh_Xg0GpJGDux-A@mail.gmail.com>
 <32530c36-91d0-d351-0689-aed6a0975a4b@linaro.org> <2f285607-cbf9-6abc-f436-edb6e9a3938b@linaro.org>
 <CAFX2Jfmz7QqZBEdzbPUhPs0yctnXVaVF68tX1c57YX=6ki=0TA@mail.gmail.com>
 <4fe39d77-eb7c-a578-aefa-45b76e2247c2@linaro.org> <CAFX2JfmdRMsHPTySiw4vm7BwJfRZj3s0V3_v7NJ+XwMxBBSo9A@mail.gmail.com>
 <a3683dd3-3f30-bb4c-539d-d1519de6e5bf@linaro.org> <CAFX2JfnS9GVc4NaxKhr9E4y10NNv6SPgcv1yoeHTfEw5NvZgMg@mail.gmail.com>
 <86d8e252-975f-5d48-4567-0911d5ef9a44@linaro.org> <CAFX2Jfn_DSs38WQYsRs2ifLi5w+T3BhZfSU2W80T6dK48_Bb5g@mail.gmail.com>
 <e8d31e48-df6a-fde4-4c6b-c4ccf1664ded@linaro.org> <c8d454b0-d355-f599-f720-b7e64374fb56@linaro.org>
 <CAFX2JfmvMZ7DzD9znWeOHXywgPbUKDS1irMjUerEuborjRBpcg@mail.gmail.com>
In-Reply-To: <CAFX2JfmvMZ7DzD9znWeOHXywgPbUKDS1irMjUerEuborjRBpcg@mail.gmail.com>
From:   Anna Schumaker <schumaker.anna@gmail.com>
Date:   Thu, 15 Jun 2023 13:04:29 -0400
Message-ID: <CAFX2JfnhOz+HiOd4vBwBK+5d19Kb8wfBNQhxRZHQoP8S2qiwFw@mail.gmail.com>
Subject: Re: Regression: NULL pointer dereference after NFS_V4_2_READ_PLUS
 (commit 7fd461c47)
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Trond Myklebust <trondmy@hammerspace.com>,
        Anna Schumaker <Anna.Schumaker@netapp.com>,
        linux-nfs <linux-nfs@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "regressions@lists.linux.dev" <regressions@lists.linux.dev>
Content-Type: multipart/mixed; boundary="000000000000b6d55305fe2e10cf"
Precedence: bulk

--000000000000b6d55305fe2e10cf
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 15, 2023 at 9:01=E2=80=AFAM Anna Schumaker <schumaker.anna@gmai=
l.com> wrote:
>
> On Thu, Jun 15, 2023 at 4:55=E2=80=AFAM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
> >
> > On 15/06/2023 10:52, Krzysztof Kozlowski wrote:
> > > On 14/06/2023 22:55, Anna Schumaker wrote:
> > >>>>> Still null ptr (built on 420b2d4 with your patch):
> > >>>>
> > >>>> We're through the merge window and at rc1 now, so I can spend more
> > >>>> time scratching my head over your bug again. We've come up with a
> > >>>> patch (attached) that adds a bunch of printks to show us what the
> > >>>> kernel thinks is going on. Do you mind trying it out and letting u=
s
> > >>>> know what gets printed out? You'll need to make sure
> > >>>> CONFIG_NFS_V4_2_READ_PLUS is enabled when compiling the kernel.
> > >>>
> > >>> The patch does not apply. I tried: v6.4-rc1, v6.4-rc5, next-2023060=
9.
> > >>
> > >> Can you try the attached patch on top of my 3-patch series from the
> > >> other day, and let me know what gets printed out? It adds a bunch of
> > >> printk()s at strategic points to print out what is going on with the
> > >> xdr scratch buffer since it's suddenly a bad memory address after
> > >> working for a bit on your machine.
> > >>
> > >
> > > Here you have entire log - attached (113 kB, I hope goes past mailing
> > > lists/spam filters).
> >
> > As expected this bounced from the mailing lists, but I hope you got it.
> > If not, let me know.
>
> I did still receive it. Thanks!

Can you swap out yesterday's patch with this patch? I've adjusted what
gets printed out, and added printk()s to xdr_copy_to_scratch().  I'm
starting to think that the xdr scratch buffer is fine, and that it's
the other pointer passed to memcpy() in that function that's the
problem, and the output from this patch will confirm for me.

Thanks,
Anna

>
> Anna
> >
> > Best regards,
> > Krzysztof
> >

--000000000000b6d55305fe2e10cf
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="v2-0001-NFS-Add-debugging-printk-s-to-trace-the-xdr-scrat.patch"
Content-Disposition: attachment; 
	filename="v2-0001-NFS-Add-debugging-printk-s-to-trace-the-xdr-scrat.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lixe2d0k0>
X-Attachment-Id: f_lixe2d0k0

RnJvbSBkNDFmNDMwNDAwN2QyOTU0Zjg1MTNmM2MzZDg0NTAyOGZlZmU3OWVjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbm5hIFNjaHVtYWtlciA8QW5uYS5TY2h1bWFrZXJATmV0YXBw
LmNvbT4KRGF0ZTogV2VkLCAxNCBKdW4gMjAyMyAxNjo0OTozNyAtMDQwMApTdWJqZWN0OiBbUkZD
IHYyXSBORlM6IEFkZCBkZWJ1Z2dpbmcgcHJpbnRrKClzIHRvIHRyYWNlIHRoZSB4ZHItPnNjcmF0
Y2gKIGJ1ZmZlcgoKSSdtIHRyeWluZyB0byBmaWd1cmUgb3V0IGF0IHdoYXQgcG9pbnQgdGhlIHhk
ci0+c2NyYXRjaCBidWZmZXIgaXMKYWxsb2NhdGVkLCBmcmVlZCwgc2V0LCBhbmQgcmVzZXQgdG8g
ZmlndXJlIG91dCB3aHkgUkVBRF9QTFVTIHN1ZGRlbmx5CnRoaW5rcyBpdCdzIGEgTlVMTCBwb2lu
dGVyIHdpdGggbGVuZ3RoIDE2LgoKU2lnbmVkLW9mZi1ieTogQW5uYSBTY2h1bWFrZXIgPEFubmEu
U2NodW1ha2VyQE5ldGFwcC5jb20+Ci0tLQogZnMvbmZzL25mczQyeGRyLmMgICAgICAgICAgfCAy
ICsrCiBmcy9uZnMvcmVhZC5jICAgICAgICAgICAgICB8IDggKysrKysrKy0KIGluY2x1ZGUvbGlu
dXgvc3VucnBjL3hkci5oIHwgMSArCiBuZXQvc3VucnBjL3hkci5jICAgICAgICAgICB8IDQgKysr
KwogNCBmaWxlcyBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZm
IC0tZ2l0IGEvZnMvbmZzL25mczQyeGRyLmMgYi9mcy9uZnMvbmZzNDJ4ZHIuYwppbmRleCAyMGFh
NWU3NDY0OTcuLjZhNGVhZGUyNDAwYiAxMDA2NDQKLS0tIGEvZnMvbmZzL25mczQyeGRyLmMKKysr
IGIvZnMvbmZzL25mczQyeGRyLmMKQEAgLTEzNTEsNiArMTM1MSw4IEBAIHN0YXRpYyBpbnQgbmZz
NF94ZHJfZGVjX3JlYWRfcGx1cyhzdHJ1Y3QgcnBjX3Jxc3QgKnJxc3RwLAogCXN0cnVjdCBjb21w
b3VuZF9oZHIgaGRyOwogCWludCBzdGF0dXM7CiAKKwlwcmludGsoS0VSTl9JTkZPICIlcyhoZHI9
JXB4LCBzY3JhdGNoPSVweClcbiIsIF9fZnVuY19fLAorCQljb250YWluZXJfb2YocmVzLCBzdHJ1
Y3QgbmZzX3BnaW9faGVhZGVyLCByZXMpLCByZXMtPnNjcmF0Y2gpOwogCXhkcl9zZXRfc2NyYXRj
aF9idWZmZXIoeGRyLCByZXMtPnNjcmF0Y2gsIFJFQURfUExVU19TQ1JBVENIX1NJWkUpOwogCiAJ
c3RhdHVzID0gZGVjb2RlX2NvbXBvdW5kX2hkcih4ZHIsICZoZHIpOwpkaWZmIC0tZ2l0IGEvZnMv
bmZzL3JlYWQuYyBiL2ZzL25mcy9yZWFkLmMKaW5kZXggN2RjMjFhNDhlM2U3Li43YjkzMzE2YTUy
ZGUgMTAwNjQ0Ci0tLSBhL2ZzL25mcy9yZWFkLmMKKysrIGIvZnMvbmZzL3JlYWQuYwpAQCAtNDcs
OCArNDcsMTEgQEAgc3RhdGljIHN0cnVjdCBuZnNfcGdpb19oZWFkZXIgKm5mc19yZWFkaGRyX2Fs
bG9jKHZvaWQpCiAKIHN0YXRpYyB2b2lkIG5mc19yZWFkaGRyX2ZyZWUoc3RydWN0IG5mc19wZ2lv
X2hlYWRlciAqcmhkcikKIHsKLQlpZiAocmhkci0+cmVzLnNjcmF0Y2ggIT0gTlVMTCkKKwlpZiAo
cmhkci0+cmVzLnNjcmF0Y2ggIT0gTlVMTCkgeworCQlwcmludGsoS0VSTl9JTkZPICIlcyhoZHI9
JXB4LCBzY3JhdGNoPSVweClcbiIsCisJCQlfX2Z1bmNfXywgcmhkciwgcmhkci0+cmVzLnNjcmF0
Y2gpOwogCQlrZnJlZShyaGRyLT5yZXMuc2NyYXRjaCk7CisJfQogCWttZW1fY2FjaGVfZnJlZShu
ZnNfcmRhdGFfY2FjaGVwLCByaGRyKTsKIH0KIApAQCAtMTE0LDYgKzExNyw5IEBAIGJvb2wgbmZz
X3JlYWRfYWxsb2Nfc2NyYXRjaChzdHJ1Y3QgbmZzX3BnaW9faGVhZGVyICpoZHIsIHNpemVfdCBz
aXplKQogewogCVdBUk5fT04oaGRyLT5yZXMuc2NyYXRjaCAhPSBOVUxMKTsKIAloZHItPnJlcy5z
Y3JhdGNoID0ga21hbGxvYyhzaXplLCBHRlBfS0VSTkVMKTsKKwlwcmludGsoS0VSTl9JTkZPICJc
biIpOworCXByaW50ayhLRVJOX0lORk8gIiVzKGhkcj0lcHgsIHNpemU9JXpkKSA9ICVweFxuIiwK
KwkJX19mdW5jX18sIGhkciwgc2l6ZSwgaGRyLT5yZXMuc2NyYXRjaCk7CiAJcmV0dXJuIGhkci0+
cmVzLnNjcmF0Y2ggIT0gTlVMTDsKIH0KIEVYUE9SVF9TWU1CT0xfR1BMKG5mc19yZWFkX2FsbG9j
X3NjcmF0Y2gpOwpkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9zdW5ycGMveGRyLmggYi9pbmNs
dWRlL2xpbnV4L3N1bnJwYy94ZHIuaAppbmRleCBkOTE3NjE4YTMwNTguLjFjOWE1NGU5ZWZhYyAx
MDA2NDQKLS0tIGEvaW5jbHVkZS9saW51eC9zdW5ycGMveGRyLmgKKysrIGIvaW5jbHVkZS9saW51
eC9zdW5ycGMveGRyLmgKQEAgLTI4Niw2ICsyODYsNyBAQCBleHRlcm4gdW5zaWduZWQgaW50IHhk
cl9zdHJlYW1femVybyhzdHJ1Y3QgeGRyX3N0cmVhbSAqeGRyLCB1bnNpZ25lZCBpbnQgb2Zmc2V0
LAogc3RhdGljIGlubGluZSB2b2lkCiB4ZHJfc2V0X3NjcmF0Y2hfYnVmZmVyKHN0cnVjdCB4ZHJf
c3RyZWFtICp4ZHIsIHZvaWQgKmJ1Ziwgc2l6ZV90IGJ1ZmxlbikKIHsKKwlXQVJOX09OKGJ1ZiAh
PSBOVUxMICYmIHhkci0+c2NyYXRjaC5pb3ZfYmFzZSAhPSBOVUxMKTsKIAl4ZHItPnNjcmF0Y2gu
aW92X2Jhc2UgPSBidWY7CiAJeGRyLT5zY3JhdGNoLmlvdl9sZW4gPSBidWZsZW47CiB9CmRpZmYg
LS1naXQgYS9uZXQvc3VucnBjL3hkci5jIGIvbmV0L3N1bnJwYy94ZHIuYwppbmRleCAzOTFiMzM2
ZDk3ZGUuLjM3YzhmN2U1MTlkZCAxMDA2NDQKLS0tIGEvbmV0L3N1bnJwYy94ZHIuYworKysgYi9u
ZXQvc3VucnBjL3hkci5jCkBAIC0xNDQwLDYgKzE0NDAsOCBAQCBzdGF0aWMgX19iZTMyICp4ZHJf
Y29weV90b19zY3JhdGNoKHN0cnVjdCB4ZHJfc3RyZWFtICp4ZHIsIHNpemVfdCBuYnl0ZXMpCiAJ
cCA9IF9feGRyX2lubGluZV9kZWNvZGUoeGRyLCBjcGxlbik7CiAJaWYgKHAgPT0gTlVMTCkKIAkJ
cmV0dXJuIE5VTEw7CisJcHJpbnRrKEtFUk5fSU5GTyAiICAgICVzKCVkKTogbWVtY3B5KCVweCwg
JXB4LCAlemQpXG4iLAorCQlfX2Z1bmNfXywgX19MSU5FX18sIGNwZGVzdCwgcCwgY3BsZW4pOwog
CW1lbWNweShjcGRlc3QsIHAsIGNwbGVuKTsKIAlpZiAoIXhkcl9zZXRfbmV4dF9idWZmZXIoeGRy
KSkKIAkJZ290byBvdXRfb3ZlcmZsb3c7CkBAIC0xNDQ4LDYgKzE0NTAsOCBAQCBzdGF0aWMgX19i
ZTMyICp4ZHJfY29weV90b19zY3JhdGNoKHN0cnVjdCB4ZHJfc3RyZWFtICp4ZHIsIHNpemVfdCBu
Ynl0ZXMpCiAJcCA9IF9feGRyX2lubGluZV9kZWNvZGUoeGRyLCBuYnl0ZXMpOwogCWlmIChwID09
IE5VTEwpCiAJCXJldHVybiBOVUxMOworCXByaW50ayhLRVJOX0lORk8gIiAgICAlcyglZCk6IG1l
bWNweSglcHgsICVweCwgJXpkKVxuIiwKKwkJX19mdW5jX18sIF9fTElORV9fLCBjcGRlc3QsIHAs
IG5ieXRlcyk7CiAJbWVtY3B5KGNwZGVzdCwgcCwgbmJ5dGVzKTsKIAlyZXR1cm4geGRyLT5zY3Jh
dGNoLmlvdl9iYXNlOwogb3V0X292ZXJmbG93OgotLSAKMi40MS4wCgo=
--000000000000b6d55305fe2e10cf--