Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Dmitry Antipov <dmantipov@yandex.ru>,
        Dan Carpenter <dan.carpenter@linaro.org>
CC:     Jeff Layton <jlayton@kernel.org>, Tom Rix <trix@redhat.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] sunrpc: fix clang-17 warning
Thread-Topic: [PATCH] sunrpc: fix clang-17 warning
Thread-Index: AQHZlJYb6vjx06AMBkGvsuYKh+iggq92BGoAgAAPooCAAATLgIAADT4AgAAHiwCAHd2fgA==
Date:   Tue, 20 Jun 2023 17:11:22 +0000
Message-ID: <41946493-D36A-454E-BCC0-B98EDC7F5BD7@oracle.com>
References: <20230601143332.255312-1-dmantipov@yandex.ru>
 <2D3D2D8E-4E7A-4B50-A1FF-486D7F6C26D4@oracle.com>
 <8ed6eb2b-fdfa-4fde-81f3-92e6b34bc509@kadam.mountain>
 <ed2f956d-632a-90e1-f2e9-91710be5f2de@yandex.ru>
 <c6c5c38b-f258-4dda-8227-5f672b37bc77@kadam.mountain>
 <9fda7891-925a-1d9c-7c70-a7b040211199@yandex.ru>
In-Reply-To: <9fda7891-925a-1d9c-7c70-a7b040211199@yandex.ru>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1wFkNZMFvLBp+tPgtiApq9rjlp9YXQwgKBJSOMkDUmil+I5vYQC/U2MMpJvO?=
 =?us-ascii?Q?geGlEfoLBGics3Rl10u5PlcHbJ3yuqU9BAzATncJuk5fYjZOHlD1sAm8wzWZ?=
 =?us-ascii?Q?DL6WZz8LqHTfo/Su1/EsqAmsqcwCcSJIBLMiGAqBvKOpktRNrEumaobrc9bS?=
 =?us-ascii?Q?HiNR1gkO7iHolkoBfXU2nrbEiHRjJ9rJ+VMBNyvX5bGzjIcYUs9rY/n+bTvj?=
 =?us-ascii?Q?Y31CyVCGWgxpPEva2iSZiUkfjW3MhnzXQ1C8g3wO/4kQMA+zUEGJ0p4wEaY+?=
 =?us-ascii?Q?yKUh4Yw8nmbtn/5vYyV9ruOoABRWGwTQSVlofpAZ/6hV2Mk8QyuMcvGd+in9?=
 =?us-ascii?Q?q21hQy8eEm8QtvbGTaTSPHzKNAYHv1YeU+hMALTovNL8Pf+GydiDC4boYess?=
 =?us-ascii?Q?nPM7EZXfVyWdTv0tf6d1ELlEWBk2vp+4l2n3aSBCARLEYnJ3j5tFTzJ4+WRv?=
 =?us-ascii?Q?SVpBwiYvO1Vl8qLk8YwFFbfejo9VAUdxvGvxJuCQ95h4L1LBickN6uioQl7L?=
 =?us-ascii?Q?l8utTMLhl4buDx6xCVUAsS6hxJUkQRjbWnXc/SbBhnMbcNqRDwNMQIXd3OXR?=
 =?us-ascii?Q?dKYl1I65Muqn0uXGhQruEcljiTTpFl4A2pg55vJl13T7KGBKauT5BW+cAnnD?=
 =?us-ascii?Q?/aNpQGTTNvfMroJR25dDA/ax2PvEX4fWHi4TAj2yr6pK6vXlDuxJ5SQwwWbA?=
 =?us-ascii?Q?zG/4NdDFh6X7WgRFAE7+L1GQ97ViRuzhMBbW5xH3My7nX8DU2ZZ4ouLG/nRm?=
 =?us-ascii?Q?6N8aiSGW7JoraNfTsrVLwUa14D5TZq0KJUeytcHqEJ+WdbURwsWUOj6hIbQP?=
 =?us-ascii?Q?Yt//omsw23516jx6QW6FSvZpkNSlwFXm3jKPq2wdjYQMGbd0WnpYcz9Gkq2u?=
 =?us-ascii?Q?//Ynu9ktknQrTVfxEwBqhfadmz8haP9QDFVsGxQfAV1FrJMRXasIWI+bkyQL?=
 =?us-ascii?Q?RnSRBd5X4Aj+uc/HV1HgemHLzfB22YyHGIznTWh++2SHbD2rTZSRQuh3xl5I?=
 =?us-ascii?Q?P7ioWRLZvYddYVvZdWvnxZ2BVWAF4g5D2Dov56InUu+u7WDXMkvA9RRk8q3b?=
 =?us-ascii?Q?i4Zz/wlkWn+RRZitekTZ6RNlEw2pZDClFgZHRdpaEER9Sg1IpjBIPuQSuANq?=
 =?us-ascii?Q?xMik5A3lkNnn5FfIHistBQmCv69vqvuCcYZBlV86DflgnoGA79L/AQFEQx89?=
 =?us-ascii?Q?rCzRa7+55xw7dwnzK1O5LHUWeSgGSUj0ZSbiQS/i+J+S7TPKBn9iXKmPDb91?=
 =?us-ascii?Q?dnGYFvz87fjcnnTVVgTjpqyM72e1dhH2FdyfxAvu2pFzCFQ/8h6K4R7wumAe?=
 =?us-ascii?Q?fH4DVDtaltO/gn8DoN7twaQaTc7yKwO/eN+qm4YYrWFT1Bl+8GKYIzSHvltR?=
 =?us-ascii?Q?DJ7dEYMu9lRTElzrTqaIGz57TOIpGRcjVf4g+TDcP0EpRFX6NqRaN+4A7I1r?=
 =?us-ascii?Q?31LBOXOQWUIuedoj51Eq/Ikc1i47OoSsCIC9sSJdoLqw7TpCRSLOBtHXNZBH?=
 =?us-ascii?Q?AuEFv+6mWr6mleyFCmTU74CS/Z6HL0z/qyzwqU7WxLyI7LAwUP2M0S7QoExH?=
 =?us-ascii?Q?EDQlLeoFKMb5vMaetM/yqIfGwNCdXIZVpW/Nk8SfScElfs5VCUIyWxrsa1JO?=
 =?us-ascii?Q?zQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <FBBE28788961CB40AACFEF31BAC5875F@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: DNQOWkOz2iFmZ5iwgL0bZVXiM4x770NchVD6HO/Zsn5/6dR1EzYyHXJXS9rgZeLSPFkWS6Si1l6axsKDNjKd8fPYByuTM4Gcw2wF6b8PWbHOYGenwD/MeOjjgseDSttmtB5RdU3HMOIFSiCF0sR7g6SpDqXyTTVXkFxofN6RKygnKBcs+cLS0RYaxgtePZvVO2T5FfTh+wM1W5Iw8AZQuj5DA6GLRZmfdB8r9y5JXe4jYmCKRNFYTvuKxwKUhyZ9SfC1aYdvekkfPeLYiM9UPJGYpjNoix9MTi7K25QIM0PI/ioyOYy9HbrTjyIr51gyzWwh34JMuDpcA7XlW1HS3IvIEy0CbTBlcHEWafUWF90rOcV8AlwarR9ZSbz8ysJqmGzDCijiCiJYSvh+3+jA1cbOFhtA8GGLr2di8Io9TSim2IMWqvUOxvTxmWDVVo2GU0yPXv2TC/rZkvoYOgdhoOeN70lrKqHSdGUaJV4ivDjSClewlItvlfiVd3tWe74matU8mmROLmEGlIMIafVS81k6dToIE3C2un3UI9d75Zou7aIhL54yH2PZ0t1zbqSbxEgebh38A/psAsb+OHaon+IKz6bXERxxjhBhrWRMjvqZTxMtVmP1MuPqSo0FC8NiD8P165QI11p3QIWY8E0a1c9jtSzj4rRk71/dgzSGXBFrUZxvI46lNJmH/j4yqE0fxJLr/LnORYd6z/KbxjAqW/bskiE6fztLEZSfJe82wA8KmqPDlwiDcG/SwS1MOOjrBI9epRmQ2dU3LPHC/MzMq6loVzvE0eC31ZMjJyjR3v1vZtGTX9NujQMAvZ4Z0mbulg2mCf6ODh401Esy9ViVF4y7FdOoyCKe3GXBdtUe9jm1bRWsbiPON956TPlIh95s
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b8a9c6bd-7c8a-4f31-4f03-08db71b15f37
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2023 17:11:22.3072
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: T6LSOz6scGFec02ROFaBnbD7BfnaMek9JANKIwJ/4lOqSbvBgaZIXUW888Bv+6R9c/pxABNVPL/IaYbgKYGNjA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4817
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-06-20_12,2023-06-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0
 mlxlogscore=761 suspectscore=0 spamscore=0 adultscore=0 phishscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2305260000 definitions=main-2306200155
X-Proofpoint-GUID: 5vzC9BUXbwqaTX5AN23ilqh88Q027c6o
X-Proofpoint-ORIG-GUID: 5vzC9BUXbwqaTX5AN23ilqh88Q027c6o
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Jun 1, 2023, at 1:06 PM, Dmitry Antipov <dmantipov@yandex.ru> wrote:
>=20
> On 6/1/23 19:39, Dan Carpenter wrote:
>=20
>> It's a false positive because the test is obviously intended for 32-bit
>> longs.
>=20
> I'm not an expert in compiler development, but I do not understand
> "obviously intended" in this context. An input literally compares
> <any unsigned 32-bit> > <max unsigned 64-bit> / 8, which is always
> false, and so the compiler complains. If "obviously intended" means
> "the compiler should silently optimize away this check for LP64",
> I would disagree, and that's why I would like to see the confirmation
> from LLVM/clang developers.

Dan, Dmitry, has there been any resolution of this issue?


--
Chuck Lever