Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp22073243rwd; Fri, 30 Jun 2023 03:35:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4frTJmaPT8bzGOKli/7+g/0QeRlpCGwOmdEllwYWOHrMFgppTbF68a2AIf7MfZoWUZ+rEP X-Received: by 2002:a05:6a20:4289:b0:124:eea9:6691 with SMTP id o9-20020a056a20428900b00124eea96691mr8097373pzj.31.1688121322239; Fri, 30 Jun 2023 03:35:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688121322; cv=none; d=google.com; s=arc-20160816; b=WPlaO6NXy09W125Fd7WYvPSci6OBhC5KTjaYOheYEDIfdFe28jZRMxPXaxnBV3/O+V Rx4l2wo91P5xDAC8DrGXelnnEtaKBymwxvrJMGOXir/Jm0t6yPleKPa5Pqk5Nvao1Ge4 GxtB85Nm3ZSODSgLxh4bmkEQQDoOImp3wCrXrt7WgOWQ/c7WbA1AtxpwTxLqkXCTAJzQ nEaGDY9k+4DYz5zhPpe+R6LND33MPm9PJFIp9PL1NkBbLN36T1qdB5CGdIP8bAUSgE19 EBVh+zFzJ/R/Z2v8oP1amgGf3RiMB/KhFtlWPaaEsrOfwvDcHBsyWzvrxoxB0U2DzWcj lKVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=mKcNiCcE2TVDaK3CeIz7rDYPv5SJDm0fl+R9OpQ+0yI=; fh=95yWxVmT0t/KJhTJyiHZDEOlo6BK4D8GUGztALlvte0=; b=FfjfDp9EBxGUe8ppegRi6PniJDfZLfLm9anBzqmGR1vr9B+ZwXRMoNfnxF13T6Pi8a g5qZNhvQlnh2iF8tGYdsVx+fSDBLIX0qaZb8N6b9k/AyPZf5ivl3TUpaPKEYbaz6vIs4 mjG8r+Hjgm1W7zz86ZMOrR4j5EZ8speck5g4H8mx8cJvfeajOQ6HTxYMZCXDNM/oop4P zlBT2MtZDkwWy84D7U7Utu4s50kp1mA1bXcAV47BePftFnO0G7jkjAKeJ1ykvUrS/bXZ QGnqhnfuDbHtEO5zw5Pz9ip/22DtiGNgKrBiZoWCTEeuBE83Er5tfv+72Lat1oTpsDd7 1Tbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@yandex.ru header.s=mail header.b=LV1mldrM; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 1-20020a630b01000000b00553e8d95744si12502224pgl.94.2023.06.30.03.35.01; Fri, 30 Jun 2023 03:35:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@yandex.ru header.s=mail header.b=LV1mldrM; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232036AbjF3K2v (ORCPT + 99 others); Fri, 30 Jun 2023 06:28:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231245AbjF3K2u (ORCPT ); Fri, 30 Jun 2023 06:28:50 -0400 Received: from forward502b.mail.yandex.net (forward502b.mail.yandex.net [178.154.239.146]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B1A0EE for ; Fri, 30 Jun 2023 03:28:48 -0700 (PDT) Received: from mail-nwsmtp-smtp-production-main-92.myt.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-92.myt.yp-c.yandex.net [IPv6:2a02:6b8:c12:34a8:0:640:678e:0]) by forward502b.mail.yandex.net (Yandex) with ESMTP id AD0FC5F0F0; Fri, 30 Jun 2023 13:28:45 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-92.myt.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id hSLc4A9Dea60-KRGSjfwc; Fri, 30 Jun 2023 13:28:44 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1688120924; bh=mKcNiCcE2TVDaK3CeIz7rDYPv5SJDm0fl+R9OpQ+0yI=; h=From:In-Reply-To:Cc:Date:References:To:Subject:Message-ID; b=LV1mldrME5l2bjq6nX2LndWZVEyEyndTQB3NJsglqAdLRsG4wAA5pNTAZEvXodDeg y2W7YM3NAMq7TK66OZARoy1SSpj2lrk3rTCKT4u1J3HgetlDjU13PbkT6KOejMfKgV wXWJnI0p8IAB3G36dki23ZHKKtUoE3VnbRdNFZrg= Authentication-Results: mail-nwsmtp-smtp-production-main-92.myt.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Message-ID: <546e78d0-633c-aed7-202e-54dddc7aaa7b@yandex.ru> Date: Fri, 30 Jun 2023 13:28:43 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] SUNRPC: clean up integer overflow check Content-Language: en-US To: Dan Carpenter Cc: Trond Myklebust References: <2390fdc8-13fa-4456-ab67-44f0744db412@moroto.mountain> From: Dmitry Antipov In-Reply-To: <2390fdc8-13fa-4456-ab67-44f0744db412@moroto.mountain> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On 6/30/23 12:46, Dan Carpenter wrote: > Use size_mul() to prevent the integer overflow. It silences the warning > and it's cleaner as well. I'm OK with this. But I still don't understand why the original warning was a compiler (actually two compilers we've tried) bug. Dmitry