Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Lorenzo Bianconi <lorenzo@kernel.org>
CC:     Chuck Lever <cel@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "lorenzo.bianconi@redhat.com" <lorenzo.bianconi@redhat.com>,
        "jlayton@kernel.org" <jlayton@kernel.org>
Subject: Re: [RFC] NFSD: add rpc_status entry in nfsd debug filesystem
Thread-Topic: [RFC] NFSD: add rpc_status entry in nfsd debug filesystem
Thread-Index: AQHZqnL2PhgnbC/p9EORLOfjtI8RFq+hzdIAgBFk9gCAAAY1gA==
Date:   Mon, 10 Jul 2023 15:55:38 +0000
Message-ID: <E916B0DD-7470-4F2C-A7F8-13DB070CC593@oracle.com>
References: <bac972c22c5acfa43969bb1bf164341b16ea045c.1688032742.git.lorenzo@kernel.org>
 <ZJ2NUPdX0KqvaUlr@manet.1015granger.net> <ZKwkulG5mZFRnFFD@lore-desk>
In-Reply-To: <ZKwkulG5mZFRnFFD@lore-desk>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hlp1LcZeJiSsi1/Z8TFpPDwXtB5zSO+UUYpiS1WKOhoO7KMfgD46ZyrlgxzG?=
 =?us-ascii?Q?PW99sN4PJGQCU9diQFdELVHuqk40Pbiy7ZRmWaN3D7OSHdh5vAShnbBwtSbt?=
 =?us-ascii?Q?C432CdrXbUI0AacJMc3h8WmJAODwVMhsF94s5C3n+J84ajKquLP8Fx6anZg3?=
 =?us-ascii?Q?iUa0ebViu2bt9896nb2Cn0JVc95lNzoSgWWGOGaZDczyYvL13qkPiB7LtGRG?=
 =?us-ascii?Q?UaEcplc9VbUGH/WQIDm0bSRiZWWk4gOrYpaaIQoYFrUAEA8izBkiN1cXnMyI?=
 =?us-ascii?Q?wByCgNgntdtQgkFrLiEenm4ATx/LdTdg6zEaggKxdm0+abaqXVcXqnp6TDJo?=
 =?us-ascii?Q?84OR1iWCgrl1GEH70xvE/UqzO83zwHwCrBSwa68opb6j8n6GDIK4mfKknZKl?=
 =?us-ascii?Q?PBW/H9ya9eKhAY2tiLVrE0y8TznfRpcCP21BHL6+oEOL6EyzYWYUMcjvQXcJ?=
 =?us-ascii?Q?Gdmn7Ipoes+hStA9eMVTgA+QVLjYv8zo3lkFJhiNQK7c1I2Kt5xoC2F/CzwZ?=
 =?us-ascii?Q?GJBiYcc9+mCU0kDHMGI/CmZGYbTXhBUG2Hnjr6h83TXymUxwgChUJSCd6cg+?=
 =?us-ascii?Q?2/Oo2zFqN2MfSKgORhKMpKbwhX4d2CN9sa7XrGqq3bSNrtzjuVF9FBQz9UMW?=
 =?us-ascii?Q?v3FXn0WBfOlimx4jiY4IRhZ4oGYKezBKbaPJNAr/2mLAbVdM8oX4iwkwm6gH?=
 =?us-ascii?Q?Y+xqLOC/knvM6FAlwRTrx3bzcZ4EBO7vhatlv4P2uZVZjY53H6fQYb31C7cy?=
 =?us-ascii?Q?v9JGQBuz0mANGeF1iak3PnCugAVIPlhqkn+WRhr3X9Mb1UwNh9BN88ODWvuW?=
 =?us-ascii?Q?0Gb1+BeoHCCCg1QhY1kQHORf30Wka1f6FYfCEwuJLlwuCBC8Xif80KPZWupm?=
 =?us-ascii?Q?5Kq0VrcDKVjJRqUtj3pcyWIFS/hZvsZEB362+FkTu83xSna4yqTyZE6bfZN8?=
 =?us-ascii?Q?wBO06PaXq8v88dfMD74hyfqIhClB4ZebykkHax0/fqkZtrwSlJzGOwvgZOXa?=
 =?us-ascii?Q?TXtdMuu1evo8HWGLO0bkCsmUdOC6K57wyR99OwN+01t40VHFKiNuV+YMpkt9?=
 =?us-ascii?Q?BM/7BM7318VsLhKVLqohF+U2bWpTGmm8ralUB6eZHu5Knw7b86C6Vn4Y8hsh?=
 =?us-ascii?Q?ntRsspDSer7vQUR/5zE5SA0oLqJ5+gsl/tZPbIGz+brQBdTT+8hMs0MLP44d?=
 =?us-ascii?Q?XpdN8mnacim8rMU1btXRfOffeusQu0Jvdm6KeoScVjsm4X6zK/qhxJweQF9y?=
 =?us-ascii?Q?ou1TE65OCmg9d+fvqoKIrmsOAj24yXCNYwkB9SR8F7NOvakAvgm0RxfKjvcR?=
 =?us-ascii?Q?f0VwEQbEFEOYLQ2x57QXPcvekpR8v+gSNgKoPV4qI/3Qpc07bkTzcJW5fjjB?=
 =?us-ascii?Q?Ecdquy5qWWal55z1T2owsiqh/exRK27XX+rMEPWteuWHJgVvDq50JjjOLVN1?=
 =?us-ascii?Q?/15hl9YHqLHZ9pYiBMWr4TgGyinQYESqzycdA1ROwcNy3lW6wnh4URgKdkuF?=
 =?us-ascii?Q?H8WB8FiwVnmkxYEL0f5GDnhOqRzWuc2ZlQps9t26PhTqPE7F/hxhDl8RF5Hk?=
 =?us-ascii?Q?iG3wHtAhfohOAfBjZk5VoG8IuUH6Gy7kayizcii4RvVncUqylv/l+qqnxO1J?=
 =?us-ascii?Q?gg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C5B760EFB3972D4198DC088922B68515@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: nQ0Cj08fXyVnYy9yHloCqpMe/b/Q5GiB2+rwsrPhibzyAbmd0WvN/yVRZU9ewU4MioZnC7wzG/7XcQw7XbRZp1/0Di983Yt06/Dj/5nfPXVFIkXcEx5lKpvvkQ7Np00fsLCPVX+IX3BVqxVGPascn9RNkL4Lb/fo1Dx4uFmcn1vOsfzRkvUWj6yj5Yv2YMzNmCn3TXV3UEYWm4l3JHO3dPw1p9WriN+3Ijr1TStHiGstk/ynvpV57bZVDHNK4+5SJB+9iTaKHUrmS4pQb95yLZYGHyTcgjDL8BTunVVrjlgL7Zj+YFUYuUkhBp+3E2N7Ub0fn4ZM2sth9okOfELi0/725Ekz+BJzVLKeMn/V7WGNqWCO6cVGj1mjfZGFu2+Btq5WAOvPuz1yBk4yfrnbhRomKAh7m2vsZIFt8I8m3M6tirIkQtCKAtoWHNKK082T1SfpslRQLvbGG1dNo26/rvSdfOsMHaM1D8KSgOhmVF3OmE0tUwVVGuZO89UUHrXRApzXK/3DluYoQ3T4EXDmlsqo9itO+j01STA5qlbr2TpYjxwUbwlwVOMGrosr3vDV/ma1wXkhPdTwko6nEBnlP4y6qSGyYQ6VLL61+qjbXvnajnBs9dhc32AHVdmU0K+359aU8Ywe+J5qV5VagkPD1BbmuOmUGhA001rZjOGyqCHIj60a7C7dfQLoELS77sMubJBnpBMHcDXJV9d9bLyEpKZfjOU6ZeV5y6gjqd1zGTZ0JoEmX5L/QJg5zjxEhNRWbpxL6fZoWBU4y+w/r9Urh3yP6al/1yNL5PzPL86FdfhnttIvq4JxB5Oy3z6yeiDE
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e722c2f2-d0ad-4ea2-f45b-08db815e1ae1
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jul 2023 15:55:38.0565
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cLLZoXZt8ZcNH436cH/dW15LXuFapD5wwQ8qrUer8qaRyAXVLA5M1oiYzC5I75+apyTO26s+8k76l4bpxBMYug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5847
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-10_12,2023-07-06_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 mlxlogscore=999
 adultscore=0 suspectscore=0 mlxscore=0 malwarescore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000
 definitions=main-2307100143
X-Proofpoint-ORIG-GUID: v3xY1KcbVUwzIk8VzcKq6zNLs18HXEtm
X-Proofpoint-GUID: v3xY1KcbVUwzIk8VzcKq6zNLs18HXEtm
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Jul 10, 2023, at 11:33 AM, Lorenzo Bianconi <lorenzo@kernel.org> wrote=
:
>=20
>>> + for (i =3D 0; i < serv->sv_nrpools; i++) {
>>> + struct svc_rqst *rqstp;
>>> +
>>> + seq_puts(m, "XID        | FLAGS      | PROG       |");
>>> + seq_puts(m, " VERS       | PROC\t|");
>>> + seq_puts(m, " REMOTE - LOCAL IP ADDR");
>>> + seq_puts(m, "\t\t\t\t\t\t\t\t   | NFS4 COMPOUND OPS\n");
>>> + list_for_each_entry_rcu(rqstp,
>>> + &serv->sv_pools[i].sp_all_threads,
>>> + rq_all) {
>>> + if (!test_bit(RQ_BUSY, &rqstp->rq_flags))
>>> + continue;
>>> +
>>> + seq_printf(m,
>>> +    "0x%08x | 0x%08lx | 0x%08x | NFSv%d      | %s\t|",
>>> +    be32_to_cpu(rqstp->rq_xid), rqstp->rq_flags,
>>> +    rqstp->rq_prog, rqstp->rq_vers,
>>> +    svc_proc_name(rqstp));
>>> +
>>> + if (rqstp->rq_addr.ss_family =3D=3D AF_INET) {
>>> + seq_printf(m, " %pI4 - %pI4\t\t\t\t\t\t\t   |",
>>> +    &((struct sockaddr_in *)&rqstp->rq_addr)->sin_addr,
>>> +    &((struct sockaddr_in *)&rqstp->rq_daddr)->sin_addr);
>>> + } else if (rqstp->rq_addr.ss_family =3D=3D AF_INET6) {
>>> + seq_printf(m, " %pI6 - %pI6 |",
>>> +    &((struct sockaddr_in6 *)&rqstp->rq_addr)->sin6_addr,
>>> +    &((struct sockaddr_in6 *)&rqstp->rq_daddr)->sin6_addr);
>>> + } else {
>>> + seq_printf(m, " Unknown address family: %hu\n",
>>> +    rqstp->rq_addr.ss_family);
>>> + continue;
>>> + }
>>> +#ifdef CONFIG_NFSD_V4
>>> + if (rqstp->rq_vers =3D=3D NFS4_VERSION &&
>>> +     rqstp->rq_proc =3D=3D NFSPROC4_COMPOUND) {
>>> + /* NFSv4 compund */
>>> + struct nfsd4_compoundargs *args =3D rqstp->rq_argp;
>>> + struct nfsd4_compoundres *resp =3D rqstp->rq_resp;
>>> +
>>> + while (resp->opcnt < args->opcnt) {
>>> + struct nfsd4_op *op =3D &args->ops[resp->opcnt++];
>>> +
>>> + seq_printf(m, " %s", nfsd4_op_name(op->opnum));
>>> + }
>>> + }
>>> +#endif /* CONFIG_NFSD_V4 */
>>> + seq_puts(m, "\n");
>>=20
>> My only quibble here is that the file format needs to be parsable
>> by scripts as well as readable by humans. I'm not sure I have a
>> specific comment, but it's something that needs some attention and
>> verification (with, say, a sample user space tool, hint hint).
>=20
> maybe we can add a csv hanlder, what do you think? not sure.

I suggested JSON to Jeff as another option, but I don't think we want
to swing that far in the other direction.

There are plenty of examples of /sys files that are both parsable and
human-friendly. I'll leave it to you to find one or two formats that
seem capable of the task at hand, and let's pick from one of those.


--
Chuck Lever