Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 10 Jul 2023 18:19:39 +0200
From:   Lorenzo Bianconi <lorenzo@kernel.org>
To:     Chuck Lever III <chuck.lever@oracle.com>
Cc:     Chuck Lever <cel@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "lorenzo.bianconi@redhat.com" <lorenzo.bianconi@redhat.com>,
        "jlayton@kernel.org" <jlayton@kernel.org>
Subject: Re: [RFC] NFSD: add rpc_status entry in nfsd debug filesystem
Message-ID: <ZKwvmyff/aqwsTBk@lore-desk>
References: <bac972c22c5acfa43969bb1bf164341b16ea045c.1688032742.git.lorenzo@kernel.org>
 <ZJ2NUPdX0KqvaUlr@manet.1015granger.net>
 <ZKwkulG5mZFRnFFD@lore-desk>
 <E916B0DD-7470-4F2C-A7F8-13DB070CC593@oracle.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="0JFP51DTI3ifb8uE"
Content-Disposition: inline
In-Reply-To: <E916B0DD-7470-4F2C-A7F8-13DB070CC593@oracle.com>
Precedence: bulk


--0JFP51DTI3ifb8uE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Jul 10, Chuck Lever III wrote:
>=20
>=20
> > On Jul 10, 2023, at 11:33 AM, Lorenzo Bianconi <lorenzo@kernel.org> wro=
te:
> >=20
> >>> + for (i =3D 0; i < serv->sv_nrpools; i++) {
> >>> + struct svc_rqst *rqstp;
> >>> +
> >>> + seq_puts(m, "XID        | FLAGS      | PROG       |");
> >>> + seq_puts(m, " VERS       | PROC\t|");
> >>> + seq_puts(m, " REMOTE - LOCAL IP ADDR");
> >>> + seq_puts(m, "\t\t\t\t\t\t\t\t   | NFS4 COMPOUND OPS\n");
> >>> + list_for_each_entry_rcu(rqstp,
> >>> + &serv->sv_pools[i].sp_all_threads,
> >>> + rq_all) {
> >>> + if (!test_bit(RQ_BUSY, &rqstp->rq_flags))
> >>> + continue;
> >>> +
> >>> + seq_printf(m,
> >>> +    "0x%08x | 0x%08lx | 0x%08x | NFSv%d      | %s\t|",
> >>> +    be32_to_cpu(rqstp->rq_xid), rqstp->rq_flags,
> >>> +    rqstp->rq_prog, rqstp->rq_vers,
> >>> +    svc_proc_name(rqstp));
> >>> +
> >>> + if (rqstp->rq_addr.ss_family =3D=3D AF_INET) {
> >>> + seq_printf(m, " %pI4 - %pI4\t\t\t\t\t\t\t   |",
> >>> +    &((struct sockaddr_in *)&rqstp->rq_addr)->sin_addr,
> >>> +    &((struct sockaddr_in *)&rqstp->rq_daddr)->sin_addr);
> >>> + } else if (rqstp->rq_addr.ss_family =3D=3D AF_INET6) {
> >>> + seq_printf(m, " %pI6 - %pI6 |",
> >>> +    &((struct sockaddr_in6 *)&rqstp->rq_addr)->sin6_addr,
> >>> +    &((struct sockaddr_in6 *)&rqstp->rq_daddr)->sin6_addr);
> >>> + } else {
> >>> + seq_printf(m, " Unknown address family: %hu\n",
> >>> +    rqstp->rq_addr.ss_family);
> >>> + continue;
> >>> + }
> >>> +#ifdef CONFIG_NFSD_V4
> >>> + if (rqstp->rq_vers =3D=3D NFS4_VERSION &&
> >>> +     rqstp->rq_proc =3D=3D NFSPROC4_COMPOUND) {
> >>> + /* NFSv4 compund */
> >>> + struct nfsd4_compoundargs *args =3D rqstp->rq_argp;
> >>> + struct nfsd4_compoundres *resp =3D rqstp->rq_resp;
> >>> +
> >>> + while (resp->opcnt < args->opcnt) {
> >>> + struct nfsd4_op *op =3D &args->ops[resp->opcnt++];
> >>> +
> >>> + seq_printf(m, " %s", nfsd4_op_name(op->opnum));
> >>> + }
> >>> + }
> >>> +#endif /* CONFIG_NFSD_V4 */
> >>> + seq_puts(m, "\n");
> >>=20
> >> My only quibble here is that the file format needs to be parsable
> >> by scripts as well as readable by humans. I'm not sure I have a
> >> specific comment, but it's something that needs some attention and
> >> verification (with, say, a sample user space tool, hint hint).
> >=20
> > maybe we can add a csv hanlder, what do you think? not sure.
>=20
> I suggested JSON to Jeff as another option, but I don't think we want
> to swing that far in the other direction.
>=20
> There are plenty of examples of /sys files that are both parsable and
> human-friendly. I'll leave it to you to find one or two formats that
> seem capable of the task at hand, and let's pick from one of those.

ok, I will take a look. In the meantime I posted a new revision to continue=
 the
discussion.

Regartds,
Lorenzo

>=20
>=20
> --
> Chuck Lever
>=20
>=20

--0JFP51DTI3ifb8uE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZKwvmwAKCRA6cBh0uS2t
rIW3AP0Vr7Sgk2hss85aXUXAHIVtRv1GPpX8NYQBGcTY2Fv5mgD+MWNw+1qJNrYl
38ktfYWIV3ysfgHNklo9G4jZHUGLRgQ=
=9OJa
-----END PGP SIGNATURE-----

--0JFP51DTI3ifb8uE--