Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e4d22ae6cefb34463ed7d04287ca9e81cd0949d8.camel@kernel.org>
Subject: Re: [PATCH 1/1] runtest/net.nfs: Run nfs02_06 on TCP only
From:   Jeff Layton <jlayton@kernel.org>
To:     Petr Vorel <pvorel@suse.cz>, ltp@lists.linux.it
Cc:     Olga Kornievskaia <olga.kornievskaia@gmail.com>,
        Anna Schumaker <Anna.Schumaker@Netapp.com>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Chuck Lever <chuck.lever@oracle.com>, linux-nfs@vger.kernel.org
Date:   Wed, 12 Jul 2023 06:28:10 -0400
In-Reply-To: <20230622084648.490498-1-pvorel@suse.cz>
References: <20230622084648.490498-1-pvorel@suse.cz>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-06-22 at 10:46 +0200, Petr Vorel wrote:
> UDP support disabled was on NFS server in kernel 5.6.
> Due that 2 of 3 nfs06.sh tests runs are being skipped on newer kernels.
>=20
> Therefore NFSv3 job in nfs02_06 test as TCP. This way all jobs in the
> test are TCP, thus test will not be skipped. This also bring NFSv3
> testing also under TCP (previously it was tested only on UDP).
>=20
> Keep UDP in nfs01_06 jobs, so that NFSv3 on UDP is still covered for
> older kernels.
>=20
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  runtest/net.nfs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/runtest/net.nfs b/runtest/net.nfs
> index 72cf4b307..15a960017 100644
> --- a/runtest/net.nfs
> +++ b/runtest/net.nfs
> @@ -58,7 +58,7 @@ nfs41_ipv6_05 nfs05.sh -6 -v 4.1 -t tcp
>  nfs42_ipv6_05 nfs05.sh -6 -v 4.2 -t tcp
> =20
>  nfs01_06  nfs06.sh -v "3,3,3,4,4,4" -t "udp,udp,tcp,tcp,tcp,tcp"
> -nfs02_06 nfs06.sh -v "3,4,4.1,4.2,4.2,4.2" -t "udp,tcp,tcp,tcp,tcp,tcp"
> +nfs02_06 nfs06.sh -v "3,4,4.1,4.2,4.2,4.2" -t "tcp,tcp,tcp,tcp,tcp,tcp"
>  nfs03_ipv6_06 nfs06.sh -6 -v "4,4.1,4.1,4.2,4.2,4.2" -t "tcp,tcp,tcp,tcp=
,tcp,tcp"
> =20
>  nfs3_07 nfs07.sh -v 3 -t udp

UDP support is more or less being deprecated at this point, so testing
on tcp is preferred.

Acked-by: Jeff Layton <jlayton@kernel.org>