Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Jul 2023 13:18:18 +0200
From:   Petr Vorel <pvorel@suse.cz>
To:     Jeff Layton <jlayton@kernel.org>
Cc:     ltp@lists.linux.it,
        Olga Kornievskaia <olga.kornievskaia@gmail.com>,
        Anna Schumaker <Anna.Schumaker@netapp.com>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Chuck Lever <chuck.lever@oracle.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/1] runtest/net.nfs: Run nfs02_06 on TCP only
Message-ID: <20230712111818.GA775074@pevik>
Reply-To: Petr Vorel <pvorel@suse.cz>
References: <20230622084648.490498-1-pvorel@suse.cz>
 <e4d22ae6cefb34463ed7d04287ca9e81cd0949d8.camel@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e4d22ae6cefb34463ed7d04287ca9e81cd0949d8.camel@kernel.org>
Precedence: bulk

Hi Jeff,

> On Thu, 2023-06-22 at 10:46 +0200, Petr Vorel wrote:
> > UDP support disabled was on NFS server in kernel 5.6.
> > Due that 2 of 3 nfs06.sh tests runs are being skipped on newer kernels.

> > Therefore NFSv3 job in nfs02_06 test as TCP. This way all jobs in the
> > test are TCP, thus test will not be skipped. This also bring NFSv3
> > testing also under TCP (previously it was tested only on UDP).

> > Keep UDP in nfs01_06 jobs, so that NFSv3 on UDP is still covered for
> > older kernels.

> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> >  runtest/net.nfs | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)

> > diff --git a/runtest/net.nfs b/runtest/net.nfs
> > index 72cf4b307..15a960017 100644
> > --- a/runtest/net.nfs
> > +++ b/runtest/net.nfs
> > @@ -58,7 +58,7 @@ nfs41_ipv6_05 nfs05.sh -6 -v 4.1 -t tcp
> >  nfs42_ipv6_05 nfs05.sh -6 -v 4.2 -t tcp

> >  nfs01_06  nfs06.sh -v "3,3,3,4,4,4" -t "udp,udp,tcp,tcp,tcp,tcp"
> > -nfs02_06 nfs06.sh -v "3,4,4.1,4.2,4.2,4.2" -t "udp,tcp,tcp,tcp,tcp,tcp"
> > +nfs02_06 nfs06.sh -v "3,4,4.1,4.2,4.2,4.2" -t "tcp,tcp,tcp,tcp,tcp,tcp"
> >  nfs03_ipv6_06 nfs06.sh -6 -v "4,4.1,4.1,4.2,4.2,4.2" -t "tcp,tcp,tcp,tcp,tcp,tcp"

> >  nfs3_07 nfs07.sh -v 3 -t udp

> UDP support is more or less being deprecated at this point, so testing
> on tcp is preferred.

> Acked-by: Jeff Layton <jlayton@kernel.org>

too late to add the ack to the commit message (already merged),
but thanks for your confirmation.

FYI I kept some UDP testing because new LTP releases are sometimes used with
*not so old* enterprise distros. But these UDP tests are single tests (there is
one test run under TCP and one under UDP). nfs06.sh is specific that it combines
6 various NFS versions and TCP + UDP, and single UDP causes whole specific test
run being cancelled. And again, I still kept nfs01_06 which uses older NFS (ver
3 and 4) with original UDP for older distros.

Interesting question is when to drop UDP testing completely. I guess few years
after kernel 5.6 was released, when all major enterprise distros are based on
kernel >= 5.6 and there are no stable/LTS with older kernel (e.g. in 2026, when
5.4 and older LTS will be EOL).

Kind regards,
Petr