Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp38253761rwd; Wed, 12 Jul 2023 05:24:32 -0700 (PDT) X-Google-Smtp-Source: APBJJlGAFrO3Nc850GsT1upmA1TTjEYLdZEUsMdWVW5pmLPp6MKnvVDyD9iatMepB4y681ax6gr1 X-Received: by 2002:aa7:d503:0:b0:51d:a488:3b3d with SMTP id y3-20020aa7d503000000b0051da4883b3dmr16520964edq.35.1689164672520; Wed, 12 Jul 2023 05:24:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689164672; cv=none; d=google.com; s=arc-20160816; b=Z5bgRxNmJqh1F1qNQhrqYtYO11DnqeG5hJxc2Y7DdA7dTH53Fu7IGgRitipqxg9hev +VK6RQGHU/l9KG+f9JozS3AcZMkPc1TCHPzL+lLjegmhjAYnQD71pMmdxmjNe1ScbYD0 U05yGHw83STwHKahGAy8ch8vL//4wRPoXjnkS5k+v8x3fHS3VEEY4VZCWQnzwpFh/JqN QFy/bwpGxpWc/uQ0hk2ZZJCjlZ0qRvYOmPG8H8d7vZxHKi3twiymJTgBx2JBUp/RbeMJ bOZ1Ns9ckkr5COY3KHxK63uQ1yl2qX1GUq2+BZLD4S1tljkUDZtE8R8wRh84p8pxTNC2 v9cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:feedback-id :dkim-signature; bh=+GntHArDzPKLk2PNbZnKYMOj1ok9kjbg95D2vSVIuO0=; fh=w2100xcarte+vkQHhbrpIsotXuPe0Oz3RnsWyj5Q8Ds=; b=gVqWEQp35v/J05SKh1PRtfGTf/9E350iuE8lJ6TDk0fonHJlXIbOM5R6bfd/1uV0mN 7jJv5DJpjX/MknpwHHnkqQR1uJm2EAK41mHIDBVSFsAsR0bMG36fX7kHJBb87xnkAx/x 1Wco+s/yr83/ixgacDQQ7W6NrsnaZgB5wQYPBZE07KNHI4mniNv+4CcT3zTfy7QwxWg+ 703GfrkMGTo5LzoPI91LzbNdJq2LgU/lRFfNeTsCHYt+W2GkVJm0Jsk50v+Vhepx50/w bZ9AKyi3KKn+WgQ4jjTvLLSi5EcyCltxcFyG+I4E+jEWBCcyvKW6aWbUAQUgIkl2rSQG ApMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=Br3CGEPC; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e13-20020aa7d7cd000000b0051e22a62720si4401749eds.562.2023.07.12.05.24.00; Wed, 12 Jul 2023 05:24:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=Br3CGEPC; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230022AbjGLMLL (ORCPT + 99 others); Wed, 12 Jul 2023 08:11:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232923AbjGLMLH (ORCPT ); Wed, 12 Jul 2023 08:11:07 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7D991BFF for ; Wed, 12 Jul 2023 05:10:48 -0700 (PDT) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 42AC45C016C; Wed, 12 Jul 2023 08:10:45 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 12 Jul 2023 08:10:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1689163845; x=1689250245; bh=+GntHArDzPKLk 2PNbZnKYMOj1ok9kjbg95D2vSVIuO0=; b=Br3CGEPCZcEcqxRn52GeyHuQvJYBn FMVBnaYxjnM8c1MNkxijgpho/pmGMsHZLWOCHRWd6aoBY5VtxM9X6iSRGVfxuKgQ 30SqyE2bIwad2lhN0BQV6IitJFWQPvzvX39PY66X3xFs33anURxQaWtGMJeVDCbN K53uEZXwXyIBzE0MwWkOYxBqT0C7kHEUWd4Wq6DO6VZn8g9Cyrm72g8WZZ6Gd4tT q0w/s/vioenXIafGrkW1K2nHGO66QlHngwCRDpUo3BOHwRJGtRNWPcV1yCGBMqfe OXP1haXI/2r3fdB3WiZIGSbUjV9vM0RXBxWK7TFM3HYBhb6u9EzT1i1qQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrfedvgdehtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefkughoucfu tghhihhmmhgvlhcuoehiughoshgthhesihguohhstghhrdhorhhgqeenucggtffrrghtth gvrhhnpedvudefveekheeugeeftddvveefgfduieefudeifefgleekheegleegjeejgeeg hfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehiug hoshgthhesihguohhstghhrdhorhhg X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 12 Jul 2023 08:10:44 -0400 (EDT) Date: Wed, 12 Jul 2023 15:10:39 +0300 From: Ido Schimmel To: Benjamin Coddington Cc: trond.myklebust@hammerspace.com, anna@kernel.org, aahringo@redhat.com, linux-nfs@vger.kernel.org Subject: Re: [PATCH] NFS: Fix sysfs server name memory leak Message-ID: References: <6702796fee0365bf399800326bbe6c88e5f73f68.1689014440.git.bcodding@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6702796fee0365bf399800326bbe6c88e5f73f68.1689014440.git.bcodding@redhat.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Mon, Jul 10, 2023 at 02:41:58PM -0400, Benjamin Coddington wrote: > Free the formatted server index string after it has been duplicated by > kobject_rename(). > > Fixes: 1c7251187dc0 ("NFS: add superblock sysfs entries") > Reported-by: Alexander Aring > Signed-off-by: Benjamin Coddington Hit this issue as well. This patch fixes the problem. Tested-by: Ido Schimmel Thanks