Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3376204b7b0335721956c45f22b10a2ff41aa276.camel@kernel.org>
Subject: Re: [PATCH RFC 0/4] Send RPC-on-TCP with one sock_sendmsg() call
From:   Jeff Layton <jlayton@kernel.org>
To:     Chuck Lever <cel@kernel.org>, linux-nfs@vger.kernel.org
Cc:     Chuck Lever <chuck.lever@oracle.com>,
        David Howells <dhowells@redhat.com>
Date:   Fri, 14 Jul 2023 09:26:03 -0400
In-Reply-To: <168893265677.1949.1632048925203798962.stgit@manet.1015granger.net>
References: <168893265677.1949.1632048925203798962.stgit@manet.1015granger.net>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Sun, 2023-07-09 at 16:04 -0400, Chuck Lever wrote:
> After some discussion with David Howells at LSF/MM 2023, we arrived
> at a plan to use a single sock_sendmsg() call for transmitting an
> RPC message on socket-based transports. This is an initial part of
> the transition to support handling folios with file content, but it
> has scalability benefits as well.
>=20
> Comments, suggestions, and test results are welcome.
>=20
> ---
>=20
> Chuck Lever (4):
>       SUNRPC: Convert svc_tcp_sendmsg to use bio_vecs directly
>       SUNRPC: Convert svc_udp_sendto() to use the per-socket bio_vec arra=
y
>       SUNRPC: Use a per-transport receive bio_vec array
>       SUNRPC: Send RPC message on TCP with a single sock_sendmsg() call
>=20
>=20
>  include/linux/sunrpc/svc.h     |   1 -
>  include/linux/sunrpc/svcsock.h |   7 ++
>  net/sunrpc/svcsock.c           | 142 ++++++++++++++++++---------------
>  3 files changed, 86 insertions(+), 64 deletions(-)
>=20
> --
> Chuck Lever
>=20

Aside from my concerns with bounds checking on the first patch, this
looks like a good set of changes overall. Does it show any performance
improvements in your testing?
--=20
Jeff Layton <jlayton@kernel.org>