Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp2613763rwp; Fri, 14 Jul 2023 08:39:41 -0700 (PDT) X-Google-Smtp-Source: APBJJlF7MPlFJreCOVk9uX8shPgCBITjduthAE4ER5rSoufAz+z7btxEZXoNTE63EnAwtE31uOUw X-Received: by 2002:a05:6a20:9384:b0:133:1f6c:a0bd with SMTP id x4-20020a056a20938400b001331f6ca0bdmr4800862pzh.58.1689349181137; Fri, 14 Jul 2023 08:39:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689349181; cv=none; d=google.com; s=arc-20160816; b=j46QXnhYkVANsElQRwX4dElK8j3DhLIOpnIhEF5D5ftJz91cwb1uw2Usnrwp6SkyrW DcU3eGqkHHSwDhvNB6zWSRsOnB6fJhBhxzTa6Lei+Hms/8TSc+LAVsIB0skyseDjgvXD PRBX2CsgRl5WGciXiXzfwNMO1YKLoNbByQ18xs6anN+DOAxX8EGytjnaSYBiO8KwmAI8 pvqmSQeDL/Gsq308kn5bWccgyV3gBVxV3B8B79BPN/XTMOsRjc5HnpKwFWIFvnpvlU4j IAIARcYUNjjo8raAsfJYcTFwX8IFGs31aLGVH9UixZgI5KyJ0RvtADShKFQqqUSqXLUe Jpiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=9IvDhb5ELJqXrzg3Tr0Ch4TKzHEZqp43o44UDZzYcdE=; fh=S14JoeZoHwdZsgrgQbJK0jxn1EHPSYwRu/+vWM+gYDU=; b=LcKVPlikPd9Fa15XY9sC0Ua1hp8rcZJ/OLWf0hqbVKUD1XHqmxZzobx8Gbx8XtJE/W +YiAnt0rcVds/jYoRjymyaNxSb+1NPrfwnAFIBi6gmOiFGZ9gwsK3+9sZwnsBFJAKtRq SNSFgkG7OF71da4FFG0vPk8EuzoHBl0wEoGx43R4RI/qUNYyPn5Qiau0fKIp5lWSyGrG b8wnZsloDF3fZo3gJlPg1+iMw6xJ+seHyxorYQcoz5CmParr4BMlzLr7FAaVJi3SIRL9 AG+NdtRVTc9szh77a0tR/zqH6QTD1t04HUeD4rZPKx4nk3GTGsnIbMqd4uq+8LXYKi6M oD3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BUZE28FR; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x186-20020a6386c3000000b0055c9d565335si2145632pgd.557.2023.07.14.08.39.28; Fri, 14 Jul 2023 08:39:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BUZE28FR; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235585AbjGNPUO (ORCPT + 99 others); Fri, 14 Jul 2023 11:20:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234916AbjGNPUO (ORCPT ); Fri, 14 Jul 2023 11:20:14 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 875371BD4 for ; Fri, 14 Jul 2023 08:19:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689347967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9IvDhb5ELJqXrzg3Tr0Ch4TKzHEZqp43o44UDZzYcdE=; b=BUZE28FRznpYQHYhrfIsgCBCS5pffRWlN3lJM1bbfeoLg+402CCxG4CpmJAtE0pMntCA/p J26F2q+JUYDk4Ppr8IDi53YwJBCOom0cJEjTDeXKH3im8gfTo+MyITvxzG70qembY/bvF3 sXIDek7jg/aoTDDg5Z9ArSAcGgzR+DA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-204-CRZYOMIIOWu9c2hisvyrQw-1; Fri, 14 Jul 2023 11:19:22 -0400 X-MC-Unique: CRZYOMIIOWu9c2hisvyrQw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D351980006E; Fri, 14 Jul 2023 15:19:21 +0000 (UTC) Received: from [192.168.37.1] (unknown [10.22.50.6]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2426240C2063; Fri, 14 Jul 2023 15:19:20 +0000 (UTC) From: Benjamin Coddington To: Kinglong Mee Cc: Anna Schumaker , Linux NFS Mailing List , Trond Myklebust Subject: Re: [PATCH] nfs: fix redundant readdir request after get eof Date: Fri, 14 Jul 2023 11:19:19 -0400 Message-ID: <70B9A332-FDA0-418E-81CF-962229E93AC5@redhat.com> In-Reply-To: References: <8d6d9329-f5f1-2f15-f578-e4f8010b9b02@gmail.com> <5E28252D-6EA1-4DD9-A5B3-957E13589982@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On 13 Jul 2023, at 23:07, Kinglong Mee wrote: > Hi Ben, > ... > Comparing with the above one, this seems work. This fixes it for me and keeps the optimization. Its quite a subtle bit of logic - maybe a comment is appropriate? One non-intuitive thing here is that array->size == 19 for a directory with 18 entries, since we count the "eof" entry as a blank entry instead of the last real entry. Ben