Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Benjamin Coddington <bcodding@redhat.com>
To:     Olga Kornievskaia <olga.kornievskaia@gmail.com>
Cc:     trond.myklebust@hammerspace.com, anna.schumaker@netapp.com,
        linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/1] NFSv4.1: fix zero value filehandle in post open
 getattr
Date:   Fri, 14 Jul 2023 11:40:59 -0400
Message-ID: <C4261248-D6E9-46FC-8461-8233DF0B0BAF@redhat.com>
In-Reply-To: <CAN-5tyGiiSr+jkh=WL_C4=wBAfZUiQZVsJoVxn0Sxg=yK+TA9g@mail.gmail.com>
References: <20230713195416.30414-1-olga.kornievskaia@gmail.com>
 <A0663B9C-F005-4089-ABD6-542F77EE43ED@redhat.com>
 <CAN-5tyGa1dV1A5RgZsMCQzFHDV63=LDJq0DTpg8aJ=UCO+k+Og@mail.gmail.com>
 <A05D90E0-6D74-4948-B948-852B1448DD3C@redhat.com>
 <CAN-5tyGiiSr+jkh=WL_C4=wBAfZUiQZVsJoVxn0Sxg=yK+TA9g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On 14 Jul 2023, at 9:57, Olga Kornievskaia wrote:
>
> I guess I don't understand what's the problem with the current
> approach which is simple.

No problem - I'm just bad at code review.

I was trying to get my head around why the o_arg->fh couldn't be used, and
then wondering why you were hitting that warning.

Then I worried that the opendata was already freed at the point the getattr
was trying to use it again, and because its a codepath I can't exercise
easily my normal approach of just throwing in debug statements didn't work -
but I think the opendata is still there because _nfs4_do_open has it pinned.

Ben