Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp6052727rwp; Mon, 17 Jul 2023 14:06:23 -0700 (PDT) X-Google-Smtp-Source: APBJJlF1yNZXhnXanysv0teBHJTwxg7/8xigW3sc4HOSYmL1u+9zm9q7V6SrZnxsvYf91ce7Pfcz X-Received: by 2002:a17:902:c40f:b0:1b1:753a:49ce with SMTP id k15-20020a170902c40f00b001b1753a49cemr13246842plk.53.1689627983151; Mon, 17 Jul 2023 14:06:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689627983; cv=none; d=google.com; s=arc-20160816; b=E3DPWnvQz+jTvUKhFjpB6hM+n6R1xUGNDSgW468pQoMfT5shnRBJmA68vbhuWqID/f RG40Y+hGM0uFji40gIqfa7aWYmpTBm/cqGdbM7Zon/pgXs3XIaRzdZMNGkppbd+n5H1f tBVx3cYlcb+ZBtLyjdT5Tll+93efJTa/Adh8HV+6+jO5TBvUk/PIbAhm1NIX9E16w/J+ +5eaRC11YKr4q8XMQ41et6qWEZtMsjRjEnZE0X1Vi033zjjIJgoYx7ILBQVqph0gGq70 ykd9HrkXvvLL1+L5zZj6BPISeem1ZsR8SFOMXn5CjlJKuUVqk2N++iG0ZoXpAoVzkWRk UN5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=j4o9xyWuYF2zJrXFep4KzoqfPICZkMZKyHwN5r5sBqU=; fh=CLPq7QbinQSVZA7N65n4uhPiamQHST74TBceNWSqx8g=; b=dxCPk5JB/iVbkMyKy7abin0HD2NSaH/0fC6LmXsSijMDbQxrRkLqFOwKoiDtAvulgA 6Xx1jp4naQdMgukywiYnfXHyCzUcNo0FBvneJBtEDtryeSl37QFsOlLoB6ODh4OCpWwC iTmHL94hyfs5VnLphmHTAZ4s5fm+9FexxbK3n0Dfih+hF1foHLgxcX1xqL0UPiCEiACY ghM0DwkqxIQM0YMX4NmTCxb5CqYHpLhGZa92xrUl8Ahy4Dd3Akc4LsAF0tyIppE8xLUY qMzrUYNMtJjj3OWxTW1IH/FoAexTgzDQOBjlAZKyKa3rLCqfX+kn92yP9uAJcDzgx/Hu a2iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gAbL96hh; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o17-20020a170902d4d100b001b8904eadb8si440743plg.460.2023.07.17.14.05.59; Mon, 17 Jul 2023 14:06:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gAbL96hh; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231327AbjGQUxW (ORCPT + 99 others); Mon, 17 Jul 2023 16:53:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229690AbjGQUxR (ORCPT ); Mon, 17 Jul 2023 16:53:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C70FB10C8 for ; Mon, 17 Jul 2023 13:52:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 511E6611EA for ; Mon, 17 Jul 2023 20:52:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CBFDC433C8; Mon, 17 Jul 2023 20:52:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689627160; bh=h59xsKMFcnYKuOjWPjmlOPTlgmo5NrealDwNq1F03/k=; h=From:To:Cc:Subject:Date:From; b=gAbL96hh0S5nC/KOVH6N6w2sHFxvwaaRFjQTiCG40DPvU/33q8MpkDzDalsQnKz/I lkfjFO5gwZmJUFoZHzxkl7vQt7iNL9pHYTTfvOz6x10wzu33njYAMlwCYCFIpb2S+r lzXXA8UsthjcExDC/s7nnEZZPj8rXL8LweEsBnqCiS0v2lbUf4T2oojs9vKNRXbKn6 eZKrR9BFJV7DJFB1by4tp0/XlNMng/Hz+0xaam3fRcS20ykdefCsPTThy+uEOpOSS+ LM/awsparR07amXbQVyKnTJbmr2Nd2EsDhNhuIOK33irf93uakjWh7naI67A0s2xdc dFlgXOut+1XOQ== From: Anna Schumaker To: linux-nfs@vger.kernel.org, trond.myklebust@hammerspace.com Cc: anna@kernel.org, krzysztof.kozlowski@linaro.org Subject: [PATCH v5 0/5] NFSv4.2: Various READ_PLUS fixes Date: Mon, 17 Jul 2023 16:52:34 -0400 Message-ID: <20230717205239.921002-1-anna@kernel.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Anna Schumaker These patches are a handul of fixes I've done recently to the READ_PLUS code. This includes fixing some smatch warnings, fixing the XDR reply length calculation, improving scratch buffer handling, and having xdr_inline_decode() kmap pages if we detect that they're HIGHMEM so we don't oops during READ_PLUS xdr decoding. I also (optimistically) have a patch at the end to enable CONFIG_READ_PLUS by default. My hope right now is that we can enable READ_PLUS for Linux 6.6, and remove it entirely in 6.7 if all goes well. Thoughts? Patch #4 probably needs the most review, and I'm open to other approaches if something else makes more sense! Thanks, Anna Anna Schumaker (5): NFSv4.2: Fix READ_PLUS smatch warnings NFSv4.2: Fix READ_PLUS size calculations NFSv4.2: Rework scratch handling for READ_PLUS (again) SUNRPC: kmap() the xdr pages during decode NFS: Enable the READ_PLUS operation by default fs/nfs/Kconfig | 6 ++---- fs/nfs/internal.h | 1 + fs/nfs/nfs42.h | 1 + fs/nfs/nfs42xdr.c | 17 +++++++++++------ fs/nfs/nfs4proc.c | 13 +------------ fs/nfs/read.c | 10 ++++++++++ include/linux/sunrpc/xdr.h | 2 ++ net/sunrpc/clnt.c | 1 + net/sunrpc/svc.c | 2 ++ net/sunrpc/xdr.c | 17 ++++++++++++++++- 10 files changed, 47 insertions(+), 23 deletions(-) -- 2.41.0