Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b2663a92-7947-d528-b852-fab3552ea867@redhat.com>
Date:   Mon, 17 Jul 2023 17:49:12 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH nfs-utils] start-statd: Fix shellcheck warnings
Content-Language: en-US
To:     Salvatore Bonaccorso <carnil@debian.org>, NeilBrown <neilb@suse.de>
Cc:     linux-nfs@vger.kernel.org, Ben Hutchings <benh@debian.org>
References: <20230709072028.829990-1-carnil@debian.org>
From:   Steve Dickson <steved@redhat.com>
In-Reply-To: <20230709072028.829990-1-carnil@debian.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/9/23 3:20 AM, Salvatore Bonaccorso wrote:
> From: Ben Hutchings <benh@debian.org>
> 
> shellcheck currently complains:
> 
> In utils/statd/start-statd line 14:
>         [ 1`cat /run/rpc.statd.pid` -gt 1 ] &&
>            ^----------------------^ SC2046 (warning): Quote this to prevent word splitting.
>            ^----------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
> 
> Did you mean:
>         [ 1$(cat /run/rpc.statd.pid) -gt 1 ] &&
> 
> In utils/statd/start-statd line 15:
>         kill -0 `cat /run/rpc.statd.pid` > /dev/null 2>&1
>                 ^----------------------^ SC2046 (warning): Quote this to prevent word splitting.
>                 ^----------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
> 
> Did you mean:
>         kill -0 $(cat /run/rpc.statd.pid) > /dev/null 2>&1
> 
> Use quotes and $() as recommended.
> 
> Signed-off-by: Ben Hutchings <benh@debian.org>
> Signed-off-by: Salvatore Bonaccorso <carnil@debian.org>
Committed (tag: nfs-utils-2-6-4-rc3)

steved.
> ---
>   utils/statd/start-statd | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/utils/statd/start-statd b/utils/statd/start-statd
> index 2baf73c385cf..b11a7d91a7f6 100755
> --- a/utils/statd/start-statd
> +++ b/utils/statd/start-statd
> @@ -11,8 +11,8 @@ exec 9> /run/rpc.statd.lock
>   flock -e 9
>   
>   if [ -s /run/rpc.statd.pid ] &&
> -       [ 1`cat /run/rpc.statd.pid` -gt 1 ] &&
> -       kill -0 `cat /run/rpc.statd.pid` > /dev/null 2>&1
> +       [ "1$(cat /run/rpc.statd.pid)" -gt 1 ] &&
> +       kill -0 "$(cat /run/rpc.statd.pid)" > /dev/null 2>&1
>   then
>       # statd already running - must have been slow to respond.
>       exit 0