Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Benjamin Coddington <bcodding@redhat.com>
To:     Kinglong Mee <kinglongmee@gmail.com>
Cc:     Anna Schumaker <anna@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Trond Myklebust <trondmy@hammerspace.com>
Subject: Re: [PATCH v2] nfs: fix redundant readdir request after get eof
Date:   Wed, 19 Jul 2023 09:24:45 -0400
Message-ID: <ECE48590-218F-4304-A043-B9AEB04CD3DA@redhat.com>
In-Reply-To: <CAB6yy374gQmrAjtLmFWGDVq9GBfxFoA-L95oELo=k+W9TF7cyg@mail.gmail.com>
References: <CAB6yy374gQmrAjtLmFWGDVq9GBfxFoA-L95oELo=k+W9TF7cyg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 18 Jul 2023, at 8:44, Kinglong Mee wrote:

> When a directory contains 17 files (except . and ..), nfs client sends
> a redundant readdir request after get eof.
>
> A simple reproduce,
> At NFS server, create a directory with 17 files under exported director=
y.
>  # mkdir test
>  # cd test
>  # for i in {0..16}  ; do touch $i; done
>
> At NFS client, no matter mounting through nfsv3 or nfsv4,
> does ls (or ll) at the created test directory.
>
> A tshark output likes following (for nfsv4),
>
>  # tshark -i eth0 tcp port 2049 -Tfields -e ip.src -e ip.dst -e nfs -e
> nfs.cookie4
>
> srcip   dstip   SEQUENCE, PUTFH, READDIR        0
> dstip   srcip   SEQUENCE PUTFH READDIR
> 909539109313539306,2108391201987888856,2305312124304486544,256633545246=
3141496,2978225129081509984,4263037479923412583,4304697173036510679,46667=
03455469210097,4759208201298769007,4776701232145978803,533840847851208126=
2,5949498658935544804,5971526429894832903,6294060338267709855,65288405662=
29532529,8600463293536422524,9223372036854775807
> srcip   dstip
> srcip   dstip   SEQUENCE, PUTFH, READDIR        9223372036854775807
> dstip   srcip   SEQUENCE PUTFH READDIR
>
> The READDIR with cookie 9223372036854775807(0x7FFFFFFFFFFFFFFF) is
> redundant.
>
> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>

Weird, I never got a copy from linux-nfs.   The plain-text version of thi=
s
is whitespace damaged, but the HTML version looks right.

Reviewed-by: Benjamin Coddington <bcodding@redhat.com>

Ben