Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6901cae4-a257-62dd-64fa-b4f201fc1b07@gmail.com>
Date:   Thu, 20 Jul 2023 09:14:24 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From:   Kinglong Mee <kinglongmee@gmail.com>
Subject: Re: [PATCH v2] nfs: fix redundant readdir request after get eof
To:     Anna Schumaker <anna@kernel.org>,
        Benjamin Coddington <bcodding@redhat.com>
Cc:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Trond Myklebust <trondmy@hammerspace.com>
References: <CAB6yy374gQmrAjtLmFWGDVq9GBfxFoA-L95oELo=k+W9TF7cyg@mail.gmail.com>
 <ECE48590-218F-4304-A043-B9AEB04CD3DA@redhat.com>
Content-Language: en-US
In-Reply-To: <ECE48590-218F-4304-A043-B9AEB04CD3DA@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/7/19 9:24 PM, Benjamin Coddington wrote:
> On 18 Jul 2023, at 8:44, Kinglong Mee wrote:
> 
>> When a directory contains 17 files (except . and ..), nfs client sends
>> a redundant readdir request after get eof.
>>
>> A simple reproduce,
>> At NFS server, create a directory with 17 files under exported directory.
>>  # mkdir test
>>  # cd test
>>  # for i in {0..16}  ; do touch $i; done
>>
>> At NFS client, no matter mounting through nfsv3 or nfsv4,
>> does ls (or ll) at the created test directory.
>>
>> A tshark output likes following (for nfsv4),
>>
>>  # tshark -i eth0 tcp port 2049 -Tfields -e ip.src -e ip.dst -e nfs -e
>> nfs.cookie4
>>
>> srcip   dstip   SEQUENCE, PUTFH, READDIR        0
>> dstip   srcip   SEQUENCE PUTFH READDIR
>> 909539109313539306,2108391201987888856,2305312124304486544,2566335452463141496,2978225129081509984,4263037479923412583,4304697173036510679,4666703455469210097,4759208201298769007,4776701232145978803,5338408478512081262,5949498658935544804,5971526429894832903,6294060338267709855,6528840566229532529,8600463293536422524,9223372036854775807
>> srcip   dstip
>> srcip   dstip   SEQUENCE, PUTFH, READDIR        9223372036854775807
>> dstip   srcip   SEQUENCE PUTFH READDIR
>>
>> The READDIR with cookie 9223372036854775807(0x7FFFFFFFFFFFFFFF) is
>> redundant.
>>
>> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
> 
> Weird, I never got a copy from linux-nfs.   The plain-text version of this
> is whitespace damaged, but the HTML version looks right.
> 
> Reviewed-by: Benjamin Coddington <bcodding@redhat.com>

Anna,

Sometimes my email client cannot send email correctly,
so I send this path at web gmail.

Are you OK for this HTML version?
If not, I will resend it through my email client. 

thanks,
Kinglong Mee