Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp9831694rwp; Thu, 20 Jul 2023 10:16:15 -0700 (PDT) X-Google-Smtp-Source: APBJJlEExbzGJcr8qMC6j1LTT1QwTb26qTfkA1bAKaTJqL3TJhgc1MGKh/9plgflfF8RpFcu3+Ym X-Received: by 2002:a17:906:d9dc:b0:969:f433:9b54 with SMTP id qk28-20020a170906d9dc00b00969f4339b54mr5503266ejb.39.1689873374866; Thu, 20 Jul 2023 10:16:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689873374; cv=none; d=google.com; s=arc-20160816; b=iCsGob8u0y8bQVdXLXdUCgOHaHK4q9Z6UUJ5BSLmAd3fbFWQic6/wrplNqbcNbdIdA m+8bpcb9rqI+uLe1djeGepBUTA2HxTSAEuYiemXX2JkqTrqXdmTKkT517O3UNiuB24fg lm+J9gVDigePK8unPH047k9xUAyKYQkM0qn748ZXr787fCdI6Wfef+pS/Ukx4CXQWCd4 Bm9zDsP0V50SqiQj4RVxHwKb9BrTaFPjLYNdop7k0LPSs3TT0PXR9lGbEjSkEh0M0AW9 f8tJsST7HHqfl50mNv6aXwSoB2IMUvHhSydAKod9RTobhNkDECHli+mUUMDttiehggpl +7rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=rf54fJtTcxCN7XycZmLlr/YyYttA5IpYXVAqXzPUilU=; fh=fC++TG0DrgLurPQRe+Uz1O672zzbt+mHM1lwKz/MLC0=; b=SpVB7z2NspIA1yIzSoz2pRlJqK7sBW/vLYUQ76Dv2/oFI0eC399PCGlMv20QHcEA+1 Nxf/gcV817IHB98ZZOARt8Z3uirym/eq04/0jziQuYNmHTjUz7qLc6H2ChGeJm+fT5kP hSvM+PfeROP+nZQkLNGa3PEISUNmYDxxJTLQezCb9InEIbUer5JG366R/x6rt26FKXLW 8YzQzN6dC3jVsrCgfmxnJ1GjAreLO1nd7llyLNY2Hzlica/oeqrrIeGz+/0eHxxQBqc3 PVmFFC2PpDLgOJx+5H1Z9sYzEOtWQnFNkN+JgzdFNwQX3eEvr51Aw0qkUsz4nBFypSd8 XipQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=B7xrIBIH; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h13-20020a17090619cd00b00992e22a640csi885364ejd.547.2023.07.20.10.15.40; Thu, 20 Jul 2023 10:16:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=B7xrIBIH; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231458AbjGTQyR (ORCPT + 99 others); Thu, 20 Jul 2023 12:54:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230221AbjGTQyQ (ORCPT ); Thu, 20 Jul 2023 12:54:16 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B735D1715 for ; Thu, 20 Jul 2023 09:53:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689872014; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rf54fJtTcxCN7XycZmLlr/YyYttA5IpYXVAqXzPUilU=; b=B7xrIBIH9e9YECON1+fT39dIdZEsioyEygridpJzkq1QLJu8lxqhgBDzN5QZ7aqHdhjS9Z ioywrmppvGtX2SJsYEoro3QiBB57aOaAp7JUuGyNSQeEjRlgoJTYZMQQNDd1GPLuqyoQ4K tiGeBzRPW5D9SEPVACps7PkTApKTsiw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-505-9i4lpJrQOY-wfVKCgktb4A-1; Thu, 20 Jul 2023 12:53:30 -0400 X-MC-Unique: 9i4lpJrQOY-wfVKCgktb4A-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 31ADE800159; Thu, 20 Jul 2023 16:53:30 +0000 (UTC) Received: from [192.168.37.1] (unknown [10.22.50.6]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 52B5D4A9004; Thu, 20 Jul 2023 16:53:27 +0000 (UTC) From: Benjamin Coddington To: Fedor Pchelkin Cc: Trond Myklebust , Anna Schumaker , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Khoroshilov , lvc-project@linuxtesting.org, stable@vger.kernel.org Subject: Re: [PATCH] NFSv4/pnfs: minor fix for cleanup path in nfs4_get_device_info Date: Thu, 20 Jul 2023 12:53:26 -0400 Message-ID: In-Reply-To: <20230720153753.20497-1-pchelkin@ispras.ru> References: <20230720153753.20497-1-pchelkin@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On 20 Jul 2023, at 11:37, Fedor Pchelkin wrote: > It is an almost improbable error case but when page allocating loop in > nfs4_get_device_info() fails then we should only free the already > allocated pages, as __free_page() can't deal with NULL arguments. > > Found by Linux Verification Center (linuxtesting.org). > > Cc: stable@vger.kernel.org > Signed-off-by: Fedor Pchelkin This looks correct to me. Reviewed-by: Benjamin Coddington Ben