Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <e655db6f-471b-4184-8907-0551e909acbb@moroto.mountain>
In-Reply-To: <e655db6f-471b-4184-8907-0551e909acbb@moroto.mountain>
From:   Anna Schumaker <anna@kernel.org>
Date:   Fri, 21 Jul 2023 13:28:37 -0400
Message-ID: <CAFX2JfmdpaRWbBypM+Xd4omd86mAbMNQ79+=xAtJXNjip95Sag@mail.gmail.com>
Subject: Re: [PATCH] nfs/blocklayout: Use the passed in gfp flags
To:     Dan Carpenter <dan.carpenter@linaro.org>
Cc:     Christoph Hellwig <hch@lst.de>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Jens Axboe <axboe@kernel.dk>, Jack Wang <jinpu.wang@ionos.com>,
        Dave Chinner <dchinner@redhat.com>,
        Hannes Reinecke <hare@suse.de>,
        Christian Brauner <brauner@kernel.org>,
        linux-nfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Dan,

On Fri, Jul 21, 2023 at 10:58=E2=80=AFAM Dan Carpenter <dan.carpenter@linar=
o.org> wrote:
>
> This allocation should use the passed in GFP_ flags instead of
> GFP_KERNEL.  All the callers that I reviewed passed GFP_KERNEL as the
> allocation flags so this might not affect runtime, but it's still worth
> cleaning up.

If all the callers are passing GFP_KERNEL anyway, then can we instead
remove the gfp_mask argument from these functions?

Anna

>
> Fixes: 5c83746a0cf2 ("pnfs/blocklayout: in-kernel GETDEVICEINFO XDR parsi=
ng")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>  fs/nfs/blocklayout/dev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfs/blocklayout/dev.c b/fs/nfs/blocklayout/dev.c
> index 70f5563a8e81..65cbb5607a5f 100644
> --- a/fs/nfs/blocklayout/dev.c
> +++ b/fs/nfs/blocklayout/dev.c
> @@ -404,7 +404,7 @@ bl_parse_concat(struct nfs_server *server, struct pnf=
s_block_dev *d,
>         int ret, i;
>
>         d->children =3D kcalloc(v->concat.volumes_count,
> -                       sizeof(struct pnfs_block_dev), GFP_KERNEL);
> +                       sizeof(struct pnfs_block_dev), gfp_mask);
>         if (!d->children)
>                 return -ENOMEM;
>
> @@ -433,7 +433,7 @@ bl_parse_stripe(struct nfs_server *server, struct pnf=
s_block_dev *d,
>         int ret, i;
>
>         d->children =3D kcalloc(v->stripe.volumes_count,
> -                       sizeof(struct pnfs_block_dev), GFP_KERNEL);
> +                       sizeof(struct pnfs_block_dev), gfp_mask);
>         if (!d->children)
>                 return -ENOMEM;
>
> --
> 2.39.2
>