Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
From:   "NeilBrown" <neilb@suse.de>
To:     "YueHaibing" <yuehaibing@huawei.com>
Cc:     chuck.lever@oracle.com, jlayton@kernel.org, kolga@netapp.com,
        Dai.Ngo@oracle.com, tom@talpey.com,
        trond.myklebust@hammerspace.com, anna@kernel.org,
        yuehaibing@huawei.com, linux-nfs@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] sunrpc: Remove unused extern declarations
In-reply-to: <20230722033116.17988-1-yuehaibing@huawei.com>
References: <20230722033116.17988-1-yuehaibing@huawei.com>
Date:   Mon, 24 Jul 2023 15:08:59 +1000
Message-id: <169017533908.11078.1160756498004010060@noble.neil.brown.name>
Precedence: bulk

On Sat, 22 Jul 2023, YueHaibing wrote:
> Since commit 49b28684fdba ("nfsd: Remove deprecated nfsctl system call and =
related code.")
> these declarations are unused, so can remove it.
>=20
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Thanks.
Could you remove the declaration of auth_unix_lookup too?
It was removed in that commit, but the declaration is still with us.

Thanks!
NeilBrown

> ---
>  include/linux/sunrpc/svcauth.h | 2 --
>  1 file changed, 2 deletions(-)
>=20
> diff --git a/include/linux/sunrpc/svcauth.h b/include/linux/sunrpc/svcauth.h
> index 6d9cc9080aca..2402b7ca5d1a 100644
> --- a/include/linux/sunrpc/svcauth.h
> +++ b/include/linux/sunrpc/svcauth.h
> @@ -157,11 +157,9 @@ extern void	svc_auth_unregister(rpc_authflavor_t flavo=
r);
> =20
>  extern struct auth_domain *unix_domain_find(char *name);
>  extern void auth_domain_put(struct auth_domain *item);
> -extern int auth_unix_add_addr(struct net *net, struct in6_addr *addr, stru=
ct auth_domain *dom);
>  extern struct auth_domain *auth_domain_lookup(char *name, struct auth_doma=
in *new);
>  extern struct auth_domain *auth_domain_find(char *name);
>  extern struct auth_domain *auth_unix_lookup(struct net *net, struct in6_ad=
dr *addr);
> -extern int auth_unix_forget_old(struct auth_domain *dom);
>  extern void svcauth_unix_purge(struct net *net);
>  extern void svcauth_unix_info_release(struct svc_xprt *xpt);
>  extern int svcauth_unix_set_client(struct svc_rqst *rqstp);
> --=20
> 2.34.1
>=20
>=20