Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH -next] sunrpc: Remove unused extern declarations
To:     NeilBrown <neilb@suse.de>
CC:     <chuck.lever@oracle.com>, <jlayton@kernel.org>, <kolga@netapp.com>,
        <Dai.Ngo@oracle.com>, <tom@talpey.com>,
        <trond.myklebust@hammerspace.com>, <anna@kernel.org>,
        <linux-nfs@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230722033116.17988-1-yuehaibing@huawei.com>
 <169017533908.11078.1160756498004010060@noble.neil.brown.name>
From:   YueHaibing <yuehaibing@huawei.com>
Message-ID: <d8178e7c-d0ec-9e5d-9367-53f554e0392e@huawei.com>
Date:   Mon, 24 Jul 2023 14:45:07 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <169017533908.11078.1160756498004010060@noble.neil.brown.name>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/7/24 13:08, NeilBrown wrote:
> On Sat, 22 Jul 2023, YueHaibing wrote:
>> Since commit 49b28684fdba ("nfsd: Remove deprecated nfsctl system call and related code.")
>> these declarations are unused, so can remove it.
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> 
> Thanks.
> Could you remove the declaration of auth_unix_lookup too?
> It was removed in that commit, but the declaration is still with us.

Sure, will do this.
> 
> Thanks!
> NeilBrown
> 
>> ---
>>  include/linux/sunrpc/svcauth.h | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/include/linux/sunrpc/svcauth.h b/include/linux/sunrpc/svcauth.h
>> index 6d9cc9080aca..2402b7ca5d1a 100644
>> --- a/include/linux/sunrpc/svcauth.h
>> +++ b/include/linux/sunrpc/svcauth.h
>> @@ -157,11 +157,9 @@ extern void	svc_auth_unregister(rpc_authflavor_t flavor);
>>  
>>  extern struct auth_domain *unix_domain_find(char *name);
>>  extern void auth_domain_put(struct auth_domain *item);
>> -extern int auth_unix_add_addr(struct net *net, struct in6_addr *addr, struct auth_domain *dom);
>>  extern struct auth_domain *auth_domain_lookup(char *name, struct auth_domain *new);
>>  extern struct auth_domain *auth_domain_find(char *name);
>>  extern struct auth_domain *auth_unix_lookup(struct net *net, struct in6_addr *addr);
>> -extern int auth_unix_forget_old(struct auth_domain *dom);
>>  extern void svcauth_unix_purge(struct net *net);
>>  extern void svcauth_unix_info_release(struct svc_xprt *xpt);
>>  extern int svcauth_unix_set_client(struct svc_rqst *rqstp);
>> -- 
>> 2.34.1
>>
>>
> 
> .
>