Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 24 Jul 2023 09:25:50 -0400
From:   Chuck Lever <chuck.lever@oracle.com>
To:     YueHaibing <yuehaibing@huawei.com>
Cc:     NeilBrown <neilb@suse.de>, jlayton@kernel.org, kolga@netapp.com,
        Dai.Ngo@oracle.com, tom@talpey.com,
        trond.myklebust@hammerspace.com, anna@kernel.org,
        linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] sunrpc: Remove unused extern declarations
Message-ID: <ZL573hzgHEfp+gbb@tissot.1015granger.net>
References: <20230722033116.17988-1-yuehaibing@huawei.com>
 <169017533908.11078.1160756498004010060@noble.neil.brown.name>
 <d8178e7c-d0ec-9e5d-9367-53f554e0392e@huawei.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d8178e7c-d0ec-9e5d-9367-53f554e0392e@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?w4FoucZbAFPP+sAbrK1GdAZ3mEn1UwhvtjstQqhnpybWoMi5Qh3mQzUsbbBG?=
 =?us-ascii?Q?+QQThvpbSbQvOld0ETKvOLlkZYQJnrit1qP7BR0i0zTkWJJwvcZD07GQ+xCt?=
 =?us-ascii?Q?U371HQoFYc2dEdsAwR8w/lyhcCRi5/FyQmrMX6GsEuRHLumDhIIIKjTPwd+L?=
 =?us-ascii?Q?V2lD1wXSUSKmEW0YGDICB91d8L7jLpvpS59naBeR1pJu5aiRJm1aXhDT6EqZ?=
 =?us-ascii?Q?7w2xz/85CVpm/tyU74RMXci5vvC8lDz+1HEUCK7vNpNEbnBFlOODDbUj9kZk?=
 =?us-ascii?Q?+JmYxLCdBTJogMbqbElBGJVjWErAj+9BRcd1fLsixKVxA9l09L+JD49KpVg7?=
 =?us-ascii?Q?lz1PoifTa3ZdGLpCM/s0XLgVOV72Nb9o+xXylnAa1x2yR2LLkAWBD5qkKyrT?=
 =?us-ascii?Q?jhBpyDbY1vL7eqp0a3jIRuXBQym9MfQ8AjnQ13DVufpb4A4FEBYXBgTa+fVK?=
 =?us-ascii?Q?XnUHT9fX2dzvHKedVzP30Ky7QXE+tRdF0HtUH4WxZYf46kH1q9ZfOCKoeKoc?=
 =?us-ascii?Q?rMrG9to1T73whNYOzneiGRA+rlKcqnpCTVz3KsBIxf5LD0J7L0chBzQ/IV12?=
 =?us-ascii?Q?vOq98CrOvCBHmtanIm60Kfzee7IVwSgA0FalOZ2xjjrz3sXbqVTw/4CmWCRc?=
 =?us-ascii?Q?cCf4w6UDc0UrfMcXyjq1qPBlRt5bg+9CuOErhl2fUxnbpfjkvKvTBZ5XIJme?=
 =?us-ascii?Q?3vgwR23wjB5GLH0DxG0cs44Udsd57z3GrU8sA2Jjtf2cSGMnB/wAqWYJ1E9E?=
 =?us-ascii?Q?vYEPkzt1+am7MZEMLQQjfNwxlQAuFWpEz7Q3y3/uoZo8CzkuaOzT/kzVLhb4?=
 =?us-ascii?Q?7AbZTuvd5ajGkH3ku0j41xXzUS+hYO1X6WVvK+UFZoj+STforkyBdxS5kG4R?=
 =?us-ascii?Q?sNurJLESd4keu8KvjxW94Y1XqPi6cvGsKam2c7RDVmiSt81rlW7dqDkbSpnq?=
 =?us-ascii?Q?t3b08u3NeKPPK1mgvHjYTvl2lXD7JUJD585a6JfVWf7YVG2/JedXu/iFuOjG?=
 =?us-ascii?Q?/kMjq7oJDOzzjri9j+gDE/9TNhEzWP7k7XNf4tq2zgjBNLyO4sd+yZ5DPEk3?=
 =?us-ascii?Q?6eXomaZPMITOyP+zeIrbAPeM2HQIT9JEUKrekkrMAgNF9HYA8IaGEC0XzCHm?=
 =?us-ascii?Q?j3DE0eENcvMJL4rPyNvcI+dRncI9Q46aAyX7my9nJtJLcro9aBi4wtZMsesa?=
 =?us-ascii?Q?l3SR/mRR4KM9O5ma9c2zL3gkWjeL/GQQDIERiGXk7c+Lwz7Cwvrl1xbtfikt?=
 =?us-ascii?Q?r+D5wFeWV5DjCCBUaog6Ysh9OMc1unXsuufa+mtLKf/yCmuMQ0TzLRp9eZPq?=
 =?us-ascii?Q?tQix2IoQCkxXXBpJieRqAtAKX5HY1WJ/t1uFIa21RKXvEnJG2NmM/WeiD9cO?=
 =?us-ascii?Q?mUVhMbk0reurKnTaTioZOkvE460KOrXbu+oQFbJuNxYMLNP3AuUB0eYxRTE9?=
 =?us-ascii?Q?PgPIpQHXQIGSF0KR7xOefuvt451i9Pa+iH3KqFoKCVojvp0VgvpG09Id8B6X?=
 =?us-ascii?Q?J9NiVgGUEowxrMwyzj1wUYnn+8Igz8oFBA1rh2bP9cIjVDrf36G684wjegi/?=
 =?us-ascii?Q?VvGFUDSfn+xvpuLPbaqbJbojzOr3tpo4ws0YGt3B?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?Kcn0n9z/8a6iv3BY3Qlu06/o/vm57mUtDrsWIVeEYx4ER3WzGgVokaahxgRr?=
 =?us-ascii?Q?yveR6KR1zzvDgpPHa9qubvJMT3sMxK1kPEesMhw+jzWxDvA4uwHt6zEGAnrm?=
 =?us-ascii?Q?Pk3fogDZ3KLL//eD8sEsrdS4lrRWR/wi2Mj70M1O78UL5lCDbwnJz3rTH+p9?=
 =?us-ascii?Q?GV8BFrK+G0r/jmYIRDrqv3nsQzEK3w+U9lHcKXiIScoVsDu5G/CWKLBn6vYr?=
 =?us-ascii?Q?ajS553De9QI46jj/u+Sjg6pL/ERPwYr8WST8/2bzi8xxmUAAlIKY7Z+yCBuk?=
 =?us-ascii?Q?FSsMumwWPKhBrgH5WmEnB5W2Ph8LCoVfxf+Ey0gRJSYagZAPLk/6XuUC9+Mn?=
 =?us-ascii?Q?9AjmBRvglocyWxD1QgzY9maM9KA24Or3bTlToOuBbQMsgCdeL3Qo2gGrh2/5?=
 =?us-ascii?Q?CV8nHlz3a6bHeBmxqE8fk60bCBhhnfFarCirw6XbgvDrf0xoF3ehnM6U05xK?=
 =?us-ascii?Q?5jYipq5uo8egLAbftV6icIQDLLsLh+sR2VohOA+ouTsP0g6PxQptcjkXTH6D?=
 =?us-ascii?Q?v4Zcc6sPc3s3dcWYnKEN7B+BtxGjOlhqHXBUegHCQoTX9Fr+3mfxqy8iSUI5?=
 =?us-ascii?Q?d/GqNzfF2IgOq7IDdf0jXRL7RlSHob6eu9bssbFuOE34Y4tEUHXorMKkeQ0L?=
 =?us-ascii?Q?j7hzWlKTbiV19W/KwvD5EsDd4kgm/xbOt2zwzzpK32DNGiIdX+bpUzDXAq6I?=
 =?us-ascii?Q?i9Fh9RukLEmhunI2Byu1+6kqPaUXyno9SyHow/vWSt4TC3kmrHTYzYd/Add9?=
 =?us-ascii?Q?PoacbsaRZ4QDzhSAZtAWbvc+b2fPyzpHdkErY4+3geGN3542tuQ8UeqK/l9P?=
 =?us-ascii?Q?kGMFdLJ65kjd/f0jTRcwF/ZpxLT0w8ma482ErKOwvKnwJwNSWWDRvIoLG7ET?=
 =?us-ascii?Q?YFNYIZqwHElSKavKTaMSHPIwqsZmGLboCpaqgPT6gT8LHpphefF2d8/CepCi?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c33d3849-d8d3-4c0c-1083-08db8c498313
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2023 13:25:56.4677
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9OX/TJtmhIm3/cyRn6RBlucCEE3S4XcRDxaSJGWw3VSqotirQGEDtbfVEZGTd/7ffa02TJUDu5xUM0ed2hBjvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4406
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-24_10,2023-07-24_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0
 phishscore=0 mlxlogscore=828 malwarescore=0 mlxscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000
 definitions=main-2307240119
X-Proofpoint-ORIG-GUID: AILO1Ag43qzme2ifdlpdBRpIoEYKOYJI
X-Proofpoint-GUID: AILO1Ag43qzme2ifdlpdBRpIoEYKOYJI
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On Mon, Jul 24, 2023 at 02:45:07PM +0800, YueHaibing wrote:
> On 2023/7/24 13:08, NeilBrown wrote:
> > On Sat, 22 Jul 2023, YueHaibing wrote:
> >> Since commit 49b28684fdba ("nfsd: Remove deprecated nfsctl system call and related code.")
> >> these declarations are unused, so can remove it.
> >>
> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > 
> > Thanks.
> > Could you remove the declaration of auth_unix_lookup too?
> > It was removed in that commit, but the declaration is still with us.

Thanks, Neil. I thought there might be one or two others, but none stood
out to me.


> Sure, will do this.

Yue, I can just fold that into the applied patch. No need to send another.


> > Thanks!
> > NeilBrown
> > 
> >> ---
> >>  include/linux/sunrpc/svcauth.h | 2 --
> >>  1 file changed, 2 deletions(-)
> >>
> >> diff --git a/include/linux/sunrpc/svcauth.h b/include/linux/sunrpc/svcauth.h
> >> index 6d9cc9080aca..2402b7ca5d1a 100644
> >> --- a/include/linux/sunrpc/svcauth.h
> >> +++ b/include/linux/sunrpc/svcauth.h
> >> @@ -157,11 +157,9 @@ extern void	svc_auth_unregister(rpc_authflavor_t flavor);
> >>  
> >>  extern struct auth_domain *unix_domain_find(char *name);
> >>  extern void auth_domain_put(struct auth_domain *item);
> >> -extern int auth_unix_add_addr(struct net *net, struct in6_addr *addr, struct auth_domain *dom);
> >>  extern struct auth_domain *auth_domain_lookup(char *name, struct auth_domain *new);
> >>  extern struct auth_domain *auth_domain_find(char *name);
> >>  extern struct auth_domain *auth_unix_lookup(struct net *net, struct in6_addr *addr);
> >> -extern int auth_unix_forget_old(struct auth_domain *dom);
> >>  extern void svcauth_unix_purge(struct net *net);
> >>  extern void svcauth_unix_info_release(struct svc_xprt *xpt);
> >>  extern int svcauth_unix_set_client(struct svc_rqst *rqstp);
> >> -- 
> >> 2.34.1
> >>
> >>
> > 
> > .
> > 

-- 
Chuck Lever