Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
From:   "NeilBrown" <neilb@suse.de>
To:     "Chuck Lever" <chuck.lever@oracle.com>
Cc:     "Chuck Lever" <cel@kernel.org>,
        "David Howells" <dhowells@redhat.com>,
        "Jeff Layton" <jlayton@kernel.org>,
        "Hugh Dickins" <hughd@google.com>, "Jens Axboe" <axboe@kernel.dk>,
        "Matthew Wilcox" <willy@infradead.org>, linux-nfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] nfsd: Fix reading via splice
In-reply-to: <ZMaB1BwBfNko1ZoE@tissot.1015granger.net>
References: <169054754615.3783.11682801287165281930.stgit@klimt.1015granger.net>,
 <169058849828.32308.14965537137761913794@noble.neil.brown.name>,
 <ZMaB1BwBfNko1ZoE@tissot.1015granger.net>
Date:   Mon, 31 Jul 2023 08:02:29 +1000
Message-id: <169075454985.32308.7692478577605440938@noble.neil.brown.name>
Precedence: bulk

On Mon, 31 Jul 2023, Chuck Lever wrote:
> 
> I'd like to apply David's fix as-is, unless it's truly broken or
> someone has a better quick solution.
> 

Your reasoning is sound.  From a behavioural perspective (though not
from a maintenance perspective) the patch is no worse than the current
code, so
   Reviewed-by: NeilBrown <neilb@suse.de>

NeilBrown