Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Neil Brown <neilb@suse.de>
CC:     Jeff Layton <jlayton@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 06/14] SUNRPC: change various server-side #defines to enum
Thread-Topic: [PATCH 06/14] SUNRPC: change various server-side #defines to
 enum
Thread-Index: AQHZuUKeUhPN688TTEazI3MFmgB5Iq+/h5sAgBMC4QCAAHUGgIAAAEOA
Date:   Sun, 30 Jul 2023 22:57:10 +0000
Message-ID: <F63A3F6B-D661-4545-AF4B-FE3A861305F9@oracle.com>
References: <168966227838.11075.2974227708495338626.stgit@noble.brown>
 <168966228863.11075.8173252015139876869.stgit@noble.brown>
 <ZLaVtpLf1k2Ig5Kz@bazille.1015granger.net>
 <ZMaIWPyEm83GaS0q@tissot.1015granger.net>
 <169075776306.32308.3045406213067424206@noble.neil.brown.name>
In-Reply-To: <169075776306.32308.3045406213067424206@noble.neil.brown.name>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JmA64fopnmhD+mkBscnO46G0p8EWKCi74L4uZ1WKU+/B+/X9qVinRPSfv/M2?=
 =?us-ascii?Q?VwBJ7xZJBpsk5pzjMyGREzyfS6VfUIAaTzjCBBBJZZyrLAiH3v0KWJp0Y8up?=
 =?us-ascii?Q?dW+4+K4qeHG7f0qHpKPihX3Q9AEagjmwsljZ3hWN7n1RWW/pBqO8IJwGPW0f?=
 =?us-ascii?Q?cESLvMgv1mFCC05vWm8np5IDpmS7jvSfgNqL92PtUa8xpMYSVROny0iSmPja?=
 =?us-ascii?Q?L3lOdVWI50GGPeSt2+MrPqj5O8q0gR1UGn6Nxu3K42Uyski9AE2cE9+ngsbk?=
 =?us-ascii?Q?Pk9AIlX4LXIAGczY8OB2ZSsCBXTcCVmFQ3aAtp7jzizr0CMY/M39O7+JM5dF?=
 =?us-ascii?Q?ndsa1UUY5unNhAnxQa/NdDZzKpXybIBdWlVCUvH0dcp8IDTxMtL/zSrmK0sL?=
 =?us-ascii?Q?6WcwZb0NpmLk1TNeYZ5uIlRryt9Rkc9Vmn2QMx2fIQLmzCHe9mwNHU8OeFSr?=
 =?us-ascii?Q?rNHJtOOmq89SXsMr4zpv26nXGRMyTwx/eHsC2nEJujpZUjwpNA731ZOcDh86?=
 =?us-ascii?Q?4euwcGp64TksXs2gOb+CNPPOiapGz9yJkoeKCMLGLroKliAOBxbjrJqDllH9?=
 =?us-ascii?Q?mzEgeRD8Hes3PYHw6q/iNVmYbLXcFHgb+uRq4FF4Ili8V3ovAhsaJEp0u9c+?=
 =?us-ascii?Q?K+38ibfqQc1YvsAQrpPIf/GtEEaxX2qjrB6gywKHGc8y/nFSMLmfk83s4N24?=
 =?us-ascii?Q?g6OfCsEgwpGtY/6+RwXfCvhoiPifCMen6wObrChccbCIeNaSmiB56eIyw5Tz?=
 =?us-ascii?Q?Anf4wC2N8wxyN68G1jYFY/Aj60QkHovxdF05r/nvHqmMB9akdA8xZYpNyLoU?=
 =?us-ascii?Q?s2WCNDxlw1M/5+orli58eiRYJrT3YbuiYdA+eAfR62Y7/hz+dIea8y96oHwY?=
 =?us-ascii?Q?TJyua3YLV7MYXX7wRQxXgzpdXHZZGq0qx+E6rzZ/mLyz8x0JkgEJy9V4OLb7?=
 =?us-ascii?Q?SBMpxlI1QPNY6UWinrs5+7ps2rmZW7Tpr9GCdIOv8Dx/n+OdMXAwaVwfAkLB?=
 =?us-ascii?Q?gP085QlzolLLhwio0ymI/rvCQlKX+GRMlUvULlsiU1JzUXSvCRiaB8NDwU89?=
 =?us-ascii?Q?nqhU+eg1zK2EMDtmHHfF5FJrSeSO/C+KL+5rkgWPu3tvcUQhDcI/S10RbJ1T?=
 =?us-ascii?Q?N4Kl8KJvo/0Of6uh7DW1xjdyG95fHydQ/OJcshFp1SsRmGWeAiHZkU8TGx4R?=
 =?us-ascii?Q?/uXcflVUTOVUj3Q3wDQDpJ0vJPJSOXiEoGY9nDVrU0y+aXaZnvj5dAyH0+/J?=
 =?us-ascii?Q?/Slb36SWd/96o1/6z10xeT/fGYCsBsVuRnCz7HyIAdPn1CLXUMxH59mRlyK7?=
 =?us-ascii?Q?X9MIda5hieAV29KqAuLbbXhMGda6LP3f7zmYSEnrqZp5kRppY8iCCBu86koG?=
 =?us-ascii?Q?8RDRuwL0Kn+6wEcKVFpugdrzv/IunAlEPm2vq1JjXTZbxZaaUpiAMyeGyC/W?=
 =?us-ascii?Q?bUVhw1sbe2bBJFzbZJqUsGwKOr2SZz8yu8vzEw21HNyxxuWobirXR0mNeKJl?=
 =?us-ascii?Q?dNjadQFWyRcREWQBHSeHtaJrQdg9F1SFOLVuZyLThx1mh0kLbwhrAn3Y4pZn?=
 =?us-ascii?Q?GP5K3v9u3wnFJCg3UvXL7KY5/n5bbWO1QbUesFNv6V/tXaLuzcGVTVErCrP9?=
 =?us-ascii?Q?kA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4BA7829D0A4CEA409571A3E8CC9FCBD7@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: CJFh3wfDsSju5TMREIlpGAJlycK3FDW1u4D/8DTRztlQZy75RvUosOnj/Ti4VqADqkZ32mO1h6hS8qeeq8xaxNUD9BC8Ztb4ez85n73x5O91ak1fVo9WefWeFZ31hrGOKk1bY8OkK509bpkISCIPKPUCVFVP/decD97L56Slvgw3/+JUJGUZrnpp0reV/vpgCQusWpcj2lPtsT/GeCq4rTw7p9/SbgYBNI8xQM9ev/09Blbk0zBCLRZL3rM4cjM/tzZ1MyV/za2wYAZt3AXwbC2bBNr6R5WwOB7kVIRZD+VqUyEbDaU1JBeeMV8+oxF000pz7AGjxuF5k+/DE5OBDq1lP+uYBWw+i9XM9frMK8S/BkEawU/MHarP7zUEG/14o7s6viRDWscaid2mibQSdvl692q1PbpRzh3ujB8XNwyKOJBioj7mpg6hegp7eGTY+boQog/3x76lbjKWaapGBMWhUdiDRTNaQxwrgGV9guL8wc0WATpg1oHC+lmf/wa5LxmaNHIP2pj9xgsYJPXOz8ERZWw65Ub4ajVHQVktHGR+mXSHrFiFsmPXg98cEbBEtK+w77qbIDSBhpZl6QQMY3Chb1iH5RRqZSIx27XphprYhvpOvT6vmcinpsPQfojf9/HYQzg3V1UgoycJtkiDM2AyRud1r2SAN3dqhjOjBwKoHqYthnb5XnNDAkKO6wVU+ArHcGtzo3AQIQ+i6inqesKG7PoFYU2TS+sKD48bIf8XvxcnZvyu4qZS12r4Fku0ZatUs/eGV8FwhDdZLHoPvGl3osqr4UMlLkEivUJwcllNTHrBtJWyk+y+tQM5uLrV
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f367541-b1fd-4000-2237-08db91504e7b
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jul 2023 22:57:10.3135
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7nzpOLDfpdP8HdV4p73ONsljtpDM6w47ihOQczE7AaazrQmk6fq8Xr2di24PKm47e+Ggw3TncrhDTY9tQr1b/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4999
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-27_10,2023-07-26_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=757 malwarescore=0
 adultscore=0 bulkscore=0 suspectscore=0 spamscore=0 mlxscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2306200000 definitions=main-2307300214
X-Proofpoint-GUID: gG4wr5jOEgaTgnSt2rjvQS6XrCu9GfS7
X-Proofpoint-ORIG-GUID: gG4wr5jOEgaTgnSt2rjvQS6XrCu9GfS7
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Jul 30, 2023, at 6:56 PM, NeilBrown <neilb@suse.de> wrote:
>=20
> On Mon, 31 Jul 2023, Chuck Lever wrote:
>> On Tue, Jul 18, 2023 at 09:37:58AM -0400, Chuck Lever wrote:
>>> On Tue, Jul 18, 2023 at 04:38:08PM +1000, NeilBrown wrote:
>>>> When a sequence of numbers are needed for internal-use only, an enum i=
s
>>>> typically best.  The sequence will inevitably need to be changed one
>>>> day, and having an enum means the developer doesn't need to think abou=
t
>>>> renumbering after insertion or deletion.  The patch will be easier to
>>>> review.
>>>=20
>>> Last sentence needs to define the antecedant of "The patch".
>>=20
>> I've changed the last sentence in the description to "Such patches
>> will be easier ..."
>>=20
>> I've applied 1/5 through 5/5, with a few cosmetic changes, to the
>> SUNRPC threads topic branch. 6/6 needed more work:
>>=20
>> I've split this into one patch for each new enum.
>=20
> I don't see this in topic-sunrpc-thread-scheduling
> Commit 11a5027fd416 ("SUNRPC: change various server-side #defines to enum=
")
> contains 3 new enums, and the XPT_ and SVC_GARBAGE improvements you
> mention below cannot be found.

Still testing this.


>> The XPT_ flags change needed TRACE_DEFINE_ENUM macros to make
>> show_svc_xprt_flags() work properly. Added.
>>=20
>> The new enum for SVC_GARBAGE and friends... those aren't bit flags.
>> So I've made that a named enum so that it can be used for type-
>> checking function return values properly.
>>=20
>> I dropped the hunk that changes XPRT_SOCK_CONNECTING and friends.
>> That should be submitted separately to Anna and Trond.
>>=20
>> All this will appear in the nfsd repo later today.

--
Chuck Lever