Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Neil Brown <neilb@suse.de>
CC:     Jeff Layton <jlayton@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 06/14] SUNRPC: change various server-side #defines to enum
Thread-Topic: [PATCH 06/14] SUNRPC: change various server-side #defines to
 enum
Thread-Index: AQHZuUKeUhPN688TTEazI3MFmgB5Iq+/h5sAgBMC4QCAAHt6gA==
Date:   Sun, 30 Jul 2023 23:19:20 +0000
Message-ID: <39A12B38-C1D1-4112-8C91-CCFE329342D7@oracle.com>
References: <168966227838.11075.2974227708495338626.stgit@noble.brown>
 <168966228863.11075.8173252015139876869.stgit@noble.brown>
 <ZLaVtpLf1k2Ig5Kz@bazille.1015granger.net>
 <ZMaIWPyEm83GaS0q@tissot.1015granger.net>
In-Reply-To: <ZMaIWPyEm83GaS0q@tissot.1015granger.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5cohF81T/NCJMPPcyMgrZUtfRVmjPYs8XGgGynhWwMw41oFU82xgpjwL0VNv?=
 =?us-ascii?Q?4xuv4uwGMzjeZ955yPQ61B0lYwXstcdkQPif2Yunbv0RoYDRg66WRzTIdVNK?=
 =?us-ascii?Q?+0So3u7bwGpclsh5KWd7Y8u3YRZOSYrfWRRKva3AtccPb8uL7zB0W96c9f75?=
 =?us-ascii?Q?ZCeIKYL3Teg6LGA36RILJPJ24ZHbbp50kP0vjUwrQuOC+Yy4JSoAIln2Bz4n?=
 =?us-ascii?Q?mMVy83iLSGaiD4FbKbm88b7giPG0J4wlQ9fYDXq4BV/LKdqJtGiHZ8SDn84X?=
 =?us-ascii?Q?Pd2zX9bDbn2Q9XaSMk+w5XxemHjQzvJdo2gvPovQFYaheCEttUTs4CP2iLT9?=
 =?us-ascii?Q?h0q6hcrM7ypN0jpPA2RtlboUYHbt3v3nVc7BJI4TLkknyQgi4k8zLEW6cyf6?=
 =?us-ascii?Q?Qg5tzWVeYh/n4WeSHqlcDc5h29GhOXO58EVv4d+Ky/1fIytHsHxuLgozTRKP?=
 =?us-ascii?Q?JX8dCjWFrS5GBL9O/505u93b8SQ62FzCYxQ0ISQMKRXXnGFSxDi1HIJs8319?=
 =?us-ascii?Q?BY3k2k9T1/EXwckEKcfowc5nwQ6TNuKISAseKL2OtOuK5cd9cf0JsnMRDzzV?=
 =?us-ascii?Q?QmO6raBrpWYrb0OzXXvBqDw59NhFuFf4MHmWOsZgU4OmBCRdGRgseEuZ69ov?=
 =?us-ascii?Q?i3mMbzpFY9bFcIGbE0mb7drnM8rKXnU/4F9xasT7clkzchpTAn5CEMbGZC5u?=
 =?us-ascii?Q?HjCNFckv/U/H6qOCQHkzi9fmBMhXD23mYkCje7rtYemlNMoDVE1dk/KtT2Z6?=
 =?us-ascii?Q?SK0eBmnDiSzDl4yqkzb3zegwzLMimP15SUz8Vc9D/XanLhcvRdA51vovy5sQ?=
 =?us-ascii?Q?KuXSQkptanhl9L3hgPpXscH09yP6rlXr3qld88DiidV3XP+xwoW5fkV04sni?=
 =?us-ascii?Q?LbsSflvNKcZ2qPXsWNq2umKJcPn/KzhH0HiZWCP1FK15Bueidcpx9guJHQFt?=
 =?us-ascii?Q?0nGsJLaoIa4y6qhHMRNweIJIGovGokfZrUfFX2bjTFNEGPMqMPd0PFcyVEu+?=
 =?us-ascii?Q?AL3xFAUKVtDqUV1rm23MbC8TAgEsoFrjwbkt9KKLjNsX2VowyUz2f77je01d?=
 =?us-ascii?Q?00pNzHElHFdVw6xhKeez7CCqfWN00UrHglIcXGNNFk6fTbEVN5zom3bUxv8B?=
 =?us-ascii?Q?M1XdudMonfSvDHm47SucF/KW2ByfX64QUvrRn5xVFuYRH2VWYUrBMOzP4SUB?=
 =?us-ascii?Q?mgmQKA0HDyDgU5YSnDllkgFnYZwo9mT6Wmjewz0khFx0FDWU3U2bHsbErt6d?=
 =?us-ascii?Q?gk3M6Y3VTBUM9cmmZEIUzbI39g52XecRmBmuY7r2M28b3ue0RUEpX9l4TUnX?=
 =?us-ascii?Q?xwim97Z5bHrAMdzBVw2Q0Qk9UJrkwoaPpJU991KbqorkLm+7ZGXm4J19qSpI?=
 =?us-ascii?Q?qMu26in2sn7UiKGyCgvWyGqYM+NdBZ24/bp5cXJSXkwAAunE1xVk7B1PAk+c?=
 =?us-ascii?Q?XvMjHZVRjCMv1lZJu9FydEUeZpSHThjpMEiWOYN4uD4cYoxbbCUPzhRxI1OA?=
 =?us-ascii?Q?79aimfHR0U6MpbVDqdCm9Szv3TEnMFCzVJBw6zd/ZK3/B/CEnqbdc+vH8PoG?=
 =?us-ascii?Q?nWg9hAgbaOjIeaxKuItREk6otEHzFb30bJ9NqCG8P0lI7HeobpjV3H9RlF4J?=
 =?us-ascii?Q?vw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <87DDF24318BAF3498FC56ACEFCC25BD7@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: hASLCSl6Lrb9JXwyu4TxXF1YWaQSv/cwlqV/HfuCqa33zL98qzRH1biuXX70+My1Yf67jSZBCP2IUJattUe2WDMbDYYWgX4ImKy9nEZnPODeo9CvN/QqIFktFgPXwhZ1D/WuVCjUNde1INHn7/u0qEhctDk+zqWCkwEIxrfjO9Xo6NjHD+MdiAvwU86JN4sALgbTPZoOo/hwEOX0AJHnhhAK+9Vxs7NvVza9lfRz6CfeqUxZaytAqcayadIg1RUDGkuwixedHHvhOMMVuHyO85T5YKe1Hw7tCbyVP8a4a90ZeG/UeO3FSqnY8A0xaT9XIgNUpDrLQUSKZhDob2ctYxCOPS/H3cjgZItCTvR66h9X2FZ20wB35YmGtKEI42fDsThgGCXfr4zeHN1Fqvwvu4TAuED9CLKMG673zGyGby8LF7jPiAsHjZHMPze0XRTQW5AC6+AocCSAtXHhIghGnixHMAzUCBbKaEI4D2cnpEizVcmyVPa6RPzlhIsYJluhQ16hEtew5/hLSkSOs23HVhYnKkCxsMPGpt5SKR+PwyVS9Vq+D3zMos9oSyUkyG0PH1w4SiATbi6XYiaABhhYBaYP3nobrx0krxbsKu5QNbAijYpOtUn7UMyu+W+MkEABzgjUHWbjLh6z9+eLm+zB3OyEoQGeB+mSpW4k/mAtLV4ACmPYPRzwhmqGjgBfYoJ3jHuRq9fkOwejB0lSSAyYfFxVVAx8mY76i7GJyqsEQMnBZRpsKHOPVzhCCT9OyivzTbaBvc1/+W3sGTx7MU7qzrG2L+mINZ+uSSeNsqPsn4Qcm4Kobxx2NfbmQsMtY3mC
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc4c3a1c-16eb-405b-59fc-08db9153675a
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jul 2023 23:19:20.4774
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2871cC9675l9LrBJ6Nj9cUF0SSSbUz/vUYUPl520EFAUb2kO0aKmqdk3jopJg8klMzXAcOjZY25c75Hp0J6ysQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4266
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-27_10,2023-07-26_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 suspectscore=0
 mlxlogscore=999 malwarescore=0 mlxscore=0 adultscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000
 definitions=main-2307300218
X-Proofpoint-ORIG-GUID: WiB5IOaXf5r5KQwiu3CR4G0oW9_7bQnE
X-Proofpoint-GUID: WiB5IOaXf5r5KQwiu3CR4G0oW9_7bQnE
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Jul 30, 2023, at 11:57 AM, Chuck Lever <chuck.lever@oracle.com> wrote:
>=20
> On Tue, Jul 18, 2023 at 09:37:58AM -0400, Chuck Lever wrote:
>> On Tue, Jul 18, 2023 at 04:38:08PM +1000, NeilBrown wrote:
>>> When a sequence of numbers are needed for internal-use only, an enum is
>>> typically best.  The sequence will inevitably need to be changed one
>>> day, and having an enum means the developer doesn't need to think about
>>> renumbering after insertion or deletion.  The patch will be easier to
>>> review.
>>=20
>> Last sentence needs to define the antecedant of "The patch".
>=20
> I've changed the last sentence in the description to "Such patches
> will be easier ..."
>=20
> I've applied 1/5 through 5/5, with a few cosmetic changes, to the
> SUNRPC threads topic branch. 6/6 needed more work:
>=20
> I've split this into one patch for each new enum.
>=20
> The XPT_ flags change needed TRACE_DEFINE_ENUM macros to make
> show_svc_xprt_flags() work properly. Added.
>=20
> The new enum for SVC_GARBAGE and friends... those aren't bit flags.
> So I've made that a named enum so that it can be used for type-
> checking function return values properly.
>=20
> I dropped the hunk that changes XPRT_SOCK_CONNECTING and friends.
> That should be submitted separately to Anna and Trond.
>=20
> All this will appear in the nfsd repo later today.

I just pushed these changes to topic-sunrpc-thread-scheduling.


>>> Signed-off-by: NeilBrown <neilb@suse.de>
>>> ---
>>> include/linux/sunrpc/cache.h    |   11 +++++++----
>>> include/linux/sunrpc/svc.h      |   34 ++++++++++++++++++++------------=
--
>>> include/linux/sunrpc/svc_xprt.h |   39 +++++++++++++++++++++-----------=
-------
>>> include/linux/sunrpc/svcauth.h  |   29 ++++++++++++++++-------------
>>> include/linux/sunrpc/xprtsock.h |   25 +++++++++++++------------
>>> 5 files changed, 77 insertions(+), 61 deletions(-)
>>>=20
>>> diff --git a/include/linux/sunrpc/cache.h b/include/linux/sunrpc/cache.=
h
>>> index 518bd28f5ab8..3cc4f4f0c764 100644
>>> --- a/include/linux/sunrpc/cache.h
>>> +++ b/include/linux/sunrpc/cache.h
>>> @@ -56,10 +56,13 @@ struct cache_head {
>>> struct kref ref;
>>> unsigned long flags;
>>> };
>>> -#define CACHE_VALID 0 /* Entry contains valid data */
>>> -#define CACHE_NEGATIVE 1 /* Negative entry - there is no match for the=
 key */
>>> -#define CACHE_PENDING 2 /* An upcall has been sent but no reply receiv=
ed yet*/
>>> -#define CACHE_CLEANED 3 /* Entry has been cleaned from cache */
>>> +/* cache_head.flags */
>>> +enum {
>>> + CACHE_VALID, /* Entry contains valid data */
>>> + CACHE_NEGATIVE, /* Negative entry - there is no match for the key */
>>> + CACHE_PENDING, /* An upcall has been sent but no reply received yet*/
>>> + CACHE_CLEANED, /* Entry has been cleaned from cache */
>>> +};
>>=20
>> Weird comment of the day: Please use a double-tab before the comments
>> to leave room for larger flag names in the future.
>>=20
>>=20
>>> #define CACHE_NEW_EXPIRY 120 /* keep new things pending confirmation fo=
r 120 seconds */
>>>=20
>>> diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
>>> index f3df7f963653..83f31a09c853 100644
>>> --- a/include/linux/sunrpc/svc.h
>>> +++ b/include/linux/sunrpc/svc.h
>>> @@ -31,7 +31,7 @@
>>>  * node traffic on multi-node NUMA NFS servers.
>>>  */
>>> struct svc_pool {
>>> - unsigned int sp_id;     /* pool id; also node id on NUMA */
>>> + unsigned int sp_id; /* pool id; also node id on NUMA */
>>> spinlock_t sp_lock; /* protects all fields */
>>> struct list_head sp_sockets; /* pending sockets */
>>> unsigned int sp_nrthreads; /* # of threads in pool */
>>> @@ -44,12 +44,15 @@ struct svc_pool {
>>> struct percpu_counter sp_threads_starved;
>>> struct percpu_counter sp_threads_no_work;
>>>=20
>>> -#define SP_TASK_PENDING (0) /* still work to do even if no
>>> - * xprt is queued. */
>>> -#define SP_CONGESTED (1)
>>> unsigned long sp_flags;
>>> } ____cacheline_aligned_in_smp;
>>>=20
>>> +/* bits for sp_flags */
>>> +enum {
>>> + SP_TASK_PENDING, /* still work to do even if no xprt is queued */
>>> + SP_CONGESTED, /* all threads are busy, none idle */
>>> +};
>>> +
>>> /*
>>>  * RPC service.
>>>  *
>>> @@ -232,16 +235,6 @@ struct svc_rqst {
>>> u32 rq_proc; /* procedure number */
>>> u32 rq_prot; /* IP protocol */
>>> int rq_cachetype; /* catering to nfsd */
>>> -#define RQ_SECURE (0) /* secure port */
>>> -#define RQ_LOCAL (1) /* local request */
>>> -#define RQ_USEDEFERRAL (2) /* use deferral */
>>> -#define RQ_DROPME (3) /* drop current reply */
>>> -#define RQ_SPLICE_OK (4) /* turned off in gss privacy
>>> - * to prevent encrypting page
>>> - * cache pages */
>>> -#define RQ_VICTIM (5) /* about to be shut down */
>>> -#define RQ_BUSY (6) /* request is busy */
>>> -#define RQ_DATA (7) /* request has data */
>>> unsigned long rq_flags; /* flags field */
>>> ktime_t rq_qtime; /* enqueue time */
>>>=20
>>> @@ -272,6 +265,19 @@ struct svc_rqst {
>>> void ** rq_lease_breaker; /* The v4 client breaking a lease */
>>> };
>>>=20
>>> +/* bits for rq_flags */
>>> +enum {
>>> + RQ_SECURE, /* secure port */
>>> + RQ_LOCAL, /* local request */
>>> + RQ_USEDEFERRAL, /* use deferral */
>>> + RQ_DROPME, /* drop current reply */
>>> + RQ_SPLICE_OK, /* turned off in gss privacy to prevent encrypting page
>>> + * cache pages */
>>> + RQ_VICTIM, /* about to be shut down */
>>> + RQ_BUSY, /* request is busy */
>>> + RQ_DATA, /* request has data */
>>> +};
>>> +
>>=20
>> Also here -- two tab stops instead of one.
>>=20
>>=20
>>> #define SVC_NET(rqst) (rqst->rq_xprt ? rqst->rq_xprt->xpt_net : rqst->r=
q_bc_net)
>>>=20
>>> /*
>>> diff --git a/include/linux/sunrpc/svc_xprt.h b/include/linux/sunrpc/svc=
_xprt.h
>>> index a6b12631db21..af383d0349b3 100644
>>> --- a/include/linux/sunrpc/svc_xprt.h
>>> +++ b/include/linux/sunrpc/svc_xprt.h
>>> @@ -56,26 +56,9 @@ struct svc_xprt {
>>> struct list_head xpt_list;
>>> struct list_head xpt_ready;
>>> unsigned long xpt_flags;
>>> -#define XPT_BUSY 0 /* enqueued/receiving */
>>> -#define XPT_CONN 1 /* conn pending */
>>> -#define XPT_CLOSE 2 /* dead or dying */
>>> -#define XPT_DATA 3 /* data pending */
>>> -#define XPT_TEMP 4 /* connected transport */
>>> -#define XPT_DEAD 6 /* transport closed */
>>> -#define XPT_CHNGBUF 7 /* need to change snd/rcv buf sizes */
>>> -#define XPT_DEFERRED 8 /* deferred request pending */
>>> -#define XPT_OLD 9 /* used for xprt aging mark+sweep */
>>> -#define XPT_LISTENER 10 /* listening endpoint */
>>> -#define XPT_CACHE_AUTH 11 /* cache auth info */
>>> -#define XPT_LOCAL 12 /* connection from loopback interface */
>>> -#define XPT_KILL_TEMP   13 /* call xpo_kill_temp_xprt before closing *=
/
>>> -#define XPT_CONG_CTRL 14 /* has congestion control */
>>> -#define XPT_HANDSHAKE 15 /* xprt requests a handshake */
>>> -#define XPT_TLS_SESSION 16 /* transport-layer security established */
>>> -#define XPT_PEER_AUTH 17 /* peer has been authenticated */
>>>=20
>>> struct svc_serv *xpt_server; /* service for transport */
>>> - atomic_t         xpt_reserved; /* space on outq that is rsvd */
>>> + atomic_t xpt_reserved; /* space on outq that is rsvd */
>>> atomic_t xpt_nr_rqsts; /* Number of requests */
>>> struct mutex xpt_mutex; /* to serialize sending data */
>>> spinlock_t xpt_lock; /* protects sk_deferred
>>> @@ -96,6 +79,26 @@ struct svc_xprt {
>>> struct rpc_xprt *xpt_bc_xprt; /* NFSv4.1 backchannel */
>>> struct rpc_xprt_switch *xpt_bc_xps; /* NFSv4.1 backchannel */
>>> };
>>> +/* flag bits for xpt_flags */
>>> +enum {
>>> + XPT_BUSY, /* enqueued/receiving */
>>> + XPT_CONN, /* conn pending */
>>> + XPT_CLOSE, /* dead or dying */
>>> + XPT_DATA, /* data pending */
>>> + XPT_TEMP, /* connected transport */
>>> + XPT_DEAD, /* transport closed */
>>> + XPT_CHNGBUF, /* need to change snd/rcv buf sizes */
>>> + XPT_DEFERRED, /* deferred request pending */
>>> + XPT_OLD, /* used for xprt aging mark+sweep */
>>> + XPT_LISTENER, /* listening endpoint */
>>> + XPT_CACHE_AUTH, /* cache auth info */
>>> + XPT_LOCAL, /* connection from loopback interface */
>>> + XPT_KILL_TEMP, /* call xpo_kill_temp_xprt before closing */
>>> + XPT_CONG_CTRL, /* has congestion control */
>>> + XPT_HANDSHAKE, /* xprt requests a handshake */
>>> + XPT_TLS_SESSION, /* transport-layer security established */
>>> + XPT_PEER_AUTH, /* peer has been authenticated */
>>> +};
>>>=20
>>> static inline void unregister_xpt_user(struct svc_xprt *xpt, struct svc=
_xpt_user *u)
>>> {
>>> diff --git a/include/linux/sunrpc/svcauth.h b/include/linux/sunrpc/svca=
uth.h
>>> index 6d9cc9080aca..8d1d0d0721d2 100644
>>> --- a/include/linux/sunrpc/svcauth.h
>>> +++ b/include/linux/sunrpc/svcauth.h
>>> @@ -133,19 +133,22 @@ struct auth_ops {
>>> int (*set_client)(struct svc_rqst *rq);
>>> };
>>>=20
>>> -#define SVC_GARBAGE 1
>>> -#define SVC_SYSERR 2
>>> -#define SVC_VALID 3
>>> -#define SVC_NEGATIVE 4
>>> -#define SVC_OK 5
>>> -#define SVC_DROP 6
>>> -#define SVC_CLOSE 7 /* Like SVC_DROP, but request is definitely
>>> - * lost so if there is a tcp connection, it
>>> - * should be closed
>>> - */
>>> -#define SVC_DENIED 8
>>> -#define SVC_PENDING 9
>>> -#define SVC_COMPLETE 10
>>> +/*return values for svc functions that analyse request */
>>> +enum {
>>> + SVC_GARBAGE,
>>> + SVC_SYSERR,
>>> + SVC_VALID,
>>> + SVC_NEGATIVE,
>>> + SVC_OK,
>>> + SVC_DROP,
>>> + SVC_CLOSE, /* Like SVC_DROP, but request is definitely
>>> + * lost so if there is a tcp connection, it
>>> + * should be closed
>>> + */
>>> + SVC_DENIED,
>>> + SVC_PENDING,
>>> + SVC_COMPLETE,
>>> +};
>>>=20
>>> struct svc_xprt;
>>>=20
>>> diff --git a/include/linux/sunrpc/xprtsock.h b/include/linux/sunrpc/xpr=
tsock.h
>>> index 700a1e6c047c..1ed2f446010b 100644
>>> --- a/include/linux/sunrpc/xprtsock.h
>>> +++ b/include/linux/sunrpc/xprtsock.h
>>> @@ -81,17 +81,18 @@ struct sock_xprt {
>>> };
>>>=20
>>> /*
>>> - * TCP RPC flags
>>> + * TCP RPC flags in ->sock_state
>>>  */
>>> -#define XPRT_SOCK_CONNECTING 1U
>>> -#define XPRT_SOCK_DATA_READY (2)
>>> -#define XPRT_SOCK_UPD_TIMEOUT (3)
>>> -#define XPRT_SOCK_WAKE_ERROR (4)
>>> -#define XPRT_SOCK_WAKE_WRITE (5)
>>> -#define XPRT_SOCK_WAKE_PENDING (6)
>>> -#define XPRT_SOCK_WAKE_DISCONNECT (7)
>>> -#define XPRT_SOCK_CONNECT_SENT (8)
>>> -#define XPRT_SOCK_NOSPACE (9)
>>> -#define XPRT_SOCK_IGNORE_RECV (10)
>>> -
>>> +enum {
>>> + XPRT_SOCK_CONNECTING,
>>> + XPRT_SOCK_DATA_READY,
>>> + XPRT_SOCK_UPD_TIMEOUT,
>>> + XPRT_SOCK_WAKE_ERROR,
>>> + XPRT_SOCK_WAKE_WRITE,
>>> + XPRT_SOCK_WAKE_PENDING,
>>> + XPRT_SOCK_WAKE_DISCONNECT,
>>> + XPRT_SOCK_CONNECT_SENT,
>>> + XPRT_SOCK_NOSPACE,
>>> + XPRT_SOCK_IGNORE_RECV,
>>> +};
>>> #endif /* _LINUX_SUNRPC_XPRTSOCK_H */
>>>=20
>>>=20
>>=20
>> Let's not change client-side code in this patch. Please split this
>> hunk out and send it to Trond and Anna separately.
>>=20
>=20
> --=20
> Chuck Lever

--
Chuck Lever