Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <596886b409e1f2037c507397e82fbca6a3ea685a.camel@kernel.org>
Subject: Re: [PATCH RFC] nfsd: don't hand out write delegations on O_WRONLY
 opens
From:   Jeff Layton <jlayton@kernel.org>
To:     Chuck Lever <chuck.lever@oracle.com>
Cc:     Neil Brown <neilb@suse.de>, Olga Kornievskaia <kolga@netapp.com>,
        Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
        linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Mon, 31 Jul 2023 19:37:37 -0400
In-Reply-To: <ZMg5CrlMPsDj95Ua@tissot.1015granger.net>
References: <20230731-wdeleg-v1-1-f8fe1ce11b36@kernel.org>
         <ZMg5CrlMPsDj95Ua@tissot.1015granger.net>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-07-31 at 18:43 -0400, Chuck Lever wrote:
> On Mon, Jul 31, 2023 at 04:27:30PM -0400, Jeff Layton wrote:
> > I noticed that xfstests generic/001 was failing against linux-next nfsd=
.
>=20
> Only on NFSv4.2 mounts, I presume?
>=20

Correct.

>=20
> > The client would request a OPEN4_SHARE_ACCESS_WRITE open, and the serve=
r
> > would hand out a write delegation. The client would then try to use tha=
t
> > write delegation as the source stateid in a COPY or CLONE operation, an=
d
> > the server would respond with NFS4ERR_STALE.
> >=20
> > The problem is that the struct file associated with the delegation does
> > not necessarily have read permissions. It's handing out a write
> > delegation on what is effectively an O_WRONLY open. RFC 8881 states:
> >=20
> >  "An OPEN_DELEGATE_WRITE delegation allows the client to handle, on its
> >   own, all opens."
> >=20
> > Given that the client didn't request any read permissions, and that nfs=
d
> > didn't check for any, it seems wrong to give out a write delegation.
>=20
> A client is, in fact, permitted to use a write delegation stateid
> in an otw READ operation. So, this makes sense to me.
>=20

Good.

>=20
> > Don't hand out a delegation if the client didn't request
> > OPEN4_SHARE_ACCESS_BOTH.
> >=20
> > This fixes xfstest generic/001.
> >=20
> > Closes: https://bugzilla.linux-nfs.org/show_bug.cgi?id=3D412
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
>=20
> I'm thinking this should be squashed into commit
> 68a593f24a35 ("NFSD: Enable write delegation support").
>=20

Sounds great to me.

>=20
> > ---
> >  fs/nfsd/nfs4state.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >=20
> > diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> > index ef7118ebee00..9f1c90afed72 100644
> > --- a/fs/nfsd/nfs4state.c
> > +++ b/fs/nfsd/nfs4state.c
> > @@ -5462,6 +5462,8 @@ nfs4_set_delegation(struct nfsd4_open *open, stru=
ct nfs4_ol_stateid *stp,
> >  		return ERR_PTR(-EAGAIN);
> > =20
> >  	if (open->op_share_access & NFS4_SHARE_ACCESS_WRITE) {
> > +		if (!(open->op_share_access & NFS4_SHARE_ACCESS_READ))
> > +			return ERR_PTR(-EBADF);
>=20
> 			return ERR_PTR(-EAGAIN);
>=20
> might be more consistent with the other failure returns in this
> function.
>=20

Shrug, it doesn't matter much. A distinctive error is nice for debugging
purposes though.

>=20
> >  		nf =3D find_writeable_file(fp);
> >  		dl_type =3D NFS4_OPEN_DELEGATE_WRITE;
> >  	} else {
> >=20
> > ---
> > base-commit: ec89391563792edd11d138a853901bce76d11f44
> > change-id: 20230731-wdeleg-bbdb6b25a3c6
> >=20
> > Best regards,
> > --=20
> > Jeff Layton <jlayton@kernel.org>
> >=20
>=20

--=20
Jeff Layton <jlayton@kernel.org>