Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230729123152.35132-1-yuehaibing@huawei.com> <ZMaJQMWO9HF32D84@tissot.1015granger.net>
In-Reply-To: <ZMaJQMWO9HF32D84@tissot.1015granger.net>
From:   Anna Schumaker <anna@kernel.org>
Date:   Tue, 1 Aug 2023 15:45:01 -0400
Message-ID: <CAFX2Jfm8RRLkWJfK+eO_bGPpGat6cY0EkkJ-DK=+e-=9H=MtKA@mail.gmail.com>
Subject: Re: [PATCH net-next] xprtrdma: Remove unused function declaration rpcrdma_bc_post_recv()
To:     Chuck Lever <chuck.lever@oracle.com>
Cc:     jlayton@kernel.org, neilb@suse.de, kolga@netapp.com,
        Dai.Ngo@oracle.com, tom@talpey.com,
        trond.myklebust@hammerspace.com, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Jul 30, 2023 at 12:01=E2=80=AFPM Chuck Lever <chuck.lever@oracle.co=
m> wrote:
>
> On Sat, Jul 29, 2023 at 08:31:52PM +0800, Yue Haibing wrote:
> > rpcrdma_bc_post_recv() is never implemented since introduction in
> > commit f531a5dbc451 ("xprtrdma: Pre-allocate backward rpc_rqst and send=
/receive buffers").
> >
> > Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
>
> Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
>
> Anna, can you take this one?

Yep! Applying it now so it doesn't get lost!

Anna

>
>
> > ---
> >  net/sunrpc/xprtrdma/xprt_rdma.h | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/net/sunrpc/xprtrdma/xprt_rdma.h b/net/sunrpc/xprtrdma/xprt=
_rdma.h
> > index 5e5ff6784ef5..da409450dfc0 100644
> > --- a/net/sunrpc/xprtrdma/xprt_rdma.h
> > +++ b/net/sunrpc/xprtrdma/xprt_rdma.h
> > @@ -593,7 +593,6 @@ void xprt_rdma_cleanup(void);
> >  int xprt_rdma_bc_setup(struct rpc_xprt *, unsigned int);
> >  size_t xprt_rdma_bc_maxpayload(struct rpc_xprt *);
> >  unsigned int xprt_rdma_bc_max_slots(struct rpc_xprt *);
> > -int rpcrdma_bc_post_recv(struct rpcrdma_xprt *, unsigned int);
> >  void rpcrdma_bc_receive_call(struct rpcrdma_xprt *, struct rpcrdma_rep=
 *);
> >  int xprt_rdma_bc_send_reply(struct rpc_rqst *rqst);
> >  void xprt_rdma_bc_free_rqst(struct rpc_rqst *);
> > --
> > 2.34.1
> >
>
> --
> Chuck Lever