Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <85f0d8cb35c8e8c64810f448bae27292703d66ed.camel@kernel.org>
Subject: Re: [PATCH v2] fs: lockd: avoid possible wrong NULL parameter
From:   Jeff Layton <jlayton@kernel.org>
To:     Su Hui <suhui@nfschina.com>, trond.myklebust@hammerspace.com,
        anna@kernel.org, chuck.lever@oracle.com, neilb@suse.de,
        kolga@netapp.com, Dai.Ngo@oracle.com, tom@talpey.com,
        nathan@kernel.org, ndesaulniers@google.com, trix@redhat.com
Cc:     bfields@fieldses.org, linux-nfs@vger.kernel.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
        kernel-janitors@vger.kernel.org
Date:   Fri, 04 Aug 2023 06:14:43 -0400
In-Reply-To: <20230804012656.4091877-1-suhui@nfschina.com>
References: <20230804012656.4091877-1-suhui@nfschina.com>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2023-08-04 at 09:26 +0800, Su Hui wrote:
> clang's static analysis warning: fs/lockd/mon.c: line 293, column 2:
> Null pointer passed as 2nd argument to memory copy function.
>=20
> Assuming 'hostname' is NULL and calling 'nsm_create_handle()', this will
> pass NULL as 2nd argument to memory copy function 'memcpy()'. So return
> NULL if 'hostname' is invalid.
>=20
> Fixes: 77a3ef33e2de ("NSM: More clean up of nsm_get_handle()")
> Signed-off-by: Su Hui <suhui@nfschina.com>
> ---
> v2:
>  - move NULL check to the callee "nsm_create_handle()"
>  fs/lockd/mon.c | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/fs/lockd/mon.c b/fs/lockd/mon.c
> index 1d9488cf0534..87a0f207df0b 100644
> --- a/fs/lockd/mon.c
> +++ b/fs/lockd/mon.c
> @@ -276,6 +276,9 @@ static struct nsm_handle *nsm_create_handle(const str=
uct sockaddr *sap,
>  {
>  	struct nsm_handle *new;
> =20
> +	if (!hostname)
> +		return NULL;
> +
>  	new =3D kzalloc(sizeof(*new) + hostname_len + 1, GFP_KERNEL);
>  	if (unlikely(new =3D=3D NULL))
>  		return NULL;

Reviewed-by: Jeff Layton <jlayton@kernel.org>