Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6461e16380ad638547f6db3af4aa873a490d9fa3.camel@kernel.org>
Subject: Re: [PATCH v5 0/2] add rpc_status handler in nfsd debug filesystem
From:   Jeff Layton <jlayton@kernel.org>
To:     Lorenzo Bianconi <lorenzo@kernel.org>, linux-nfs@vger.kernel.org
Cc:     lorenzo.bianconi@redhat.com, chuck.lever@oracle.com, neilb@suse.de
Date:   Mon, 07 Aug 2023 06:08:28 -0400
In-Reply-To: <cover.1691169103.git.lorenzo@kernel.org>
References: <cover.1691169103.git.lorenzo@kernel.org>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2023-08-04 at 19:16 +0200, Lorenzo Bianconi wrote:
> Introduce rpc_status entry in nfsd debug filesystem in order to dump
> pending RPC requests debugging information.
>=20
> Changes since v4:
> - rely on acquire/release APIs and get rid of atomic operation
> - fix kdoc for nfsd_rpc_status_open
> - get rid of ',' as field delimiter in nfsd_rpc_status hanlder
> - move nfsd_rpc_status before nfsd_v4 enum entries
> - fix compilantion error if nfsdv4 is not enabled
>=20
> Changes since v3:
> - introduce rq_status_counter in order to detect if the RPC request is
>   pending and RPC info are stable
> - rely on __svc_print_addr to dump IP info
>=20
> Changes since v2:
> - minor changes in nfsd_rpc_status_show output
>=20
> Changes since v1:
> - rework nfsd_rpc_status_show output
>=20
> Changes since RFCv1:
> - riduce time holding nfsd_mutex bumping svc_serv refcoung in
>   nfsd_rpc_status_open()
> - dump rqstp->rq_stime
> - add missing kdoc for nfsd_rpc_status_open()
>=20
> Link: https://bugzilla.linux-nfs.org/show_bug.cgi?id=3D3D366
>=20
> Lorenzo Bianconi (2):
>   SUNRPC: add verbose parameter to __svc_print_addr()
>   NFSD: add rpc_status entry in nfsd debug filesystem
>=20
>  fs/nfsd/nfs4proc.c              |   4 +-
>  fs/nfsd/nfsctl.c                |   9 ++
>  fs/nfsd/nfsd.h                  |   7 ++
>  fs/nfsd/nfssvc.c                | 140 ++++++++++++++++++++++++++++++++
>  include/linux/sunrpc/svc.h      |   1 +
>  include/linux/sunrpc/svc_xprt.h |  12 +--
>  net/sunrpc/svc.c                |   2 +-
>  net/sunrpc/svc_xprt.c           |   2 +-
>  8 files changed, 166 insertions(+), 11 deletions(-)
>=20

Reviewed-by: Jeff Layton <jlayton@kernel.org>