Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 7 Aug 2023 10:09:23 -0400
From:   Chuck Lever <chuck.lever@oracle.com>
To:     NeilBrown <neilb@suse.de>, trondmy@hammerspace.com, anna@kernel.org
Cc:     Jeff Layton <jlayton@kernel.org>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 3/6] SUNRPC: integrate back-channel processing with
 svc_recv()
Message-ID: <ZND7E31GZjpX/DME@tissot.1015granger.net>
References: <20230802073443.17965-1-neilb@suse.de>
 <20230802073443.17965-4-neilb@suse.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230802073443.17965-4-neilb@suse.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DyzZi4SvdcB6SmZCs1oZgC6RDwuvQzYDkDpwy0yRcXC4BsNuUik2W/1p70Pr?=
 =?us-ascii?Q?7clzS03vyNdx+25LkORAGxELDOdI4hHW1CnUbOeUPJTwLOqSXv+R64Y4+ji+?=
 =?us-ascii?Q?aU9bDNVWxgaa4Jv2yTzaD9Wiv9ZrYGuhAsUiDS9/1e9Sa0F33Gwf9PdOeOa4?=
 =?us-ascii?Q?hIIrhkZr2Ooam8Ars7gJ1JpGFrPJACtw5e5JsWnpTEuqPH5R0/77nwHCweEM?=
 =?us-ascii?Q?n3CXn4JrvF8B/w4aua7wFkRckh+NpRu5vJt8BBYxDUESJk1lPkoLIBBMU2nG?=
 =?us-ascii?Q?FYzM3n3HnnBsE7CVAn+/YvqFd0dC/AQPcTwG/8y2AIgBSezL93Sgrso0gDhX?=
 =?us-ascii?Q?hVBeJ6erfVo2oWcf1Eyfv7DvyKd4MfSRsLjn1clrI7xDI4a19F3gGNTpfC7X?=
 =?us-ascii?Q?opVjAo+sVZpy00fXYSh/Wr5a/KTBoH/8x4QGIJ1pW3AUWZj7zaaDPuVfaAPB?=
 =?us-ascii?Q?vbciAYhezmG+K+HceuxKRfkrVq+sMM8/mZA8jdjxkLHhSPQIqi/nRzt+7JyQ?=
 =?us-ascii?Q?jsC3gSa22xwm1u/gqdpOZWAFnkZynyNfv+k212p2g0C4udY0eWbD0vlTEu2B?=
 =?us-ascii?Q?sGcpyeERNwso8x7sW1D/HuHdSZN7Lvy1HGWyGT/iC/LklNbbcfHvecFyWHF9?=
 =?us-ascii?Q?+8suVCs33msE28M51dqCp47GyFnBVdc05wfNvz1UrVLObmR9yj21c0buJYAZ?=
 =?us-ascii?Q?UyZIAdvO9yrClWr2V8HBUl78sSEdiqIFcFj+bHU/lEYSTgFBE3bdGTkB5jWN?=
 =?us-ascii?Q?G3ifsa6JWeuw+yrlDxkqikvIWzb9gXP7aK99U1Em/vcj3t+OFI65EwMsGHO4?=
 =?us-ascii?Q?RKPZUD4SftdeYQ4Qka9N6MVWFwDdMhke4H5Ooz9b88eGiUcGbj1EDcG/c4Xe?=
 =?us-ascii?Q?Pz+SG2KrDNU/NVogSzMIFsbS/P31MhBpKkEainJtr+bf2mZ4nGlgJxr3YhN+?=
 =?us-ascii?Q?QWTLYBLU3kji0ki4DEl66krTI7KyLy/viH0vC9aEqdsHJ0wfN2myLziGVCIT?=
 =?us-ascii?Q?6TtGtl8CpiI1gPdjs6+CCAGR/xqJrIUvU/sDYJNavVxLfyJjEm/GkXqGN4kS?=
 =?us-ascii?Q?BpgpgD25RwoskX3GuTo4hThE79zKP7i3FA89KoujRYbdIKzZ5pIyzHy1Sxt0?=
 =?us-ascii?Q?/dsUpRtJydad/89rIiFeLn+5HdwGLMW3qGIh5P53c4pshcJyPl4+fykpXIP8?=
 =?us-ascii?Q?y9WXgelmJBgBa3Q9EnsOus7xajB7OYat2MPIRF1ZEE5KBZtenp3734yTsm2L?=
 =?us-ascii?Q?FiIeFDY/cW1boZUy9eQoSJB/ZItaB4d6NRC33Qq+S7dUTFWTXEV1JnWLvAUP?=
 =?us-ascii?Q?rgPQrVf0byOOg9yzXPZcdZdx2PjWt1GrIG4w+y4XT3SQKffT1h/hoJPTphlA?=
 =?us-ascii?Q?6GmI6r/geQV/tvb4Uv6D4ao6fetDH2Tg++zjcLyPdV1xqdLbfVkmwxC6YDkD?=
 =?us-ascii?Q?rdnDkY9405YxV306C3ObILqd6mt1kS54uwZLpK4UpOhm9vHUncfSBQiNWm9J?=
 =?us-ascii?Q?fKvt/tMLsgNT4WNp+kMu7CEvg/JSJTdgvKq+ajsHCssR16683MzMsQ/XKZ1i?=
 =?us-ascii?Q?fk/WolKHv0hUMDG59gPVn13yE79lM9VQWDD5BF64sQimCCl4odP5zjT78flD?=
 =?us-ascii?Q?Sg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: CDkqkMxj1nH6BH/iAH4ZRaZ5VN3KA9jPtQmvRpQtBKXwle9mzPhgKJrLtCiy1LCSOp7yCdf3wLaohw9zGFtXIPxsCUa4gE69WyoxKU1sMwc+rDUYeyUJ/i/g+cxoZuwdVRj1BsPzyWamHfXPU8uyjbYA2cpUzOjmYZ8J1dsaw6Viaw4/IVRa0cxOf1MFOfgErOFeK3OiVDdB2nPwdwtkQexYBSMB0L4ecJF0ZdR4NGyCNi2yCg56UYaeiwwkKgKWxsQsLO6ge/aIRKhcbw4VQRP06zXa0/5IZtDotJgkTStlj44zQXebeERfJi3yy+LtZ42eo8/HK4ifn6cUDUr2+AWmemaNSfqcbEa0lMRiExmfla2SPtHj6OPy6EmI2xQI1U/k8qs72V2jIxpSfP1cZLFoI9qjth4ToOjqwLH3+A0ePj9ZvmlAJdQpKCUqiG9xbe9qlqD+7EcrCWg6YxeCryUOMaYbY32Ky+S/eMExTkEfMLRTM+BK92bXltJAQ4wwKAH0AuM/6mHkw00FrvCRBW3j42T6ZsOvMdlxCtGY5hhK9/SvFnDsd0BUA7V+lITL0FEjR7BDVsufPk5AWEI6Q0LRsgYOWL28zdAaa+Rayer5/JuayG8BFMTOKOxlkVcfVQgBBSGiDwq1ojoyQ6oBrTpMj4WHaaIoBZyqnVfzgII60wDN99sKC6HA+Sh/pYV1lj/HpTxa+FL5wXY597PqJeXpnFlEEOy10tcgMrUPBuR1LbYI3RThCTeApffv8bBF7t/uXm90BzenB0DKzwr3DQHo3q6suIukFG4oe+5+1WABSKrfNymW5MNxF0qzH8r9m2txzH5bOoXs2S8uaSCbJmMWHa7cTHUtzzo/0AHn/wI=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b5a1de00-4804-47af-ad85-08db974fec36
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 14:09:32.5476
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1oCgXbI4AsjYORyDLM3sxV+yXXUOhlxuUUeOBbQ2Zh0RGJgw+aau1HyVY73vlMrDTLFIR+vljkw8PrE1N5mv+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB7411
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-08-07_15,2023-08-03_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 spamscore=0
 adultscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000
 definitions=main-2308070131
X-Proofpoint-ORIG-GUID: 0O_X8lUzkF_ELuGLxamoKB8R3b2FcMnL
X-Proofpoint-GUID: 0O_X8lUzkF_ELuGLxamoKB8R3b2FcMnL
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On Wed, Aug 02, 2023 at 05:34:40PM +1000, NeilBrown wrote:
> Using svc_recv() for (NFSv4.1) back-channel handling means we have just
> one mechanism for waking threads.
> 
> Also change kthread_freezable_should_stop() in nfs4_callback_svc() to
> kthread_should_stop() as used elsewhere.
> kthread_freezable_should_stop() effectively adds a try_to_freeze() call,
> and svc_recv() already contains that at an appropriate place.
> 
> Signed-off-by: NeilBrown <neilb@suse.de>

This one needs review and ack from the client maintainers.

Anna/Trond, if you haven't been following along, we're working on
updating the server-side thread scheduler. This patch replaces the
ad hoc scheduler in the client's NFSv4 callback service so that all
kernel RPC services utilize the same thread scheduling mechanism.

The whole series so far appears in the topic-sunrpc-thread-scheduling
branch in the public nfsd repo:

https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git


> ---
>  fs/nfs/callback.c                 | 46 ++-----------------------------
>  include/linux/sunrpc/svc.h        |  2 --
>  net/sunrpc/backchannel_rqst.c     |  8 ++----
>  net/sunrpc/svc.c                  |  2 +-
>  net/sunrpc/svc_xprt.c             | 32 +++++++++++++++++++++
>  net/sunrpc/xprtrdma/backchannel.c |  2 +-
>  6 files changed, 39 insertions(+), 53 deletions(-)
> 
> diff --git a/fs/nfs/callback.c b/fs/nfs/callback.c
> index 466ebf1d41b2..42a0c2f1e785 100644
> --- a/fs/nfs/callback.c
> +++ b/fs/nfs/callback.c
> @@ -78,7 +78,7 @@ nfs4_callback_svc(void *vrqstp)
>  
>  	set_freezable();
>  
> -	while (!kthread_freezable_should_stop(NULL))
> +	while (!kthread_should_stop())
>  		svc_recv(rqstp);
>  
>  	svc_exit_thread(rqstp);
> @@ -86,45 +86,6 @@ nfs4_callback_svc(void *vrqstp)
>  }
>  
>  #if defined(CONFIG_NFS_V4_1)
> -/*
> - * The callback service for NFSv4.1 callbacks
> - */
> -static int
> -nfs41_callback_svc(void *vrqstp)
> -{
> -	struct svc_rqst *rqstp = vrqstp;
> -	struct svc_serv *serv = rqstp->rq_server;
> -	struct rpc_rqst *req;
> -	int error;
> -	DEFINE_WAIT(wq);
> -
> -	set_freezable();
> -
> -	while (!kthread_freezable_should_stop(NULL)) {
> -		prepare_to_wait(&serv->sv_cb_waitq, &wq, TASK_IDLE);
> -		spin_lock_bh(&serv->sv_cb_lock);
> -		if (!list_empty(&serv->sv_cb_list)) {
> -			req = list_first_entry(&serv->sv_cb_list,
> -					struct rpc_rqst, rq_bc_list);
> -			list_del(&req->rq_bc_list);
> -			spin_unlock_bh(&serv->sv_cb_lock);
> -			finish_wait(&serv->sv_cb_waitq, &wq);
> -			dprintk("Invoking bc_svc_process()\n");
> -			error = bc_svc_process(serv, req, rqstp);
> -			dprintk("bc_svc_process() returned w/ error code= %d\n",
> -				error);
> -		} else {
> -			spin_unlock_bh(&serv->sv_cb_lock);
> -			if (!kthread_should_stop())
> -				schedule();
> -			finish_wait(&serv->sv_cb_waitq, &wq);
> -		}
> -	}
> -
> -	svc_exit_thread(rqstp);
> -	return 0;
> -}
> -
>  static inline void nfs_callback_bc_serv(u32 minorversion, struct rpc_xprt *xprt,
>  		struct svc_serv *serv)
>  {
> @@ -237,10 +198,7 @@ static struct svc_serv *nfs_callback_create_svc(int minorversion)
>  			cb_info->users);
>  
>  	threadfn = nfs4_callback_svc;
> -#if defined(CONFIG_NFS_V4_1)
> -	if (minorversion)
> -		threadfn = nfs41_callback_svc;
> -#else
> +#if !defined(CONFIG_NFS_V4_1)
>  	if (minorversion)
>  		return ERR_PTR(-ENOTSUPP);
>  #endif
> diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
> index dbf5b21feafe..5e2d3b83999e 100644
> --- a/include/linux/sunrpc/svc.h
> +++ b/include/linux/sunrpc/svc.h
> @@ -92,8 +92,6 @@ struct svc_serv {
>  						 * that arrive over the same
>  						 * connection */
>  	spinlock_t		sv_cb_lock;	/* protects the svc_cb_list */
> -	wait_queue_head_t	sv_cb_waitq;	/* sleep here if there are no
> -						 * entries in the svc_cb_list */
>  	bool			sv_bc_enabled;	/* service uses backchannel */
>  #endif /* CONFIG_SUNRPC_BACKCHANNEL */
>  };
> diff --git a/net/sunrpc/backchannel_rqst.c b/net/sunrpc/backchannel_rqst.c
> index 65a6c6429a53..44b7c89a635f 100644
> --- a/net/sunrpc/backchannel_rqst.c
> +++ b/net/sunrpc/backchannel_rqst.c
> @@ -349,10 +349,8 @@ struct rpc_rqst *xprt_lookup_bc_request(struct rpc_xprt *xprt, __be32 xid)
>  }
>  
>  /*
> - * Add callback request to callback list.  The callback
> - * service sleeps on the sv_cb_waitq waiting for new
> - * requests.  Wake it up after adding enqueing the
> - * request.
> + * Add callback request to callback list.  Wake a thread
> + * on the first pool (usually the only pool) to handle it.
>   */
>  void xprt_complete_bc_request(struct rpc_rqst *req, uint32_t copied)
>  {
> @@ -371,6 +369,6 @@ void xprt_complete_bc_request(struct rpc_rqst *req, uint32_t copied)
>  	xprt_get(xprt);
>  	spin_lock(&bc_serv->sv_cb_lock);
>  	list_add(&req->rq_bc_list, &bc_serv->sv_cb_list);
> -	wake_up(&bc_serv->sv_cb_waitq);
>  	spin_unlock(&bc_serv->sv_cb_lock);
> +	svc_pool_wake_idle_thread(&bc_serv->sv_pools[0]);
>  }
> diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
> index dc21e6c732db..0c3272f1b3b6 100644
> --- a/net/sunrpc/svc.c
> +++ b/net/sunrpc/svc.c
> @@ -440,7 +440,6 @@ __svc_init_bc(struct svc_serv *serv)
>  {
>  	INIT_LIST_HEAD(&serv->sv_cb_list);
>  	spin_lock_init(&serv->sv_cb_lock);
> -	init_waitqueue_head(&serv->sv_cb_waitq);
>  }
>  #else
>  static void
> @@ -718,6 +717,7 @@ void svc_pool_wake_idle_thread(struct svc_pool *pool)
>  
>  	set_bit(SP_CONGESTED, &pool->sp_flags);
>  }
> +EXPORT_SYMBOL_GPL(svc_pool_wake_idle_thread);
>  
>  static struct svc_pool *
>  svc_pool_next(struct svc_serv *serv, struct svc_pool *pool, unsigned int *state)
> diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
> index f1d64ded89fb..39582ac33cbd 100644
> --- a/net/sunrpc/svc_xprt.c
> +++ b/net/sunrpc/svc_xprt.c
> @@ -17,6 +17,7 @@
>  #include <linux/sunrpc/svc_xprt.h>
>  #include <linux/sunrpc/svcsock.h>
>  #include <linux/sunrpc/xprt.h>
> +#include <linux/sunrpc/bc_xprt.h>
>  #include <linux/module.h>
>  #include <linux/netdevice.h>
>  #include <trace/events/sunrpc.h>
> @@ -719,6 +720,13 @@ rqst_should_sleep(struct svc_rqst *rqstp)
>  	if (freezing(current))
>  		return false;
>  
> +#if defined(CONFIG_SUNRPC_BACKCHANNEL)
> +	if (svc_is_backchannel(rqstp)) {
> +		if (!list_empty(&rqstp->rq_server->sv_cb_list))
> +			return false;
> +	}
> +#endif
> +
>  	return true;
>  }
>  
> @@ -867,6 +875,30 @@ void svc_recv(struct svc_rqst *rqstp)
>  		trace_svc_xprt_dequeue(rqstp);
>  		svc_handle_xprt(rqstp, xprt);
>  	}
> +
> +#if defined(CONFIG_SUNRPC_BACKCHANNEL)
> +	if (svc_is_backchannel(rqstp)) {
> +		struct svc_serv *serv = rqstp->rq_server;
> +		struct rpc_rqst *req;
> +
> +		spin_lock_bh(&serv->sv_cb_lock);
> +		req = list_first_entry_or_null(&serv->sv_cb_list,
> +					       struct rpc_rqst, rq_bc_list);
> +		if (req) {
> +			int error;
> +
> +			list_del(&req->rq_bc_list);
> +			spin_unlock_bh(&serv->sv_cb_lock);
> +
> +			dprintk("Invoking bc_svc_process()\n");
> +			error = bc_svc_process(rqstp->rq_server, req, rqstp);
> +			dprintk("bc_svc_process() returned w/ error code= %d\n",
> +				error);
> +			return;
> +		}
> +		spin_unlock_bh(&serv->sv_cb_lock);
> +	}
> +#endif
>  }
>  EXPORT_SYMBOL_GPL(svc_recv);
>  
> diff --git a/net/sunrpc/xprtrdma/backchannel.c b/net/sunrpc/xprtrdma/backchannel.c
> index e4d84a13c566..bfc434ec52a7 100644
> --- a/net/sunrpc/xprtrdma/backchannel.c
> +++ b/net/sunrpc/xprtrdma/backchannel.c
> @@ -267,7 +267,7 @@ void rpcrdma_bc_receive_call(struct rpcrdma_xprt *r_xprt,
>  	list_add(&rqst->rq_bc_list, &bc_serv->sv_cb_list);
>  	spin_unlock(&bc_serv->sv_cb_lock);
>  
> -	wake_up(&bc_serv->sv_cb_waitq);
> +	svc_pool_wake_idle_thread(&bc_serv->sv_pools[0]);
>  
>  	r_xprt->rx_stats.bcall_count++;
>  	return;
> -- 
> 2.40.1
> 

-- 
Chuck Lever