Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c1cc7fc4-1375-d6f1-997f-386580756cd5@redhat.com>
Date:   Thu, 10 Aug 2023 12:02:41 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] Fixed a regression in the junction code
Content-Language: en-US
From:   Steve Dickson <steved@redhat.com>
To:     Linux NFS Mailing list <linux-nfs@vger.kernel.org>
References: <20230809130018.184633-1-steved@redhat.com>
In-Reply-To: <20230809130018.184633-1-steved@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/9/23 9:00 AM, Steve Dickson wrote:
> commit cdbef4e9 created a regression in the
> in the junction code by adding a O_PATH flag
> to the open() in junction_open_path()
> 
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2213669
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed...

steved.
> ---
>   support/junction/junction.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/support/junction/junction.c b/support/junction/junction.c
> index 0628bb0f..c1ec8ff8 100644
> --- a/support/junction/junction.c
> +++ b/support/junction/junction.c
> @@ -63,7 +63,7 @@ junction_open_path(const char *pathname, int *fd)
>   	if (pathname == NULL || fd == NULL)
>   		return FEDFS_ERR_INVAL;
>   
> -	tmp = open(pathname, O_PATH|O_DIRECTORY);
> +	tmp = open(pathname, O_DIRECTORY);
>   	if (tmp == -1) {
>   		switch (errno) {
>   		case EPERM: