Received: by 2002:a05:7412:6592:b0:d7:7d3a:4fe2 with SMTP id m18csp971378rdg; Fri, 11 Aug 2023 06:05:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF28cOutBBHE3T8iCnOzwZZW4VR/1F0KGTeiM7aJTOIMvggVLKK9ZZBSHYpGCwPeMFQFjEG X-Received: by 2002:a05:6512:2117:b0:4f8:76ba:ad3c with SMTP id q23-20020a056512211700b004f876baad3cmr1260469lfr.55.1691759129588; Fri, 11 Aug 2023 06:05:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691759129; cv=none; d=google.com; s=arc-20160816; b=nc2Qz8TnRilaWVo3dFd34tOEGHfXnYqUXwUzk/piRvzOQkGHsu/RGSYvhrVjDqx/0C fZ35EGF3dwWJ+0sg1jhc80C9iREVoyYxjXRpLkxEq/V1Lrer63etpnKR6wPb3XmpBCyI 1LqocVgnRNSGJaetsn5VH91hi0vkdU4N51KXfJXF2OJYcaxaA7VbgPsXbNixCe5IamnJ Uveikgi4gkueqq/Hy5CmUiAvGHBkMl5h+qElTju+a/qO3/BaHNYA6YHqIufF9TX8LgxO 9f7mDWZJyAfq2xE6AeTAlpPOWNhbgVbk/nxI9CYf/ySa1vfp+d2eonq9BF0hy8gr9VjY T+Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=96Jyxa0hgrG24aZgu2ilDmsPaDJbIFT8CvAcqFGq7ak=; fh=c1oCOXmV2S9ndbEgJOxYrm1C+5Y9KT9OXJZnu9EVFfs=; b=zscmnVWiQXSuoCcNjQnmiR0of1EkwqIg5YLYBu3W4xmGCLHSF1RwIRStn9n7pO0Op8 YrBLMg2uyzixPgM/XiyaZlKE/jSIj3dFxSjmDKoE7zBrq/jsMDzFdeOyfg/w64mO69Zo RchCJ0LlDqVS501wDH7Up8LF9CD2/l867NcFIhthaBj7ijEynU0VSsCRaBoYLYuAVrZ+ cmIbybCMBIz3w0hiltouuiMldxblOfoKDcIK9XeMmCcLrwoeRzY8cXIYMUbK+e8Wum6Z 1jLg1kmv9nxN/rxrh28q4osnYWMJMvWNmt1UY+NjIHwiR/wvth5Ay7Hsv4/MkKIn92fC e6iA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="Lt8QMt/q"; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r15-20020aa7c14f000000b005232e129627si3354357edp.670.2023.08.11.06.04.44; Fri, 11 Aug 2023 06:05:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="Lt8QMt/q"; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236483AbjHKM1d (ORCPT + 99 others); Fri, 11 Aug 2023 08:27:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235414AbjHKM1c (ORCPT ); Fri, 11 Aug 2023 08:27:32 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E55FE60; Fri, 11 Aug 2023 05:27:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=96Jyxa0hgrG24aZgu2ilDmsPaDJbIFT8CvAcqFGq7ak=; b=Lt8QMt/qiwPklQXJKNxAAayl50 ejm5z3TauQQgWXDYeiy6ev7CoxuktCUjLml+tQTXB0FrmwYo9bGjhm2G8bwiVtr2qWkYfM3c8FNl1 cPDaz7ayPa6vktH3ev1ZeHUse0hr9sV3dSKzn62142iTuA8TTM4tDaiYAHOFhJAm7nP3aQxRbODoe cl8s2GHmVFeXScu6jrXcZHGDTmN2udO8XZ0pPwfpsd5QoOiRLOiFHXD6KYR9f2MEyvA/KeT9RzHmF DIvDgADu/AxqynsuMYC3hcwdLyXOsBeZQBLnrFNVOoRqDCMnS+8kcWICKZ1ml8I/4TT3bYAOcmKWy N15IsxAA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qUREm-00Abyw-17; Fri, 11 Aug 2023 12:27:28 +0000 Date: Fri, 11 Aug 2023 05:27:28 -0700 From: Christoph Hellwig To: Jan Kara Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, Christoph Hellwig , Alasdair Kergon , Andrew Morton , Anna Schumaker , Chao Yu , Christian Borntraeger , "Darrick J. Wong" , Dave Kleikamp , David Sterba , dm-devel@redhat.com, drbd-dev@lists.linbit.com, Gao Xiang , Jack Wang , Jaegeuk Kim , jfs-discussion@lists.sourceforge.net, Joern Engel , Joseph Qi , Kent Overstreet , linux-bcache@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, "Md. Haris Iqbal" , Mike Snitzer , Minchan Kim , ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, Sergey Senozhatsky , Song Liu , Sven Schnelle , target-devel@vger.kernel.org, Ted Tso , Trond Myklebust , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 0/29] block: Make blkdev_get_by_*() return handle Message-ID: References: <20230810171429.31759-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230810171429.31759-1-jack@suse.cz> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Except for a mostly cosmetic nitpick this looks good to me: Acked-by: Christoph Hellwig That's not eactly the deep review I'd like to do, but as I'm about to head out for vacation that's probably as good as it gets.