Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Benjamin Coddington <bcodding@redhat.com>
To:     Chengen Du <chengen.du@canonical.com>
Cc:     trond.myklebust@hammerspace.com, anna@kernel.org,
        linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 RESEND] NFS: Add mount option 'fasc'
Date:   Tue, 29 Aug 2023 09:35:16 -0400
Message-ID: <73E82F73-1621-4553-8019-2946EA573415@redhat.com>
In-Reply-To: <CAPza5qe0NBWiKZ1yLyfdPGOsmM=VGqWMs=oWJqVzLRcd8AFyJQ@mail.gmail.com>
References: <20230828055310.21391-1-chengen.du@canonical.com>
 <CAPza5qe0NBWiKZ1yLyfdPGOsmM=VGqWMs=oWJqVzLRcd8AFyJQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On 28 Aug 2023, at 3:14, Chengen Du wrote:

> Hi,
>
> The performance issue has been brought to our attention by users
> within the Ubuntu community.
> However, it seems to be confined to specific user scenarios.
> Canonical has taken proactive measures to tackle the problem by
> implementing a temporary solution [1], which has effectively resolved
> the issue at hand.
> Nonetheless, our earnest desire is for a definitive resolution of the
> performance concern at its source upstream.
>
> I've taken the initiative to send the patches addressing this matter.
> Regrettably, as of now, I've yet to receive any response.
> This situation leads me to consider the possibility of reservations or
> deliberations surrounding this issue.
> I am genuinely keen to gain insights and perspectives from the
> upstream community.
>
> I kindly ask for your valuable input on this matter.
> Your thoughts would significantly aid my progress and contribute to a
> collective consensus.

Hi Chengen Du,

This patch changes the default behavior for everyone.  Instead of that,
perhaps the new option should change the behavior.  That would reduce the
change surface for all NFS users.

The default behavior has already been hotly debated on this list and so I
think changing the default would need to be accompanied by excellent
reasons.

Ben