Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f4837c30b2faedd6a736a19d93c79b93df230349.camel@kernel.org>
Subject: Re: [PATCH v2] NFSv4: Always ask for type with READDIR
From:   Jeff Layton <jlayton@kernel.org>
To:     Trond Myklebust <trondmy@hammerspace.com>,
        "anna@kernel.org" <anna@kernel.org>,
        "bcodding@redhat.com" <bcodding@redhat.com>
Cc:     "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Date:   Wed, 30 Aug 2023 17:14:35 -0400
In-Reply-To: <4eb846815a1cdd1a98e064305b57a890b46e2708.camel@hammerspace.com>
References: <82d1908e4f835a2f16a509a11b62b9d93ccb6cdf.1693424491.git.bcodding@redhat.com>
         <f793a08ed0db7bbe292c8aa6ec7241178c111cab.camel@kernel.org>
         <4eb846815a1cdd1a98e064305b57a890b46e2708.camel@hammerspace.com>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2023-08-30 at 20:20 +0000, Trond Myklebust wrote:
> On Wed, 2023-08-30 at 16:10 -0400, Jeff Layton wrote:
> > On Wed, 2023-08-30 at 15:42 -0400, Benjamin Coddington wrote:
> > > Again we have claimed regressions for walking a directory tree,
> > > this time
> > > with the "find" utility which always tries to optimize away asking
> > > for any
> > > attributes until it has a complete list of entries.=A0 This behavior
> > > makes
> > > the readdir plus heuristic do the wrong thing, which causes a storm
> > > of
> > > GETATTRs to determine each entry's type in order to continue the
> > > walk.
> > >=20
> > > For v4 add the type attribute to each READDIR request to include it
> > > no
> > > matter the heuristic.=A0 This allows a simple `find` command to
> > > proceed
> > > quickly through a directory tree.
> > >=20
> >=20
> > The important bit here is that with v4, we can fill out d_type even
> > when
> > "plus" is false, at little cost. The downside is that non-plus
> > READDIR
> > replies will now be a bit larger on the wire. I think it's a
> > worthwhile
> > tradeoff though.
>=20
> The reason why we never did it before is that for many servers, it
> forces them to go to the inode in order to retrieve the information.
>=20
> IOW: You might as well just do readdirplus.
>=20

That makes total sense, given how this code has evolved.

FWIW, the Linux NFS server already calls vfs_getattr for every dentry in
a v4 READDIR reply regardless of what the client requests. It has to in
order to detect junctions, so we're bringing in the inode no matter
what. Fetching the type is trivial, so I don't see this as costing
anything extra there.

Mileage could vary on other servers with more synthetic filesystems, but
one would hope that most of them can also return the type cheaply.
--=20
Jeff Layton <jlayton@kernel.org>