Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8db2e22a71ed9c658945bd3d7f0a4b6cad7db1d3.camel@kernel.org>
Subject: Re: [PATCH fstests 1/3] generic/294: don't run this test on NFS
From:   Jeff Layton <jlayton@kernel.org>
To:     Zorro Lang <zlang@redhat.com>
Cc:     fstests@vger.kernel.org, linux-nfs@vger.kernel.org
Date:   Fri, 01 Sep 2023 06:21:43 -0400
In-Reply-To: <20230901051439.j5jduasrkmh67g6g@zlang-mailbox>
References: <20230831-nfs-skip-v1-0-d54c1c6a9af2@kernel.org>
         <20230831-nfs-skip-v1-1-d54c1c6a9af2@kernel.org>
         <20230901051439.j5jduasrkmh67g6g@zlang-mailbox>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2023-09-01 at 13:14 +0800, Zorro Lang wrote:
> On Thu, Aug 31, 2023 at 02:40:28PM -0400, Jeff Layton wrote:
> > When creating a new dentry (of any type), NFS will optimize away any
> > on-the-wire lookups prior to the create since that means an extra
> > round trip to the server. Because of that, it consistently fails this
> > test.
> >=20
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> > ---
> >  tests/generic/294 | 4 ++++
> >  1 file changed, 4 insertions(+)
> >=20
> > diff --git a/tests/generic/294 b/tests/generic/294
> > index 406b1b3954b9..777b62aec9ad 100755
> > --- a/tests/generic/294
> > +++ b/tests/generic/294
> > @@ -15,6 +15,10 @@ _begin_fstest auto quick
> > =20
> >  # real QA test starts here
> > =20
> > +# NFS will optimize away the on-the-wire lookup before attempting to
> > +# create a new file (since that means an extra round trip).
> > +test $FSTYP =3D "nfs"  && _notrun "NFS optmizes away lookups on exclus=
ive creates"
> > +
> >  # Modify as appropriate.
> >  _supported_fs generic
>=20
> I don't know if nfs-list wants to skip these test cases on nfs. Anyway, i=
f
> there's not an objection from nfs team, the _supported_fs helper can use
> a black list, likes:
>=20
>   _supported_fs ^nfs
>=20
> If a test case doesn't support nfs totally, you can use this and give it =
a
> proper comment.
>=20

I think we do want to skip it. This one consistently fails on NFS and is
testing very specific and subtle behavior that is not required by POSIX.

I can respin these using the _supported_fs syntax if that's preferred
though.=20
--=20
Jeff Layton <jlayton@kernel.org>