Received: by 2002:a05:7412:f584:b0:e2:908c:2ebd with SMTP id eh4csp1379644rdb; Mon, 4 Sep 2023 11:46:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE82x5DbcbG4IPNIaJmuWMQkKY9ySgby3k7T9wHpPwP+dsiD/RSkz5Uv76zWVGQRw409RtW X-Received: by 2002:aa7:da5a:0:b0:525:6ab3:dd22 with SMTP id w26-20020aa7da5a000000b005256ab3dd22mr7811399eds.38.1693853202228; Mon, 04 Sep 2023 11:46:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693853202; cv=none; d=google.com; s=arc-20160816; b=D3oVY3LNz88b9jZeju1sSzCO68Ow/MrbZYn/mBOlgbLKto6trmKgFhW6VWI5h7bKsC 3JRES0WFLSXkLqovD/UILEIYj3l16MBKNrZG3cpViNhu84blCyfMn1n0DGlqguI29G/B 0RO+V2qCCbmt4ZN+7xumwud7h4Jik3r9AhLJEdHtF8TAfDYvI7lkOL+2FWxEkMvPgTmD ZpsN6PQx+20Y0Jtal09NeOQ5k5gvYmakOsS5J+2KkTEIid28q1A9tArEkB6fxUiUw43p VMM4mQ+/wLwaXO3c0yobr3njBaHmsfQ2ONoPkx9Jgmb2wbuR+8Pq+nYFtgr/jzy87tGi 0lig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=oWTSKg5klRyqDn6khwvW4/AmDVUH0KkpGisg1ys/3Rk=; fh=Nx7oWkHkvQYnbI/T4Mf5Yy5c3UTExEmxDbOLG8ysieI=; b=NGwoQiaepVDjLlRqdjsfea8yxVzELLa0fbTP84rRcBHualkuLKAQZ5NaJr5Fe1z2Px OwM0bwdvgYUlIGkszpO7xSHiC63LjCqMVKgYwHN8AKjT6ABGgHkrkgRruoEYhlmx7JNB JvnVT2g4BQ0eg22v8te49z1Mk6CHXFudWPkmUnMEf/kpQT5CBL6sKPg+jiBKMZSVz6Qq qcfqr0NnR9FhnKGdFk1K5rp1sUv0n7eufVD/stvTaK+ljlbdQMbKFNTQGr3ZMTYIPHUe ezXhpJ8FSdxJLqScM6WzACcHe8ynSVFH+ZL+sbZ6l94yXbmfuKLe1ipogBbu5lRymsS9 RwQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KsulwJfw; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x16-20020aa7dad0000000b005221e4af120si6635825eds.84.2023.09.04.11.46.02; Mon, 04 Sep 2023 11:46:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KsulwJfw; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238993AbjIDQlg (ORCPT + 99 others); Mon, 4 Sep 2023 12:41:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236602AbjIDQlf (ORCPT ); Mon, 4 Sep 2023 12:41:35 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77961199 for ; Mon, 4 Sep 2023 09:41:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 975ADCE0F1B for ; Mon, 4 Sep 2023 16:41:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CA29C433C7; Mon, 4 Sep 2023 16:41:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693845688; bh=QZCys/k5881DjhsCryhQ5OsonD3f5ANoezrWRzQyySA=; h=From:To:Cc:Subject:Date:From; b=KsulwJfw1fmnGB81U5dkcZqDDEqBLvSqPnvq59SxngxN4pW8fjzoSqIHrH+/MuzxH PXtDijI8vgXfZ1rdaBK+9GdbbOVlHi/ZJ/09yLVMZkMyDPQa7z+uRC7DdnwNKn6sMy KqbQyHTZHNQ63BGKdv5KldNEagqa9bNqAmcdWg5/RaS3UAVGb8xCXBYLfYa1ER3NFr G2UdLF480AHjYXSOnWv7GIuirzocP2La80bevW6Db6m+58Br300n8M94fcIGRRAxm8 s+BD1Nf7CkyXtQ6hwL4Vtxi1gPwoEIzwLALnHc64Vd+2JYrKY0LxkivJxX/EwWlFNN FzBhbwXqrm0GA== From: trondmy@kernel.org To: Anna Schumaker Cc: linux-nfs@vger.kernel.org Subject: [PATCH v2 0/5] Fix O_DIRECT writeback error paths Date: Mon, 4 Sep 2023 12:34:36 -0400 Message-ID: <20230904163441.11950-1-trondmy@kernel.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Trond Myklebust In recent tests of the O_DIRECT code, a number of bugs were discovered in the error codepaths, some of which were shown to result in data corruption. The tests involved using pNFS flexfiles with 3-way mirroring, and then shutting down one of the data servers. When the data was later re-read from the server, it was shown to not match the original data. --- v1 - NFS: Fix error handling for O_DIRECT write scheduling v2 - Fixes for incorrect commit info Fixes for O_DIRECT accounting O_DIRECT locking issues Fix write scheduling issues Trond Myklebust (5): NFS: Fix error handling for O_DIRECT write scheduling NFS: Fix O_DIRECT locking issues NFS: More O_DIRECT accounting fixes for error paths NFS: Use the correct commit info in nfs_join_page_group() NFS: More fixes for nfs_direct_write_reschedule_io() fs/nfs/direct.c | 134 +++++++++++++++++++++++++++------------ fs/nfs/write.c | 23 +++---- include/linux/nfs_page.h | 4 +- 3 files changed, 108 insertions(+), 53 deletions(-) -- 2.41.0