Received: by 2002:a05:7412:f584:b0:e2:908c:2ebd with SMTP id eh4csp1923161rdb; Tue, 5 Sep 2023 08:59:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFGckBrMhlMnQUnAObvp1UKbYJgOVqbnOS9Yr2m7PjhvZwe/oTBifdx3+Sryc3NGGAXRQzi X-Received: by 2002:a17:90b:e94:b0:271:c314:a591 with SMTP id fv20-20020a17090b0e9400b00271c314a591mr12975894pjb.47.1693929549294; Tue, 05 Sep 2023 08:59:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693929549; cv=none; d=google.com; s=arc-20160816; b=cmF1mTyPU7+icz3oVkHvfSEi0jzF9vaoWbrpf0zwZvbINscAfDqc9TiZKZ3/Iv8k6L JmqiuSiNpx6pg62owL3axuzn16vOc1BkWHRPiHkEZJ/TTv3zrHYlpRfr+qkNDWybb3u/ ljvGqxac9zSQxSdZAiZr8dNgbXOlcg+wifhUwfW0yKYdngoJxGJO7USoGF1I5e2GHQrp iS//cP58dZTvwzQzrTEXTev93JWjLhpE6V2wZEh2HzYa572AIkeOszoqW96rx28rOb3q 9nufSFaaIPt/qeg+KhnTBeXnUbcwNMuDhBz9VHjLM76aoX/dVnkdZLzXOXmWrJww2jic 8kUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=8dhy+SFlkMjUsqkUMM2fT6bl5HQBOTzuf3GWZnWtcoU=; fh=Nx7oWkHkvQYnbI/T4Mf5Yy5c3UTExEmxDbOLG8ysieI=; b=xe0roCG069j8gXN3+0eEx4hAQ63rrhmlrcY71ADg0p1j9ouHFxjwfWbE4If4ibDXvU Rn6qF3jmYsFQoYUu9vTHEFNumWvNsEuxTQRsVETlMsnSU9cK4+7GL3chFUQmP/tjL4kw 3DvpHYPp3vudWsplXDFwoRzHHrUpeOmEvcmOu+2fmf8O0q1/2L08R78tiA7Z1QNsolWv qorioywAo091QM6PGwFcrvKC01ttF9vV0Q2g+GUPzkhYMJOh6JYFvAuOm44+CXxSOWdz TcTc7G2nj4ocXKJ6MNRhEhK6FJAtnB2Xpfj+3B6+CLvBkqB/Iqzg9jJTciuX/wksKJOU sjAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ivWgFofv; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p10-20020a17090adf8a00b00262e99964bdsi9792441pjv.99.2023.09.05.08.59.03; Tue, 05 Sep 2023 08:59:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ivWgFofv; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241322AbjIDQuJ (ORCPT + 27 others); Mon, 4 Sep 2023 12:50:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237790AbjIDQuI (ORCPT ); Mon, 4 Sep 2023 12:50:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC897CC4 for ; Mon, 4 Sep 2023 09:50:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6337D61853 for ; Mon, 4 Sep 2023 16:50:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9359CC433C8; Mon, 4 Sep 2023 16:50:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693846204; bh=HZLmbN0yQUAbUMrfCujn9XLM+AN/DUfi1w/lk0dvxwY=; h=From:To:Cc:Subject:Date:From; b=ivWgFofvhICObVIDHkvvQ07uH4c3gEEmtXx/WAYdQh8iiqVIS4zopQ8Rp1YPiiOoZ ICTV0tN544oU0HdyYlMCKlVOqJdKOLomMRYeMdQtZxvhQddKtWXprhouWHCfrw7w9q CwhDt8xA/kTVqwYKU2TgRPn5RT1E4D00g+EIOsnWgt3JkGAbfzjbj4NrZJ9XW+PXBG F5NhgapH84/qEbulUoRIdZXq+yFaeDF9fcUzoLoBCrVILsVLQx8WrIxFiO00GMyt5w tTX8Ad+Xx1UUf1I5EwMXSwci7ZJ3vJcWGy2wE0eDGfMPiPrenxyByiaIkesJAdej+V +CGRAtbE1jjww== From: trondmy@kernel.org To: Anna Schumaker Cc: linux-nfs@vger.kernel.org Subject: [PATCH] NFS/pNFS: Report EINVAL errors from connect() to the server Date: Mon, 4 Sep 2023 12:43:58 -0400 Message-ID: <20230904164358.12177-1-trondmy@kernel.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Trond Myklebust With IPv6, connect() can occasionally return EINVAL if a route is unavailable. If this happens during I/O to a data server, we want to report it using LAYOUTERROR as an inability to connect. Fixes: dd52128afdde ("NFSv4.1/pnfs Ensure flexfiles reports all connection related errors") Signed-off-by: Trond Myklebust --- fs/nfs/flexfilelayout/flexfilelayout.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/nfs/flexfilelayout/flexfilelayout.c b/fs/nfs/flexfilelayout/flexfilelayout.c index 7deb3cd76abe..a1dc33864906 100644 --- a/fs/nfs/flexfilelayout/flexfilelayout.c +++ b/fs/nfs/flexfilelayout/flexfilelayout.c @@ -1235,6 +1235,7 @@ static void ff_layout_io_track_ds_error(struct pnfs_layout_segment *lseg, case -EPFNOSUPPORT: case -EPROTONOSUPPORT: case -EOPNOTSUPP: + case -EINVAL: case -ECONNREFUSED: case -ECONNRESET: case -EHOSTDOWN: -- 2.41.0