Received: by 2002:a05:7412:f584:b0:e2:908c:2ebd with SMTP id eh4csp1939895rdb; Tue, 5 Sep 2023 09:20:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGL7fsMS86uDekM+V1ieTteOKdnbsIOzShFZUAYDQSD85upsayiGwGs6Ff9wwuar9xX0Flt X-Received: by 2002:a05:6402:1ac4:b0:528:90d7:a1f with SMTP id ba4-20020a0564021ac400b0052890d70a1fmr253313edb.10.1693930807204; Tue, 05 Sep 2023 09:20:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693930807; cv=none; d=google.com; s=arc-20160816; b=JXkjgkghyPLhEIF4Oz9vmJQzvvRMM5CFZrEZA4mPtpaQpDbpYlhqa3QAUmgYE1O8ud 0CXNenNRZr4JnhVEWRxAHeBIHuNEadt1VnenF2jSFiWrF+U9dXhboYyqtCqN9Pw1mLOO tnymOkQ/lB0Irt3kuXbzjoa1d56erpk+aMlKMFrhMGDh6/xTN8321BQ1W89FGl6XvYfK g/eQ7EHmzmHwTW8oCKt4asG8DDnCU3bDQN1chln6TGCU/yrvoXpP9+Bpvjm3eqkDai4g RWs82fOyzGCMgWBdBdYan6GLQJWZcF5sMHX4VWiQr5p7Ppvrsto4v1yR47YrOGfBNYSF I99g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Jfb1RFb/3yHium39m2qI+apXzhMcPSvUGa4yiW+gB0g=; fh=Nx7oWkHkvQYnbI/T4Mf5Yy5c3UTExEmxDbOLG8ysieI=; b=E/XBs0SUawvw41jmf7IojFfUHsDNNz8dMdSA9RnGswWGhIx4taQJEdh7aYxu9EP8qR CfOWjFFQo9VldPGMRAEVQl66aRCFA+5HwpuU39GmJ6yI/WHeBYH0w99DmLLaANz7a5A7 RrcP3KHNOQzNC8F5YMyFexbceTif5v8PLs31RRplrn6C2SPQDBBhjI/nDMe7rXwheinU eyh4G0X6TFJzOnrumUztQU5AnFj57ci4s7m5eYab/cHm6+2/tA1iHhWilyxPr9Sc1EjG w8Fwdw1oXboqbPdAgu8sB02lNcc3C79R6bfmSbfr0mVUB59P1QqXzhFV4W6TNF4bbZNa K4jg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Gm6La8us; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ba8-20020a0564021ac800b0052a3b1ffde5si2547364edb.154.2023.09.05.09.19.59; Tue, 05 Sep 2023 09:20:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Gm6La8us; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236129AbjIDQ4j (ORCPT + 27 others); Mon, 4 Sep 2023 12:56:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229781AbjIDQ4j (ORCPT ); Mon, 4 Sep 2023 12:56:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C9A9ED for ; Mon, 4 Sep 2023 09:56:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AF2B56147A for ; Mon, 4 Sep 2023 16:56:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B851DC433C8; Mon, 4 Sep 2023 16:56:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693846595; bh=xod9DnlEXPQJRk4FQ7h3LSZU7mxwWHPTwfH0vzmYDxI=; h=From:To:Cc:Subject:Date:From; b=Gm6La8usgb1MpznYxQrcx20Z/kCWDxjbJpmKdgLyTZoPGzcvBmhh1EzEPguVZua2o 77KaxvwoVkYYdGdYlSZu9JnHMIhTlvaqXaWnybePv8zNr+oZYsZCwUfkX3YnxXD+/f APwUmIQoPYBhbMdOUILypZPBFPYbzPy/BgCD8fWF6c4mnWUkrcl0SVH0CIG1aQDvJZ udcaAjzciTSNfjVBMM4FlHfPRxxmAV7fZ4QFcXl+sW/NWUX6/YrS5XagLlrzlF6j9U H/R58kuU0HLQOoyi1Z4AndBnYRYRDcbvqeWKJ7r1+mjEdQ3xCfE6UcTHqTji6xLzEQ IVdoRGtNu2XIA== From: trondmy@kernel.org To: Anna Schumaker Cc: linux-nfs@vger.kernel.org Subject: [PATCH] SUNRPC: Mark the cred for revalidation if the server rejects it Date: Mon, 4 Sep 2023 12:50:09 -0400 Message-ID: <20230904165009.12284-1-trondmy@kernel.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org From: Trond Myklebust If the server rejects the credential as being stale, or bad, then we should mark it for revalidation before retransmitting. Fixes: 7f5667a5f8c4 ("SUNRPC: Clean up rpc_verify_header()") Signed-off-by: Trond Myklebust --- net/sunrpc/clnt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c index 943dc3897378..12c46e129db8 100644 --- a/net/sunrpc/clnt.c +++ b/net/sunrpc/clnt.c @@ -2750,6 +2750,7 @@ rpc_decode_header(struct rpc_task *task, struct xdr_stream *xdr) case rpc_autherr_rejectedverf: case rpcsec_gsserr_credproblem: case rpcsec_gsserr_ctxproblem: + rpcauth_invalcred(task); if (!task->tk_cred_retry) break; task->tk_cred_retry--; -- 2.41.0