Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp3836487rdb; Thu, 14 Sep 2023 04:24:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEZH80dHxZbifro5Fhd66qDp9Mz9DSfYCwvWSzj71b8gtOcLMO1RrHEknExnCkASILkMCmo X-Received: by 2002:a05:6a21:4849:b0:148:3c72:4878 with SMTP id au9-20020a056a21484900b001483c724878mr4344850pzc.50.1694690663004; Thu, 14 Sep 2023 04:24:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694690662; cv=none; d=google.com; s=arc-20160816; b=eLiE+zoVAEjX04REE4A23OMMSf/H2I9qMONRrVOXYW+gjuNIoD0rvKTZp8vzlVdqlj G0KCD1CHnyxrqLja2sK0gxpzPFG2ynci3DozuAz/WQDJEac4i7NBkUTaaY/LxhPkL4Zl mOqCv49zVm+jrHtAxAdJUBfCTi7os+so/MxD66KXUZhBeSzSmafueP8ufbQvJcC7elZj TemfeLAWeSodAVpD/c+WjguGF7ebIvvqyu4B1MI7yz+gGc3ozETCshYho+lUpEGHuru6 Dp8+SiXZU2K/rNQjZTP92H+Ahror5Ud/gkxDSRwj8IUZ0eKtAlI8geA0O+OmKS9+Guyi E+6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=QJxYibQmjq+Pbg/cA03aH9CORAW2km8XuLC8t21WRo0=; fh=ggAtyYCLjQC+aEaWV6nS5QgUNtsrjVB3JQO9PZCF1so=; b=GoFvXUn7sekDJZIhthWCk22/wOxYsFSBz7l2g/w0Ic/3A0B40/eTFT7k3W86peOvSi wiyLVVNlCg70n9h3gH979urYCFW8RXAo5Szw7fuTHByQN//UwuV676sb0n+DjrRrYP4b AqHIhDilZzZg+cabJ7wh8zgkCi2qh9TFNup3EASTcD0CfybvRWA6fZn+03hSb1TUFso9 8KcuBbDkklZutdIIqZWFMoO5XlInDZEjlwErv8QBEiG5MQCAhK1+YvZ/jnjjp3wvj6rK Cl9IWMvsSDylnzmIWYXDjCm75oKN98jM7J5b2BZEcmIgj2a7/5DRMZaCLZQwaTMg+il6 JgxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b=OhhyqIHC; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id k8-20020a17090a514800b0026b7d81b779si3538252pjm.152.2023.09.14.04.24.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 04:24:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b=OhhyqIHC; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id DF1DA8326583; Wed, 13 Sep 2023 19:30:25 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232177AbjINCa2 (ORCPT + 99 others); Wed, 13 Sep 2023 22:30:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230121AbjINCa1 (ORCPT ); Wed, 13 Sep 2023 22:30:27 -0400 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [IPv6:2a03:a000:7:0:5054:ff:fe1c:15ff]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F02A196; Wed, 13 Sep 2023 19:30:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QJxYibQmjq+Pbg/cA03aH9CORAW2km8XuLC8t21WRo0=; b=OhhyqIHCwHStb3YKeZZHm1zzhR U7O739LtvvKuHLAPD7ckbdBOFedy6E2v7i0Tfx1DmJVsyfhRU/Vf9CdQ98YAdW3hZj1GxnkaSUSC+ f1GSWOIBvcn4DK3Ykh6+6pr5SEpqGerIj8wRKOY/SA9QQVjCllxI1qUJgW45jMDU6uUBo+xCxf0Y4 k5s+4wc/rQVH8gvkzFdaFjW08BguRZWF58BlkNDZ78YNFfr4eRqta88fWJjbQjSxNMTHF0eZxfoc0 alUzUlwddMgPH2Kc6JNmW0oLYbwh7FNCzEfhcmU0j2uid7Appi7wlg5hDG2mY+jkRK2sVhnOnNWGZ dH9DMfLg==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1qgc7A-005tq0-0T; Thu, 14 Sep 2023 02:29:56 +0000 Date: Thu, 14 Sep 2023 03:29:56 +0100 From: Al Viro To: Christoph Hellwig Cc: Christian Brauner , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Fenghua Yu , Reinette Chatre , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Dennis Dalessandro , Tejun Heo , Trond Myklebust , Anna Schumaker , Kees Cook , Damien Le Moal , Naohiro Aota , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org, linux-hardening@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH 13/19] fs: convert kill_block_super to block_free_sb Message-ID: <20230914022956.GG800259@ZenIV> References: <20230913111013.77623-1-hch@lst.de> <20230913111013.77623-14-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230913111013.77623-14-hch@lst.de> Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 13 Sep 2023 19:30:26 -0700 (PDT) On Wed, Sep 13, 2023 at 08:10:07AM -0300, Christoph Hellwig wrote: > -static void affs_kill_sb(struct super_block *sb) > +static void affs_free_sb(struct super_block *sb) > { > struct affs_sb_info *sbi = AFFS_SB(sb); > - kill_block_super(sb); > + > + block_free_sb(sb); > if (sbi) { > affs_free_bitmap(sb); > affs_brelse(sbi->s_root_bh); Yep, that's printk + brelse()... Could we have that block_free_sb() (an awful name aside) done after the if (sbi) { ... } there?