Received: by 2002:a05:7412:31a9:b0:e2:908c:2ebd with SMTP id et41csp4959087rdb; Fri, 15 Sep 2023 19:16:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH4drfg7XaiQxuUkRPI3wr+WcvFTrjiNTYB6u5ecyNpFLdFAvO9JMGp5PFEZjyntHAXXpJm X-Received: by 2002:a05:6a20:442a:b0:140:3cc7:b3a6 with SMTP id ce42-20020a056a20442a00b001403cc7b3a6mr9370423pzb.4.1694830581205; Fri, 15 Sep 2023 19:16:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694830581; cv=none; d=google.com; s=arc-20160816; b=jd5HU/dU1ZtgvE37C7q5lVuJCX7hYHGqqI/GzF9XyGppIXvV/JmrpjO+DeF+VVDbM1 /8fn7VBUtWoD76TMgXl0ELCQYGdLSQPCeuIM0f6pAzl/ksgWGg1yHFpAtWgwWS4iiVxE eZGpep0X4ELzLoJjp/pqpYHvadaZW1PhFkCRKb8cR6x+naRgt0FerYOg8tS6j/z8Ftp9 sO1N6gDdY9cr7q6ztk5j+3qtdRulP61Wb0lANtVkwfJeZeE2/naleHJGRABVe7+s6AJ+ h+qNowWHLXmvX4hmp2K6vOwwx6b5EmGMgr/PtE5oB7hgNWtpphpRxl5ska6P3+/ze2Jd NE7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=4SLe61c41MpedLgHIG37zN0xCNARe7YkFYGtI+CaxPE=; fh=1WDMMyAAh6w9vXHaxzyBl4u/phHtLJIokK7FvfRUgb8=; b=mvS3TUmCogVms/y/ThRifTQlAc/BnYJRKg8MiiedR1cmXmPWNpk1V+S/CnWaeUmH7C ffReFz1/JezybktAzK2G0gX71gJYHxUq7sks/+WR3Az7pqm3KYm0g5kRm6MYZX9GlUaj zEYHc4ZgLdoJQMppj5Nwo6WRKorvwKptxdz5TTEeWz8unczdDv01qkB12qYUyxABHSCG EhcpnHrJEFdc68qzs80ujkNTdw3O3Lt/6LzacyTyjdo7iotcIuxBdDVuzY0U+aBHHOFz Bs6kTYYBno3ze7fcs760wjIpv6w8eBy6JQ3pZ+nhl/g4LD5o/secSAUxgZBeLvZqR9hq 5Ssg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bI0g5tGc; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id e1-20020a636901000000b0056956177395si4055821pgc.512.2023.09.15.19.16.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 19:16:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bI0g5tGc; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 74DED80B2876; Fri, 15 Sep 2023 11:49:01 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236598AbjIOSse (ORCPT + 99 others); Fri, 15 Sep 2023 14:48:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237019AbjIOSsc (ORCPT ); Fri, 15 Sep 2023 14:48:32 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AF50744A1 for ; Fri, 15 Sep 2023 11:44:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694803339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4SLe61c41MpedLgHIG37zN0xCNARe7YkFYGtI+CaxPE=; b=bI0g5tGc4AAOsq8lRnxbNkNT3yJhXkqXZcTReVPgrv49l6tZ8QXP58JeL5TMR3RRT9ehAb hq4J8DrlUEZPHGm0NWI42HzmOna1Ls3R86sqSZIN+PPUYtWyhfwNgjcQVB0WkJK7xediZa 6iV9K+T5nowzz5kxCCxNR4Gn2AI5A7A= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-82-3n0IUkYjOfadNms_TYhmoQ-1; Fri, 15 Sep 2023 14:42:17 -0400 X-MC-Unique: 3n0IUkYjOfadNms_TYhmoQ-1 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-68faf559913so2106943b3a.0 for ; Fri, 15 Sep 2023 11:42:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694803336; x=1695408136; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4SLe61c41MpedLgHIG37zN0xCNARe7YkFYGtI+CaxPE=; b=mQgchJj+lOv6hvxVCIHdmbqnRdGDo3drDxwRrvbj28ax03+BgILQOKgdwX8JCNSpIL nEAJxEaoRqSVAnEojNkXrQOkDkvjGeDHzwW5OBON2LT4yfHGqakQxgLeMLz7ycyo+bnX e69GeD1/aLqWLXNZXI6rQfVsKknply3v70zFo+NeT3FmjcLag3DaWO9A7PNl8pe3DKJf 5SRY/DU5YUGVmQ3t45g+qcWDwz1/Y2FWCjOMLm1LdoSy2k1nD2Mjz/0znkyA31w1R7jm PIgND8meTk0eRvEFKz9H+5jU8MtFRQkhsMWd8hrOIURYymEAmCnXnGjopchkeputSCuQ m5SQ== X-Gm-Message-State: AOJu0YxRotFxyu134oq5NMBq9+7tUDJeVP81+jmv0lFuevbNiKgES7wg VmzymZBp+tR7HC65zDIeecBg2julbXmBrMI+/UUQdxp9J/dk0FwEJlzx1BXqwS6vejQz7B6HPv9 VOn3T7jhdrcswcxpAYlqJ8JGGvpCYrQAAyN3NoKqSP7nCrLU= X-Received: by 2002:a05:6a00:3688:b0:68c:59cb:2dd9 with SMTP id dw8-20020a056a00368800b0068c59cb2dd9mr8161780pfb.1.1694803336172; Fri, 15 Sep 2023 11:42:16 -0700 (PDT) X-Received: by 2002:a05:6a00:3688:b0:68c:59cb:2dd9 with SMTP id dw8-20020a056a00368800b0068c59cb2dd9mr8161770pfb.1.1694803335918; Fri, 15 Sep 2023 11:42:15 -0700 (PDT) MIME-Version: 1.0 References: <20230608214137.856006-1-dwysocha@redhat.com> <3629819.1694784702@warthog.procyon.org.uk> In-Reply-To: <3629819.1694784702@warthog.procyon.org.uk> From: David Wysochanski Date: Fri, 15 Sep 2023 14:41:39 -0400 Message-ID: Subject: Re: [PATCH] netfs: Only call folio_start_fscache() one time for each folio To: David Howells Cc: linux-cachefs@redhat.com, linux-nfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 15 Sep 2023 11:49:01 -0700 (PDT) On Fri, Sep 15, 2023 at 9:31=E2=80=AFAM David Howells = wrote: > > Okay, this looks reasonable. Should I apply Jeff's suggestion before I s= end > it to Linus? > > David > I will send a v2 with Jeff's suggestion added, as well as Reviewed-by: Jeff Layton Link: https://bugzilla.redhat.com/show_bug.cgi?id=3D2210612