Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp122542rdb; Mon, 18 Sep 2023 09:51:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF1+rnvZRAOfzvU1LANwn340fp84IP3F5Fm++9syvGIRizXEiB9LynQXwjU7grC/dQU5Lxl X-Received: by 2002:a17:902:7202:b0:1bf:22b7:86d with SMTP id ba2-20020a170902720200b001bf22b7086dmr7108348plb.3.1695055868984; Mon, 18 Sep 2023 09:51:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695055868; cv=none; d=google.com; s=arc-20160816; b=khJ4XzP/IL4n8jhcnboo2RauzgQgzNY7GdEYJHK4/CL09AsShSdZ6aeN3i+9lQb8MF ROXsq36YGcvtp8lJvyiouJbVzC583VZGSIt8GmkkwsFa3O8VqL5MJpOWnYYznuZqXUNb rMbj0gujZnzSwcetVYVxFWfMIhhcq0o4KG37aoDLWOXRYfZeOSo2c+QGzEqg2Dfn777F cVJ4xS6h0bD+YJ8lk03qNck3DxEPTygCncdbgsTtTzsY2a4K49AvNTR2CYe98/7jKQTo wUb2T0lZe+oV75BSc4UKq5Za2OygsXqunKfYMHVxf4fKlGcd3Us1QZEsbBKC26O0M8Bo uL7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=6cFuRXsDrcIxBwlF4cwnBt0Jt6BClm31zVS7vN6l1Tw=; fh=jnlnz5Zoc1OgTt6xeCzDTEgiHqkpuGFtbm4VYen0YZ0=; b=ZYW/+bw1OTkLMRRkUtwXSlhPBxFHd42F7/CmPH33/o39LcZKO8GgAAu4pUSMD9m3Hs KvPgfmTlIWTnfi3QigsYz3LgrRGuWQpheFoFQoTI3bC7+gW86TE2HQmRrMlsNZiOoGBr NqKMXTedVVftxHsotfXceXFN6YiYgiDJTRl3yG90sm2ELJ0o137eLZXSLqFiXfL8ghf/ xqK2Ndn0GKcosN2RGCTU/zWrVjVZLMeFZ8kSd5Ioxd08oBvM0WV5OpOiljFGQJ2GxuRZ b08/90QtdXUK/V8wNBdL7v3FqYZDOunoIRTzoETRiMpNAq2tonvgUGs122NZvPJRt9fH Cz/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Iq07Xxq2; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id q16-20020a170902dad000b001badbe8e441si2495023plx.106.2023.09.18.09.51.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 09:51:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Iq07Xxq2; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 70296801B800; Mon, 18 Sep 2023 09:10:01 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229501AbjIRQJ5 (ORCPT + 99 others); Mon, 18 Sep 2023 12:09:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230054AbjIRQJN (ORCPT ); Mon, 18 Sep 2023 12:09:13 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B242C49F3 for ; Mon, 18 Sep 2023 09:07:51 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94C61C43215; Mon, 18 Sep 2023 15:42:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695051730; bh=Lg5m/KvhE4UCtOEJ6Q1ndDQoWhkmH97hPVsIEtvEHU0=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=Iq07Xxq2NIbUcrz2+qdmIiESFJL4SOHRc+DDmOn7MftZ4fIQ8wjuN30a/Gp9+UQS2 /7LVyaKwGuutNjKbynlskaz6qlhFqakFgCMISKmKIin52FoQX1vZyaLYzA1w1FPVX5 U3kRn7ktN0CkOlQTFMMqLQAQa/lTRIXks9D6TmqIfTeNTpcMJ9yQ0PbgUytbZLbaZf zRWRmri4kwgQc9b/8iYIAIQwaT1Qtk8o65mVni0rg/FHK1uLoF3TGhEBbUOLl2z3EA Oss4EJyXTAJfVmHUsY+/zTY69zpUuKi+5KzfhSfLiFviGgThxcRF8DgysGkL0gTkqR rGx7cklAA7VFA== Message-ID: Subject: Re: [PATCH v2 0/2] NFSD: use CB_GETATTR to handle GETATTR conflict with write delegation From: Jeff Layton To: Dai Ngo , chuck.lever@oracle.com Cc: linux-nfs@vger.kernel.org Date: Mon, 18 Sep 2023 11:42:08 -0400 In-Reply-To: <1694648301-26746-1-git-send-email-dai.ngo@oracle.com> References: <1694648301-26746-1-git-send-email-dai.ngo@oracle.com> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 18 Sep 2023 09:10:01 -0700 (PDT) On Wed, 2023-09-13 at 16:38 -0700, Dai Ngo wrote: > Currently GETATTR conflict with a write delegation is handled by > recalling the delegation before replying to the GETATTR. >=20 > This patch series add supports for CB_GETATTR callback to get the latest > change_info and size information of the file from the client that holds > the delegation to reply to the GETATTR from the second client. >=20 > v2: > . fix kernel test robot report of missing function parameter descriptio= n > of nfsd4_deleg_getattr_conflict() >=20 This all looks good to me. Nice work, Dai! Reviewed-by: Jeff Layton