Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <036ba970-a302-097a-1155-881f4ec3f8b8@oracle.com>
Date:   Mon, 18 Sep 2023 11:49:48 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.15.1
Subject: Fwd: [PATCH v3 1/1] nfs42: client needs to strip file mode's
 suid/sgid bit after ALLOCATE op
References: <1692918707-30648-1-git-send-email-dai.ngo@oracle.com>
Content-Language: en-US
To:     Anna Schumaker <anna@kernel.org>
Cc:     Trond Myklebust <trond.myklebust@hammerspace.com>,
        "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
From:   dai.ngo@oracle.com
In-Reply-To: <1692918707-30648-1-git-send-email-dai.ngo@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SCtYdFEzL3Qwei81YnliVmRXUFRrbXN2WXNZb3hkdXdYbi9WaUxYOEwvRnBT?=
 =?utf-8?B?VFdvY1pMWDl1S0pSMmxmTFk4VFN4OFJyRlZ2MDh0ZG54ZmR6ZEZJeEtHZXdU?=
 =?utf-8?B?T1F6SG9HKzNwN0ZZT1NxVm9CcUwwM1crVVVzU1JuVElXYjR3cTdBSjRGZnFo?=
 =?utf-8?B?ZE1qeFludFZZZE54ZFk5VjJGWDdiNUlYZUZpaEFZeEZkYi9mKzI3Ym1vN0tt?=
 =?utf-8?B?d3Y0d2hRRUtZT3JDWXFXenNIUG0vR1dtNEEyZHVSNlNBcnJQM20yVWp6RC9B?=
 =?utf-8?B?SENBLzlIZHNyWjFEWkdIWllLc3RyREtDbGd0QlFCTlBLNjJIcTdmdUU3R2cv?=
 =?utf-8?B?djRpRnJZSkxHKzkxZnd1SSs3VEd6YTBXMFlEdDBoRmE5Z3l2dGxJQ2NLWVJQ?=
 =?utf-8?B?UEdwVGpwQldkbUJEUnBGT3lVOEFjclZqZ1l2TkxMWkw5eXE2ekRhUWwyaHhz?=
 =?utf-8?B?OEF0bUp3NTJiV2RQZExIcXk2UGJJOUZ5UXdtZFJ0dUR2Y1BINDFJekxqaXFn?=
 =?utf-8?B?dHNZUUhodGphN1diTGUvUjhkbFV6V2ljT2EzMTFCVEl6SU9PNExOdUJBS0xi?=
 =?utf-8?B?aEpkVEsvdWdvR2RHV3pJWU1NQ0lqcGlKcXUvZDA0YnBFUHJPaGw3UWJOQTVB?=
 =?utf-8?B?YTFyUk52VlhhejRXeWFXNTRuY2hnZFczTGdLaG81dDZPMXF0a0VIRTJHQ2Y0?=
 =?utf-8?B?QjU3Q3FPazFEQi9YQTFUZG02a1NRVEJRT2JOVk5YcFovUkx3c2Z3ZEVZL3NC?=
 =?utf-8?B?WHRYbytQSm5oUEZUb1hxWVdRSlV5SWtOcDRwU2Y1YUlnZFhLWWVSWStyNW8y?=
 =?utf-8?B?RFFSelo4b2RpNUtIcjhXdkp2S2tCRFZQVjl4TDc3ZFMxOEM4R1VtNklPM3Zy?=
 =?utf-8?B?bFJQUlVoZVhkOHEwSk9jVWN0ZGNFdHgxdDNVSGg0dFUvcCtweFE5YVZJR1gv?=
 =?utf-8?B?VjZDL0xFZEtSZW1tdU1aYXRRZVJHNHd3QkZGMUpLVTVOeTRXY3AvK3ZONWxi?=
 =?utf-8?B?LzMzN0xxaWxhQ0w1S1BteEx0R0lNWlNBWG9RL3RROWNQSXp2aFZ1aVJHVXph?=
 =?utf-8?B?UFhZcnVJbE94VWc5SkR1TkRDTWxyMU9yNXkvT2RmSTdrZHZxa3pUY1NqdzFU?=
 =?utf-8?B?SW0ybVBUR3pacXdzTkR6a1RvNWMrbXU3bVk5WmNEWVFmODhBbzA2cXdnQ1dz?=
 =?utf-8?B?bUJ3OTFTRVQ4WE45VG90R2l0b0xZZHVsbzA5aHlMU2dQWWRKdUlDa2x3bTRz?=
 =?utf-8?B?Y3RFem5qb3BOdjlYU0JGaHMwMU41eFAwZE9SMFdEZTVtUmhYRHFLRnE1blZQ?=
 =?utf-8?B?Mkh4Nm40OHVJK2JDTXlUcnoxVXgrVXE4OXRJNCtUbnNNMzB2SStERUZWY21r?=
 =?utf-8?B?Y3M3OXRNZ2YzN3pLbWFiVk5PVSs4MC90MTNQYkorbEEyaHI0RDNnNzlQa1Np?=
 =?utf-8?B?RTFES3JIaDBoTXNQQWU3bjVjRGY0UWtpbVR5UkNqL21jWE1uUE95cVY0dWRG?=
 =?utf-8?B?ZUM5aVNFRXN4WEU5SXZhRmtJUVpTaGJ4T3NMNkhlb0l4cURGWGpUNm9WRG43?=
 =?utf-8?B?cWxVZDI0KzR0OHJqc1lYRlZiUGY5eUU1UnZWSzNLNVI3VFQ4UTFJWmlOb1Vj?=
 =?utf-8?B?SFQ0N3Q4d0kyM3Y1cVhENnR6a3Q1VHRXOUU5WVdpc3pLcm05UzFjVWNqeHFz?=
 =?utf-8?B?bG9xSS9LTmhLZEwyNzNQdCtkOVlGNW9pOEZtY1ZqU1Q2d00wT1JhTHU4Rksv?=
 =?utf-8?B?RzRSajI5ZmNTb0lTNjRMelViV29YSU9lWnozdGt0bHd1NGtma0gvd2Z5KzZz?=
 =?utf-8?B?Uk9FMjBTZldmNHJFbUlOQWowbGw3dDVTQlE3aWI0WGswWkxvZzl2enk4eVNX?=
 =?utf-8?B?U3JsaHlVUk9jVmRYaHIyOTd3bUZTOHh3ajBrMjA5QlU1Q1ExTDAyT2FPbHpM?=
 =?utf-8?B?R0Q1SWhPRmdxYlFJdUhyM01nbzg2aHBPN1hZWElEQWlqRXVXSmtQU3RDRG94?=
 =?utf-8?B?Z1NOMEdQYVh5aUwrbkFGa3hRWGdYYXRobUllUm1BSHRNYXdXUGhqZExHL1lZ?=
 =?utf-8?B?ZHFXRHUyRzdVOWNLY3pxTUcxWjJ4THFoTnoyczVUTHN1WkhVS1EzVzA2L2Mw?=
 =?utf-8?Q?noiZwYAhw2ZRJgErIafhKwTe6?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: g1KUH0aPwN7Is3RCMXTOZFScju982jgm76xbxUUmRAu9ziD159cw4/4ttIZFfUlOoSWIOjCKLZFHS91bHpZKB2M6Q0lEpJDdcFDbTQHa79LOMeVEHqB+QbeeznlpdanmzCtCzrkP/h+RUr60/xNRv0LWHGgB0AxGDlEOiPy0G2vKxBz7Ift6h6CX42uJ4BMCe+dxThbZFv4aEh/Rs4klQxagfP+ndMcjiGxyG1wM4pIGwjk6LO5yDMHNvILqOPguKcIBM2Q0v8mrCz/pTNcdZ7bzO6mV2XTuMHu1YCoQ4WYGWn3MqXBquU06rWeezOcCTzeerP3hkD7P3FzE2T/O4Ppven/oLfWRNu4wYnyVUCdJKVZfGknQGXQnJMc5FDNFQcQN/Ov20JIveONC5khVseHpb3EYVP9eNapwx9orJYiXNsVremwVJX5A1U1fF6gZarzraNTpN9BuKul3tViE8wBp0MbQNG3GRMS5ZAcocyWS3yOQFucThPgZAH+xcdeZYNcOC4iCi1WEpoqhTBfz+GcRTEHbRvjMVr34Ecy3aHyBf9jrJJiMC4jqxDdDm3qEoKLgxkkjTv2m0lNnTaC/5bV2xMRDf/5GVMq3jIpbPim6YiSUJb1w8IxpLSzX+MMsOxo+enUEWmPAvyMq9+zGLwCJzeEcfCd+m+eOD49mmZcnZlJ5KKzTK/rk+eItOVotRUK47fnvFAP+TQFalyS1qxRhJ+BnQ6RAiMznScofHu725WWO4YdkjBRPk/MC56H4vUoccf92+AqrVf1TLAUNWWSzz4UXC3MNEJjdoZHORBxhFIaLWTqqfdUEQN6RVAVeQuF9GIJzncrPOys/SaEUig==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c160fad-d29d-4de3-5f07-08dbb8780aff
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4257.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2023 18:49:52.6823
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mKBhCkxh1g7ZLW+8Kk8yo2aPYDLFmnVQ1pRZ/X/Ja5FFTkavRWTGjgjNO3tmROWytj7/VZPRCk9vgl9NtxJTbA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4254
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26
 definitions=2023-09-18_08,2023-09-18_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 bulkscore=0
 suspectscore=0 phishscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000
 definitions=main-2309180165
X-Proofpoint-GUID: rgFpMMa6mGMtg2rUTNPZgPQg01avKp81
X-Proofpoint-ORIG-GUID: rgFpMMa6mGMtg2rUTNPZgPQg01avKp81
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 18 Sep 2023 11:50:18 -0700 (PDT)

Hi Anna,

Was this patch rejected? The fix was suggested by Trond.
I should have the 'Suggested-by: Trond Myklebust<trondmy@hammerspace.com>' tag.

Thanks,
-Dai


-------- Forwarded Message --------
Subject: 	[PATCH v3 1/1] nfs42: client needs to strip file mode's 
suid/sgid bit after ALLOCATE op
Date: 	Thu, 24 Aug 2023 16:11:47 -0700
From: 	Dai Ngo <dai.ngo@oracle.com>
To: 	trondmy@hammerspace.com, anna@kernel.org
CC: 	linux-nfs@vger.kernel.org


The Linux NFS server strips the SUID and SGID from the file mode
on ALLOCATE op.

Modify _nfs42_proc_fallocate to add NFS_INO_REVAL_FORCED to
nfs_set_cache_invalid's argument to force update of the
file mode suid/sgid bit.

Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
---
fs/nfs/nfs42proc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/nfs/nfs42proc.c b/fs/nfs/nfs42proc.c
index 63802d195556..9d2f07feeb29 100644
--- a/fs/nfs/nfs42proc.c
+++ b/fs/nfs/nfs42proc.c
@@ -81,7 +81,8 @@ static int _nfs42_proc_fallocate(struct rpc_message 
*msg, struct file *filep,
if (status == 0) {
if (nfs_should_remove_suid(inode)) {
spin_lock(&inode->i_lock);
- nfs_set_cache_invalid(inode, NFS_INO_INVALID_MODE);
+ nfs_set_cache_invalid(inode,
+ NFS_INO_REVAL_FORCED | NFS_INO_INVALID_MODE);
spin_unlock(&inode->i_lock);
}
status = nfs_post_op_update_inode_force_wcc(inode,

-- 
2.9.5