Received: by 2002:a05:7412:37c9:b0:e2:908c:2ebd with SMTP id jz9csp1459326rdb; Wed, 20 Sep 2023 09:37:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHzl+xcVG6I+WXHdu0vDqmcnugSwRKwWD3ggF3Z7ET+gbxwP4tiN6NHiIXH/rSJcnbBEryc X-Received: by 2002:a17:902:7fc4:b0:1c0:bcbc:d67 with SMTP id t4-20020a1709027fc400b001c0bcbc0d67mr6524905plb.22.1695227850064; Wed, 20 Sep 2023 09:37:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695227850; cv=none; d=google.com; s=arc-20160816; b=t52B4yzJv65j612PIaiaLp6rpgZdAavK7tJXDoCadUZ/+2bR+2A5RdAn3xb8rg7Egp RDrx+VJX6Mj/4LCwsIugdkU+Mo8l62c5qsD546iT3ME40obQaZ4w9JTVs8Jd73wtOHvU YDHE4RnrXtctsxdrQS/1cNaThy/ItvQpVlFUIB3Wla4/bJdroL0tW15113IkEIVJ3UQx 2GSr1Rdy5+j8sw165gPuGyKuBDYzJCdcujvRtFsYyCMK6N+jrAiiUW1CwrQBBZ5tHz0E KyZXaO46SmPUuRJ6xV8hgFPed7lwUqeG6+lzHj45V8VVmPDvM3CtW76I0YZbekt0iFGO Oq2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=Z07gJ0ljk8a9zukVNTeRislBXMh7pJ7EEuF8a+v+/FI=; fh=qqhVbgRpz4JZJbJHQF6nRcwcgVw5bilhzjePFk6VgT8=; b=zjZYq5yjEyEo59/r21B09LoeufFBTkbpXIgc3ffa983WzQhIJW7tjWxnvOOVk2Em75 Fnhww/dWu4uHO4A6zubwHyJQGmZuNjBaaeCEqVUBP0B2kiAvRqGhJs/BT7CLsUIFYcna d0yyHvBxLz1tj/jvj1mLWBjx74b3oJOdaDd53f0jVGhpnpHdhzfJ7RgBK0ZCDHc27S+l 2/rmFLvu+z2cUgWqzMqNLn/YX4rxd2bshaTYur52CRl96+ZV63lDQK4gWfNBLPCdD1J/ o0NksnRdplz1riObyWqy8lPlyMwcgO5LBvlNCq9qK0Re5uUDZ5MQ0/L9xFDPXy6bxD+U Tq1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=cPiRr5Nl; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id u12-20020a17090341cc00b001b801bd7fbasi12479091ple.417.2023.09.20.09.37.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 09:37:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=cPiRr5Nl; dkim=neutral (no key) header.i=@suse.cz; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 40DA58029570; Wed, 20 Sep 2023 08:30:49 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236641AbjITPar (ORCPT + 99 others); Wed, 20 Sep 2023 11:30:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235301AbjITPap (ORCPT ); Wed, 20 Sep 2023 11:30:45 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D5F58F; Wed, 20 Sep 2023 08:30:39 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3EDCD21F9F; Wed, 20 Sep 2023 15:30:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1695223837; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z07gJ0ljk8a9zukVNTeRislBXMh7pJ7EEuF8a+v+/FI=; b=cPiRr5NlB4Iwub7EwKz86boVSJQJZ3WLxzLaU6G09EfO4FmtVOdy7KUFneBvjrGmUR3ITh 2SAzepsqhIpBmvq/dM3lwFGS4jeZb1JiYpwLyM/YRSlBcScjreBuxS42wYeBxMo6k0JIzb vOOpZeXkJqjpWBWmAFVZOTXkw8HJ8lk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1695223837; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z07gJ0ljk8a9zukVNTeRislBXMh7pJ7EEuF8a+v+/FI=; b=6KZkGGsMv2dh1rvGNnyToBfPP9oSwDD0PDv8XeIzbn7pcxdfbwlBblC3C43EGbanxkRyi5 mASfcKX9dgdX2bCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 29F7813A64; Wed, 20 Sep 2023 15:30:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Fng8Ch0QC2WORwAAMHmgww (envelope-from ); Wed, 20 Sep 2023 15:30:37 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 97616A077D; Wed, 20 Sep 2023 17:30:36 +0200 (CEST) Date: Wed, 20 Sep 2023 17:30:36 +0200 From: Jan Kara To: Christian Brauner Cc: Chuck Lever III , Jeff Layton , Jan Kara , Bruno Haible , Xi Ruoyao , "bug-gnulib@gnu.org" , Al Viro , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Chris Mason , Josef Bacik , David Sterba , Xiubo Li , Ilya Dryomov , Jan Harkes , "coda@cs.cmu.edu" , Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bo b Peterson , Andreas Gruenbacher , Greg Kroah-Hartman , Tejun Heo , Trond Myklebust , Anna Schumaker , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Kees Cook , Iurii Zaikin , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Richard Weinberger , Hans de Goede , Hugh Dickins , Andrew Morton , Amir Goldstein , "Darrick J. Wong" , Benjamin Coddington , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "v9fs@lists.linux.dev" , "linux-afs@lists.infradead.org" , "linux-btrfs@vger.kernel.org" , "ceph-devel@vger.kernel.org" , "codalist@coda.cs.cmu.edu" , "ecryptfs@vger.kernel.org" , "linux-erofs@lists.ozlabs.org" , "linux-ext4@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" , "cluster-devel@redhat.com" , Linux NFS Mailing List , "ntfs3@lists.linux.dev" , "ocfs2-devel@lists.linux.dev" , "devel@lists.orangefs.org" , "linux-cifs@vger.kernel.org" , "samba-technical@lists.samba.org" , "linux-mtd@lists.infradead.org" , "linux-mm@kvack.org" , "linux-unionfs@vger.kernel.org" , "linux-xfs@vger.kernel.org" Subject: Re: [PATCH v7 12/13] ext4: switch to multigrain timestamps Message-ID: <20230920153036.pfg5h4aoed6ua6s3@quack3> References: <20230919110457.7fnmzo4nqsi43yqq@quack3> <1f29102c09c60661758c5376018eac43f774c462.camel@kernel.org> <4511209.uG2h0Jr0uP@nimes> <08b5c6fd3b08b87fa564bb562d89381dd4e05b6a.camel@kernel.org> <20230920-leerung-krokodil-52ec6cb44707@brauner> <20230920101731.ym6pahcvkl57guto@quack3> <317d84b1b909b6c6519a2406fcb302ce22dafa41.camel@kernel.org> <20230920-raser-teehaus-029cafd5a6e4@brauner> <57C103E1-1AD2-4D86-926C-481BC6BDB191@oracle.com> <20230920-keine-eile-c9755b5825db@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230920-keine-eile-c9755b5825db@brauner> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 20 Sep 2023 08:30:49 -0700 (PDT) On Wed 20-09-23 16:53:26, Christian Brauner wrote: > > You could put it behind an EXPERIMENTAL Kconfig option so that the > > code stays in and can be used by the brave or foolish while it is > > still being refined. > > Given that the discussion has now fully gone back to the drawing board > and this is a regression the honest thing to do is to revert the five > patches that introduce the infrastructure: > > ffb6cf19e063 ("fs: add infrastructure for multigrain timestamps") > d48c33972916 ("tmpfs: add support for multigrain timestamps") > e44df2664746 ("xfs: switch to multigrain timestamps") > 0269b585868e ("ext4: switch to multigrain timestamps") > 50e9ceef1d4f ("btrfs: convert to multigrain timestamps") > > The conversion to helpers and cleanups are sane and should stay and can > be used for any solution that gets built on top of it. > > I'd appreciate a look at the branch here: > git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.ctime.revert > > survives xfstests. Agreed. I think most of ffb6cf19e063 ("fs: add infrastructure for multigrain timestamps") will be needed anyway but there's no problem in reintroducing it in the new solution. I've checked the branch and the reverts look good to me. Feel free to add: Acked-by: Jan Kara Honza -- Jan Kara SUSE Labs, CR