Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
From:   "NeilBrown" <neilb@suse.de>
To:     Chuck Lever <chuck.lever@oracle.com>,
        "Dan Carpenter" <dan.carpenter@linaro.org>
Cc:     kernel-janitors@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: [PATCH nfsd] SQUASH 8dc9e02aed76 lib: add light-weight queuing mechanism.
In-reply-to: <8e9f5845-0d9c-4d50-b2e4-5c1cd622a71c@moroto.mountain>
References: <8e9f5845-0d9c-4d50-b2e4-5c1cd622a71c@moroto.mountain>
Date:   Thu, 28 Sep 2023 08:11:52 +1000
Message-id: <169585271242.5939.14975098525477744646@noble.neil.brown.name>
Precedence: bulk


Remove assumption that kmalloc never fails.

Signed-off-by: NeilBrown <neilb@suse.de>
---

Hi Chuck,
 please squash this into the relevant patch - thanks.
Hi Dan,
 thanks for the review!

NeilBrown

 lib/lwq.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/lwq.c b/lib/lwq.c
index 8a723b29b39e..57d080a4d53d 100644
--- a/lib/lwq.c
+++ b/lib/lwq.c
@@ -111,6 +111,8 @@ static int lwq_test(void)
 		threads[i] = kthread_run(lwq_exercise, &q, "lwq-test-%d", i);
 	for (i = 0; i < 100; i++) {
 		t = kmalloc(sizeof(*t), GFP_KERNEL);
+		if (!t)
+			break;
 		t->i = i;
 		t->c = 0;
 		if (lwq_enqueue(&t->n, &q))
@@ -127,7 +129,8 @@ static int lwq_test(void)
 			printk(KERN_INFO " lwq: ... ");
 		}
 		t = lwq_dequeue(&q, struct tnode, n);
-		printk(KERN_CONT " %d(%d)", t->i, t->c);
+		if (t)
+			printk(KERN_CONT " %d(%d)", t->i, t->c);
 		kfree(t);
 	}
 	printk(KERN_CONT "\n");
-- 
2.42.0