Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Thu, 28 Sep 2023 10:08:31 -0400
From:   Chuck Lever <chuck.lever@oracle.com>
To:     KaiLong Wang <wangkailong@jari.cn>
Cc:     "jlayton@kernel.org" <jlayton@kernel.org>,
        "neilb@suse.de" <neilb@suse.de>,
        "kolga@netapp.com" <kolga@netapp.com>,
        Dai Ngo <dai.ngo@oracle.com>,
        "tom@talpey.com" <tom@talpey.com>,
        "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nfsd: Clean up errors in nfs3proc.c
Message-ID: <ZRWI37mzhRaLWIns@tissot.1015granger.net>
References: <10df416a.8a7.18ad9b33756.Coremail.wangkailong@jari.cn>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <10df416a.8a7.18ad9b33756.Coremail.wangkailong@jari.cn>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aeBC62sxPwoLZaz1sNWggaDhJtIwa7KSQKq8+NLvH8YG3K7pqdj1Eignm/9s?=
 =?us-ascii?Q?kT+Ns9UHGlmNVcr9MYrVzAhKinFOH4bjRPR207KoWtHbuP+Pz6L0zMeTPDXm?=
 =?us-ascii?Q?Obp0QyLoee8qpGYavpVbDd1KYrXqtU5BlhH5+CEHlu6IM04GPDOEuBqmMGSI?=
 =?us-ascii?Q?VvzP3I2pYXlslS2EQWF/ZrxQ+M3S8Qol0epFdRXYrEsFyJnzKBdYBe8eICiF?=
 =?us-ascii?Q?bIEmX9NeIq97GnB+Wan/bSQ2ZupMoxbFp+0/+//CVPF4Q3X6ffAwzUnqozfJ?=
 =?us-ascii?Q?H2MwZL0wkPmaR2vxyp+7kZJ+38RV1fWbCbpfx3PNffya2/Wy1nhPloQl/M/W?=
 =?us-ascii?Q?TqhWLa6mSrcEcqbMMls3vhoM5GVZgEpREGoSUqvF8brsJR1o8s29EFZP+5yq?=
 =?us-ascii?Q?nCw2cbr7FUwCKUR4Gz9KsYkw318NgwgAEObkcKREzHZybj9rS+hMbSZFXLoW?=
 =?us-ascii?Q?GlgwjZhh8GT5vKmtplE1nNp0VFU+qqKxmNIuhoHu+Pu5kk/FkcbpYsmoA359?=
 =?us-ascii?Q?7GyjnEZfh9deqxqKpxgiGp0KIYVZRZMgtMgUXr8sarqZkYLaXN+Jnyv4MRgc?=
 =?us-ascii?Q?+GU0ZFsXw5CyAjTk/2A3IkMGeWl7a2U8MLMFGo/XS8TIBW2UFk0+DBNFwlua?=
 =?us-ascii?Q?STTB8bDan5wFr0RIPDtY1QAq1BsQ1bTLcnvsr4Ag+306DeePEJRKw0NNRk/x?=
 =?us-ascii?Q?u4OL3CTUq7Ik1K0i5M+hi/Dkdd22b7rWH9jV7LAvb6IwRTAzUQbGZulDjCaM?=
 =?us-ascii?Q?olaotOE9riAjB/rfu+ELN5UY0iYqKQNHsBQoIM/BLTZNfmUIGwudhJrdnXX5?=
 =?us-ascii?Q?86CuuR3bL2hVOGKui4VOMN1PsdND+mWMzyL21fb46SX0ahrMkZU4jTbFJrSS?=
 =?us-ascii?Q?6g9WYl0aJczN16Jr3OcrlYGSslUJ3TY6Ux5Z8ye96Sy/e3PvgByoDLqfWvVx?=
 =?us-ascii?Q?Yqd0bwAc6s6UdBDpnqLoda1OfwwLoBNhe5CXp3uUurcbh2I9M3Mrrt3hZOYT?=
 =?us-ascii?Q?QRTKMzZIs34sN3vEu+abF5vtjt4fU/iFa0W3/R3JKjH0BsQQMJxKy0jphuJf?=
 =?us-ascii?Q?TwL+Xux3tDPv5YOpSsv+mqvcRK4t2sg4R+J68wypm0mYZt3TYobXZMPNNZNh?=
 =?us-ascii?Q?WKg3QPzt2veUaW5qeZyK8qPlNFjAP2WWAo5dXxlxKFDia8XD5J5FxINrSe4M?=
 =?us-ascii?Q?0sgzLjGYJDqWIAso9+T3Ya15XIGKFJRg8rPeZQn9CDd8reDx0TFz4P73Lk2Y?=
 =?us-ascii?Q?gJcP5B3w3qvBUSrwhk10l0nzI4E9r7vsACUZBhCJBq6mFHxVGCj+FBLRqtPN?=
 =?us-ascii?Q?wNkP4LgSTU/S2azsp1MTL/2rXHPfbdNH01+ybmgZPDLCIhXVPz4dRhq9Z1d4?=
 =?us-ascii?Q?qr7SYIsjarczrP4T9i2SWpOsVcET3aRVQs2/eTVN4bjE2hm+3ZUJ2VwsmV2x?=
 =?us-ascii?Q?zWm99757QJG+zZFfdKsYFev3zTlGg9GrcGJ58tb79+56XbDf98u8kPf7KjpE?=
 =?us-ascii?Q?kNsCvGoZYFf2tfuEhIj7p0bJY+anJFtCgbr3iGszEpYMnUwAkJxNV/qBuoXl?=
 =?us-ascii?Q?nO+UNDu9UctyJfdSk9AJpazVXtjlCLZqUgtidoFC9XHfPKo38Oy8wnDiGfrJ?=
 =?us-ascii?Q?9w=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: G2U4fb4l6NDl6cCdXL1v7Nl6JNTtIRTxcliOn/yNDCFeKiiVL+viMx0Qal5ALMMUTmZteBOHmOjjZIU1jbRrCorJWoqbwn++ew+hrbrg0/PicbqoxRk9mjXNs83d0vx9G34D6ziXEVTDHWLVJnGm1kfP8hVWc3l8xDeTDYN77cu+E+SsHiz1dX2a0v96resW8w9BwSIUGQUYsAuyx1bnkz4Ubrj7CqksQJVtW+WolBXIIuyib0Dl2JX6KTrwNE6UCMRtljcftNumiqNfCphNa3g32ZDoIEoQ2N4n5zdA2rPB+/UQAl7A9L7nzXuGeXxUuf/3iZRbTeNXX/17IBHTYJHO4DfBUfGP8thRGb+WoNtBuK2wnFmrGeJbNpvg4soBixDCJFYBbNL7UhOM/OZqnyYsAXbvXM+D5D5igFXYvQ8d2DPDWC90Z1gAeFRLTnAQOEB3FUJ04wJHqN7/rFeVJ1PjdNABvyilgB3ivvdzJ6QFPVLBIyxfU6Sc6NPwpYs/f2tsTf+79JfvyF1qyKRpyWcfNmpTvRKpMcbqvpPkqb4brPOpBl1OSKXXiI2hFQ2b+l9b9x+agCINixfioSZFj0fjgiF7RwjQnQP5JwnbUunWj65OYP5qeOlEFXPH2d58GC5OZU4ELv80ruGofz59jaVsQaMEqLW6Tdu59ZMf73mBZ3JJrIG4iy2QPskBiVBymZ18PQAjCYVq1T4VZr2GlkJDTIWD/3Nv333hBBO3nd4+9y66t6h1IOpAFl9OZHWQWdZ6l4WIcPxYmmZ3oxwFN3BCQwPw4RaDcf1EHIdQoFFEDF6iJMn/oIX0dfCM353UYRNU44dpsIQOLBjjmieCL3Sh3O4Q3Q1DgZei2Munb6Z+twQiKI//gv4NB6R4IWZSzxh8H+rL7mrIrOYfRCQkKA==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fa1d3eae-325c-413a-a0ec-08dbc02c6710
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2023 14:08:34.5494
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SNHBL/s9xOYiJPLWRgPosyz+3ej9LvzvsdQvku+vf4L2SaSi7fD3P/A8HD//DwfZ1BB6fTvRWR5D/m6c3bFxFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5836
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-09-28_13,2023-09-28_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 mlxscore=0
 mlxlogscore=936 suspectscore=0 phishscore=0 adultscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000
 definitions=main-2309280122
X-Proofpoint-GUID: tX28bMfHq8yttLlD09VIZIHp-9CrlZYm
X-Proofpoint-ORIG-GUID: tX28bMfHq8yttLlD09VIZIHp-9CrlZYm
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 28 Sep 2023 07:11:02 -0700 (PDT)

On Wed, Sep 27, 2023 at 10:51:55PM -0400, KaiLong Wang wrote:
> Fix the following errors reported by checkpatch:
> 
> ERROR: need consistent spacing around '+' (ctx:WxV)
> ERROR: spaces required around that '?' (ctx:VxW)
> 
> Signed-off-by: KaiLong Wang <wangkailong@jari.cn>
> ---
>  fs/nfsd/nfs3proc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I've applied 1/4, 2/4, and 4/4. I'm still debating whether to apply
3/4, that "char *<tab>variable" style is used everywhere (though
I kind of agree it's an eye-sore).


> diff --git a/fs/nfsd/nfs3proc.c b/fs/nfsd/nfs3proc.c
> index 268ef57751c4..3dc1386e30bc 100644
> --- a/fs/nfsd/nfs3proc.c
> +++ b/fs/nfsd/nfs3proc.c
> @@ -171,7 +171,7 @@ nfsd3_proc_read(struct svc_rqst *rqstp)
>  	 * + 1 (xdr opaque byte count) = 26
>  	 */
>  	resp->count = argp->count;
> -	svc_reserve_auth(rqstp, ((1 + NFS3_POST_OP_ATTR_WORDS + 3)<<2) + resp->count +4);
> +	svc_reserve_auth(rqstp, ((1 + NFS3_POST_OP_ATTR_WORDS + 3)<<2) + resp->count + 4);

Since this line is already longer than 80 characters, I updated
this patch to split it.


>  	fh_copy(&resp->fh, &argp->fh);
>  	resp->status = nfsd_read(rqstp, &resp->fh, argp->offset,
> @@ -194,7 +194,7 @@ nfsd3_proc_write(struct svc_rqst *rqstp)
>  				SVCFH_fmt(&argp->fh),
>  				argp->len,
>  				(unsigned long long) argp->offset,
> -				argp->stable? " stable" : "");
> +				argp->stable ? " stable" : "");
>  
>  	resp->status = nfserr_fbig;
>  	if (argp->offset > (u64)OFFSET_MAX ||
> -- 
> 2.17.1

-- 
Chuck Lever