Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Date:   Fri, 29 Sep 2023 13:26:13 +0200
From:   Petr Vorel <pvorel@suse.cz>
To:     ltp@lists.linux.it
Cc:     Olga Kornievskaia <olga.kornievskaia@gmail.com>,
        Anna Schumaker <Anna.Schumaker@netapp.com>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Chuck Lever <chuck.lever@oracle.com>,
        Jeff Layton <jlayton@kernel.org>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/1] nfs_lib.sh: Set NFS 4.2 on TCP as the default
Message-ID: <20230929112613.GA379979@pevik>
Reply-To: Petr Vorel <pvorel@suse.cz>
References: <20230721123852.1420080-1-pvorel@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230721123852.1420080-1-pvorel@suse.cz>
Precedence: bulk

Hi all,

> Previously NFS 3 on UDP was the default, which leaded to test being
> skipped when tests run without parameters:

> TCONF: UDP support disabled on NFS server

> This does not have an effect when tests run properly via
> runtest/net.nfs, which specify parameters. It just safes typing
> -t tcp (and optionally -v 4.2) when one runs single test manually.

FYI patch merged.

Kind regards,
Petr

> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Hi,

> I'm pretty sure, we don't want to have UDP as the default (besides
> skipped with TCONF it was acked by Jeff [1]). But I wonder if NFS 4.2 is
> the best as the default version. Maybe just 4 or 4.1?

> Kind regards,
> Petr

> [1] https://lore.kernel.org/ltp/e4d22ae6cefb34463ed7d04287ca9e81cd0949d8.camel@kernel.org/

>  testcases/network/nfs/nfs_stress/nfs_lib.sh | 4 ++--
...
> -VERSION=${VERSION:=3}
> +VERSION=${VERSION:=4.2}
>  NFILES=${NFILES:=1000}
> -SOCKET_TYPE="${SOCKET_TYPE:-udp}"
> +SOCKET_TYPE="${SOCKET_TYPE:-tcp}"