Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <c6ed1c23c7d2ff4b7e1422458c28a44e25599fb7.camel@kernel.org>
Subject: Re: [PATCH v1 0/7] Clean up XDR encoders for NFSv4 OPEN and LOCK
From:   Jeff Layton <jlayton@kernel.org>
To:     Chuck Lever <cel@kernel.org>, linux-nfs@vger.kernel.org
Cc:     Chuck Lever <chuck.lever@oracle.com>
Date:   Fri, 29 Sep 2023 12:26:33 -0400
In-Reply-To: <169599581942.5622.15965175797823365235.stgit@manet.1015granger.net>
References: <169599581942.5622.15965175797823365235.stgit@manet.1015granger.net>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2023-09-29 at 09:58 -0400, Chuck Lever wrote:
> Tidy up the server-side XDR encoders for NFSv4 OPEN and LOCK
> results. Series applies to nfsd-next. See topic branch
> "nfsd4-encoder-overhaul" in this repo:
>=20
> https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git
>=20
> ---
>=20
> Chuck Lever (7):
>       NFSD: Add nfsd4_encode_lock_owner4()
>       NFSD: Refactor nfsd4_encode_lock_denied()
>       NFSD: Add nfsd4_encode_open_read_delegation4()
>       NFSD: Add nfsd4_encode_open_write_delegation4()
>       NFSD: Add nfsd4_encode_open_none_delegation4()
>       NFSD: Add nfsd4_encode_open_delegation4()
>       NFSD: Clean up nfsd4_encode_open()
>=20
>=20
>  fs/nfsd/nfs4state.c |   6 +-
>  fs/nfsd/nfs4xdr.c   | 305 +++++++++++++++++++++++++++-----------------
>  fs/nfsd/xdr4.h      |   2 +-
>  3 files changed, 189 insertions(+), 124 deletions(-)
>=20
> --
> Chuck Lever
>=20

Looks pretty straightforward. I had one minor nit about the struct
packing but the rest looks fine. You can add:

Reviewed-by: Jeff Layton <jlayton@kernel.org>